Skip to content

Commit 8a004e0

Browse files
committed
Use physicalDamage.Average in armour calculation
fixes ArgumentException in NodeValue constructor. Using NodeValues with different Minimum and Maximum as divisors is not a good idea.
1 parent 043c035 commit 8a004e0

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

PoESkillTree.Engine.Computation.Common/NodeValue.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System;
22
using System.Collections.Generic;
3-
using System.Linq;
43
using PoESkillTree.Engine.Utils.Extensions;
54

65
namespace PoESkillTree.Engine.Computation.Common

PoESkillTree.Engine.Computation.Data/GivenStats/DataDrivenMechanicsBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ protected IDamageRelatedStatBuilder DamageTaken(DamageType damageType)
3636
=> DamageTypeBuilders.From(damageType).Damage.Taken;
3737

3838
protected static ValueBuilder PhysicalDamageReductionFromArmour(ValueBuilder armour, ValueBuilder physicalDamage)
39-
=> 100 * armour / (armour + 10 * physicalDamage);
39+
=> 100 * armour / (armour + 10 * physicalDamage.Average);
4040

4141
protected ValueBuilder ChanceToHitValue(
4242
IStatBuilder accuracyStat, IStatBuilder evasionStat, IConditionBuilder isBlinded)

0 commit comments

Comments
 (0)