From 40334b7ba9d2192f25ae8ee96ee1c0673c07abef Mon Sep 17 00:00:00 2001 From: JonathanLab Date: Wed, 6 May 2026 17:27:48 +0200 Subject: [PATCH] fix(code): remove unnecessary branch rollback in PR creation saga Generated-By: PostHog Code Task-Id: 17f6ee1d-e76c-4ed6-aac6-04183d722858 --- apps/code/package.json | 4 ++-- apps/code/src/main/services/git/create-pr-saga.ts | 6 +----- pnpm-lock.yaml | 4 +++- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/apps/code/package.json b/apps/code/package.json index 188469e3e..78a4c1ab1 100644 --- a/apps/code/package.json +++ b/apps/code/package.json @@ -63,7 +63,7 @@ "@types/node": "^24.0.0", "@types/react": "^19.1.0", "@types/react-dom": "^19.1.0", - "@types/semver": "^7.5.0", + "@types/semver": "^7.7.1", "@vitejs/plugin-react": "^4.2.1", "@vitest/ui": "^4.0.10", "adm-zip": "^0.5.16", @@ -186,11 +186,11 @@ "react-markdown": "^10.1.0", "react-resizable-panels": "^3.0.6", "reflect-metadata": "^0.2.2", - "semver": "^7.6.0", "rehype-raw": "^7.0.0", "rehype-sanitize": "^6.0.0", "remark-breaks": "^4.0.0", "remark-gfm": "^4.0.1", + "semver": "^7.6.0", "shadcn": "^4.1.2", "smol-toml": "^1.6.0", "sonner": "^2.0.7", diff --git a/apps/code/src/main/services/git/create-pr-saga.ts b/apps/code/src/main/services/git/create-pr-saga.ts index d99ea5d19..5c6b6ee83 100644 --- a/apps/code/src/main/services/git/create-pr-saga.ts +++ b/apps/code/src/main/services/git/create-pr-saga.ts @@ -87,11 +87,7 @@ export class CreatePrSaga extends Saga { await this.step({ name: "creating-branch", execute: () => this.deps.createBranch(directoryPath, branchName), - rollback: async () => { - if (currentBranch) { - await this.deps.checkoutBranch(directoryPath, currentBranch); - } - }, + rollback: async () => {}, }); } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 9df9e2959..0d2de72fe 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -447,7 +447,7 @@ importers: specifier: ^19.1.0 version: 19.2.3(@types/react@19.2.11) '@types/semver': - specifier: ^7.5.0 + specifier: ^7.7.1 version: 7.7.1 '@vitejs/plugin-react': specifier: ^4.2.1 @@ -5344,6 +5344,7 @@ packages: '@ungap/structured-clone@1.3.0': resolution: {integrity: sha512-WmoN8qaIAo7WTYWbAZuG8PYEhn5fkz7dZrqTBZ7dtt//lL2Gwms1IcnQ5yHqjDfX8Ft5j4YzDM23f87zBfDe9g==} + deprecated: Potential CWE-502 - Update to 1.3.1 or higher '@urql/core@5.2.0': resolution: {integrity: sha512-/n0ieD0mvvDnVAXEQgX/7qJiVcvYvNkOHeBvkwtylfjydar123caCXcl58PXFY11oU1oquJocVXHxLAbtv4x1A==} @@ -11337,6 +11338,7 @@ packages: uuid@7.0.3: resolution: {integrity: sha512-DPSke0pXhTZgoF/d+WSt2QaKMCFSfx7QegxEWT+JOuHF5aWrKEn0G+ztjuJg/gG8/ItK+rbPCD/yNv8yyih6Cg==} + deprecated: uuid@10 and below is no longer supported. For ESM codebases, update to uuid@latest. For CommonJS codebases, use uuid@11 (but be aware this version will likely be deprecated in 2028). hasBin: true v8-to-istanbul@9.3.0: