Skip to content

Commit 80333bb

Browse files
Skip the flaky child-attach-session E2E test on Windows PowerShell
Un-skipping the Windows PowerShell E2E suite surfaced one more attach-family flake: `CanLaunchScriptWithNewChildAttachSession`. It passed on the prior CI run (`a4e8a823e`) but timed out (`TaskCanceledException` at its 30s budget) on the next (`25d9e58dd`) with no relevant code change in between, so it's genuinely flaky on the slow in-box Windows PowerShell CI runners rather than broken. The test runs `Start-DebugAttachSession` and waits for the server's `startDebugging` reverse-request round-trip; on in-box Windows PowerShell that round-trip is slow enough to intermittently miss the timeout. That's the same in-box attach-E2E reliability bucket as #2323, and its two siblings are already skipped there: `CanAttachScriptWithPathMappings` (the cross-process `Debug-Runspace` wedge) and `CanLaunchScriptWithNewChildAttachSessionAsJob` (no `ThreadJob` on Windows PowerShell). So skip this one on Windows PowerShell too, keeping the rest of the now-un-skipped DAP suite running. The flake only reproduces on the constrained CI runner, not on a fast dev box, so I'm matching how the sibling attach tests are handled rather than chasing a timeout bump I can't validate locally. Drafted by Copilot (Claude Opus 4.8). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 25d9e58 commit 80333bb

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -570,6 +570,9 @@ public async Task CanLaunchScriptWithNewChildAttachSession(
570570
Skip.If(PsesStdioLanguageServerProcessHost.RunningInConstrainedLanguageMode,
571571
"PowerShellEditorServices.Command is not signed to run FLM in Constrained Language Mode.");
572572

573+
Skip.If(PsesStdioLanguageServerProcessHost.IsWindowsPowerShell,
574+
"The Start-DebugAttachSession reverse-request round-trip is flaky on in-box Windows PowerShell CI runners (see #2323).");
575+
573576
string script = NewTestFile($"Start-DebugAttachSession {paramString}");
574577

575578
using CancellationTokenSource timeoutCts = new(30000);

0 commit comments

Comments
 (0)