fix: add client-side validation to prevent goal target of 0 or less (#929)

[mallya-m]

Summary

Closes #929

The progress bar NaN issue when target=0 was already guarded in the calculation, but users could still submit a goal with target=0. This PR adds explicit client-side validation that catches target ≤ 0 before the API call and shows a clear error message.

Type of Change

• Bug fix

Changes Made

• Added client-side validation in handleCreate — returns early with error message if target <= 0
• Complements the existing min={1} attribute and division guard already in the codebase

How to Test

1. Go to Goals section
2. Try creating a goal with target = 0
3. See error: "Target must be greater than 0."

Checklist

• Linked issue in summary
• No TypeScript errors
• Self-reviewed the diff

[vercel]

@mallya-m is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

• level:beginner — 20 pts
• level:intermediate — 35 pts
• level:advanced — 55 pts
• level:critical — 80 pts

Quality (optional):

• quality:clean — ×1.2 multiplier
• quality:exceptional — ×1.5 multiplier

Validation (required to score):

• gssoc:approved — counts for points
• gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

[mallya-m]

@Priyanshu-byte-coder PR ready! Added explicit client-side validation in handleCreate that catches target ≤ 0 before the API call and shows a clear error message.
Could you add gssoc labels ?
Ready for merge!

[mallya-m]

@Priyanshu-byte-coder all CI checks pass (Build, Lint, Type check, Dependency audit).

The E2E failures are pre-existing infrastructure issues unrelated to this PR:

• sharp package missing in standalone mode
• Supabase unavailable in CI environment
• Dashboard heading timeout (session/auth issue in test env)

My change only adds client-side validation in handleCreate to prevent target ≤ 0. Ready for merge!

[Priyanshu-byte-coder]

This PR now has merge conflicts with main. Please rebase your branch against the latest main and force-push to resolve. Run: git fetch upstream && git rebase upstream/main

[Priyanshu-byte-coder]

This PR has merge conflicts with the current main branch. Please rebase your branch onto main, resolve the conflicts, and force-push. Once conflicts are resolved and the PR is marked as mergeable it will be reviewed for merging.

[Priyanshu-byte-coder]

This PR has developed merge conflicts after recent merges to main. Please rebase onto the latest main branch, resolve all conflicts, and force-push. Once the PR is conflict-free it will be reviewed for merging.

[Priyanshu-byte-coder]

This PR has merge conflicts with main. Please rebase:

git fetch origin
git rebase origin/main
# fix conflicts, then:
git push --force-with-lease

[Priyanshu-byte-coder]

This PR has merge conflicts. Please rebase on the latest main to resolve them — the feature/fix is approved for GSSoC scoring.

[Priyanshu-byte-coder]

This PR has merge conflicts with main. Please rebase to unblock it:

git fetch origin
git rebase origin/main
# resolve conflicts, then:
git push --force-with-lease

[Priyanshu-byte-coder]

This PR has merge conflicts with main. Please rebase:

git fetch origin
git rebase origin/main
git push --force-with-lease

[Priyanshu-byte-coder]

This PR has merge conflicts with main — please rebase:

git fetch origin
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease

[Priyanshu-byte-coder]

This PR has merge conflicts with main due to recent changes. Please rebase to continue:

git fetch origin
git rebase origin/main

Once you resolve the conflicts and CI passes, we can review for merge.

[mallya-m]

@Priyanshu-byte-coder rebased onto latest upstream/main — all conflicts resolved. Build , Lint , Type check.
Ready to merge!

[mallya-m]

@Priyanshu-byte-coder re-applied the target validation fix after rebase — all conflicts resolved and fix is in place. Ready to merge!