feat(onboarding): add first-time dashboard tour for new users#305
feat(onboarding): add first-time dashboard tour for new users#305mallya-m wants to merge 5 commits into
Conversation
|
@mallya-m is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Priyanshu-byte-coder |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
driver.js is imported in OnboardingTour.tsx but not declared in package.json. This causes the build and dependency audit to fail.
Add it to package.json:
npm install driver.jsThen commit the updated package.json and package-lock.json. The onboarding tour implementation itself looks solid.
|
This PR conflicts with recently merged changes. Please rebase onto main: Resolve any conflicts, push, and I'll review. |
|
Hi @mallya-m — this PR has a merge conflict with git fetch upstream
git rebase upstream/main
# resolve conflicts, then:
git push --force-with-leaseOnce rebased, we'll review and merge. |
54eda1a to
cd9ebfb
Compare
|
Rebased onto latest main and resolved all merge conflicts. Also fixed driver.js dependency and synced package-lock.json. All CI checks are now passing locally and on GitHub. Ready to |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
- CDN CSS version mismatch — OnboardingTour.tsx injects at runtime but package.json installs driver.js@^1.4.0. These versions differ and may cause visual glitches. Import statically instead: import 'driver.js/dist/driver.css'. 2. No migration file — PR description mentions adding seen_onboarding column but no supabase/migrations/ file is in the diff. Feature will break on any fresh deployment. Include the migration. 3. Missing EOF newlines on OnboardingTour.tsx, DashboardHeader.tsx, and settings/route.ts. 4. Indentation broken in settings/route.ts — the user resolution block loses indentation (starts at column 0 inside an if block). 5. package-lock.json churn — unrelated npm version artifacts. Revert.
cd9ebfb to
3dacde4
Compare
|
@Priyanshu-byte-coder all issues addressed:
Ready for merge! |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Issues found in this PR:
- Missing EOF newline — add a trailing newline to all modified files.
All checks should pass now. |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
PR is conflicting with main. Please rebase:
git fetch upstream
git rebase upstream/main
git push --force-with-lease
5741396 to
410c25b
Compare
|
@Priyanshu-byte-coder rebased onto latest main and all issues resolved:
|
|
@Priyanshu-byte-coder the only remaining CI failure is The test checks for a single heading named "DevTrack" but the landing page now has two:
This was introduced by a recent merge to main. My changes only touch dashboard components and don't affect the landing page at all. The same test fails on a fresh checkout of main. All 5 other tests pass. |
|
@Priyanshu-byte-coder rebased onto latest main — conflicts in settings/route.ts and layout.tsx resolved. Ready for merge! |
|
This PR has merge conflicts with |
|
@Priyanshu-byte-coder conflict resolved — settings/route.ts and DashboardHeader.tsx rebased onto latest main. |
|
@Priyanshu-byte-coder the E2E failure is a pre-existing test issue unrelated to my changes. The test looks for a heading named "Goals" but the GoalTracker component heading was likely renamed in a recent upstream merge. My PR only touches:
None of these files touch GoalTracker or its heading. All 5 other tests pass. Ready for merge! |
|
This PR has conflicts with the current |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
This PR has merge conflicts with main. Please rebase onto the latest main branch and resolve conflicts to proceed with merging.
|
This PR has merge conflicts with |
|
This PR has merge conflicts with |
|
This PR has merge conflicts with the current main branch. Please rebase on the latest main to resolve them — your contribution is labeled for GSSoC scoring. |
|
This PR has merge conflicts with git fetch origin
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease |
33d5bc0 to
4565876
Compare
4565876 to
227ede4
Compare
|
@Priyanshu-byte-coder rebased onto latest upstream/main — all conflicts resolved. Build , Lint , Type check Only failing check is E2E Playwright — pre-existing issue unrelated to this PR (Supabase credentials unavailable in CI runner). Ready to merge! |
What does this PR do?
Adds a step-by-step onboarding tour for first-time users using driver.js, highlighting key dashboard widgets with explanatory popups.
Related issue
Closes #251
Changes made
OnboardingTour.tsxcomponent using driver.jsseen_onboardingis falseseen_onboardingcolumn to users table via SQL migration/api/user/settingsto acceptseen_onboardingfieldHow to test
Screenshots