Various script updates and fixes

- Doomking Balerdroch: Should check that it can be Special Summoned in face-up Defense Position specifically.
- Junk Gardna: Shouldn't change the battle position of the target of the first effect if you control it on resolution.
- Regenesis Lord: The Setting effect shouldn't be HOPT.
- Scrap Fist: Only the piercing damage and the battle protection effects should be applied to the "Junk Warrior". All the effects should be considered the effects of "Scrap Fist".
- Updated various cards to use the new constants for "Junk Synchron" and "Junk Warrior".
- Updated "Card.UpdateAttack" and "Card.UpdateDefense": Now they no longer check that the monster can lose that amount of ATK/DEF. Effects that need the monster to lose an exact amount of ATK/DEF should specifically check that the monster has at least that much ATK/DEF.

Author: pyrQ

official/c22812963.lua

@@ -6,42 +6,42 @@ function s.initial_effect(c)
 	c:EnableReviveLimit()
 	c:AddMustBeSpecialSummoned()
 	--Must be Special Summoned (from your hand) by banishing 1 face-up monster you control with 2500 original ATK and DEF
+	local e0=Effect.CreateEffect(c)
+	e0:SetDescription(aux.Stringid(id,0))
+	e0:SetType(EFFECT_TYPE_FIELD)
+	e0:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_UNCOPYABLE)
+	e0:SetCode(EFFECT_SPSUMMON_PROC)
+	e0:SetRange(LOCATION_HAND)
+	e0:SetCountLimit(1,id,EFFECT_COUNT_CODE_OATH)
+	e0:SetCondition(s.selfspcon)
+	e0:SetTarget(s.selfsptg)
+	e0:SetOperation(s.selfspop)
+	c:RegisterEffect(e0)
+	--Set 1 "Regenesis" Spell/Trap from your Deck
 	local e1=Effect.CreateEffect(c)
-	e1:SetDescription(aux.Stringid(id,0))
-	e1:SetType(EFFECT_TYPE_FIELD)
-	e1:SetProperty(EFFECT_FLAG_CANNOT_DISABLE+EFFECT_FLAG_UNCOPYABLE)
-	e1:SetCode(EFFECT_SPSUMMON_PROC)
-	e1:SetRange(LOCATION_HAND)
-	e1:SetCountLimit(1,id,EFFECT_COUNT_CODE_OATH)
-	e1:SetCondition(s.selfspcon)
-	e1:SetTarget(s.selfsptg)
-	e1:SetOperation(s.selfspop)
+	e1:SetDescription(aux.Stringid(id,1))
+	e1:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
+	e1:SetProperty(EFFECT_FLAG_DELAY)
+	e1:SetCode(EVENT_SPSUMMON_SUCCESS)
+	e1:SetTarget(s.settg)
+	e1:SetOperation(s.setop)
 	c:RegisterEffect(e1)
-	--Set 1 "Regenesis" Spell/Trap from your Deck
+	--Gains 2500 ATK during the Battle Phase only
 	local e2=Effect.CreateEffect(c)
-	e2:SetDescription(aux.Stringid(id,1))
-	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
-	e2:SetProperty(EFFECT_FLAG_DELAY)
-	e2:SetCode(EVENT_SPSUMMON_SUCCESS)
-	e2:SetCountLimit(1,{id,1})
-	e2:SetTarget(s.settg)
-	e2:SetOperation(s.setop)
+	e2:SetType(EFFECT_TYPE_SINGLE)
+	e2:SetProperty(EFFECT_FLAG_SINGLE_RANGE)
+	e2:SetCode(EFFECT_UPDATE_ATTACK)
+	e2:SetRange(LOCATION_MZONE)
+	e2:SetCondition(function() return Duel.IsBattlePhase() end)
+	e2:SetValue(2500)
 	c:RegisterEffect(e2)
-	--Gains 2500 ATK during the Battle Phase only
+	--Inflicts piercing battle damage
 	local e3=Effect.CreateEffect(c)
 	e3:SetType(EFFECT_TYPE_SINGLE)
-	e3:SetProperty(EFFECT_FLAG_SINGLE_RANGE)
-	e3:SetCode(EFFECT_UPDATE_ATTACK)
-	e3:SetRange(LOCATION_MZONE)
-	e3:SetCondition(function() return Duel.IsBattlePhase() end)
-	e3:SetValue(2500)
+	e3:SetCode(EFFECT_PIERCE)
 	c:RegisterEffect(e3)
-	--Inflicts piercing battle damage
-	local e4=Effect.CreateEffect(c)
-	e4:SetType(EFFECT_TYPE_SINGLE)
-	e4:SetCode(EFFECT_PIERCE)
-	c:RegisterEffect(e4)
 end
+s.listed_names={id}
 s.listed_series={SET_REGENESIS}
 function s.selfspconfilter(c)
 	return (c:IsBaseAttack(2500) and c:IsBaseDefense(2500)) and c:IsFaceup() and c:IsAbleToRemoveAsCost()
@@ -56,17 +56,16 @@ function s.selfsptg(e,tp,eg,ep,ev,re,r,rp,chk,c)
 	local rg=Duel.GetMatchingGroup(s.selfspconfilter,tp,LOCATION_MZONE,0,nil)
 	local g=aux.SelectUnselectGroup(rg,e,tp,1,1,aux.ChkfMMZ(1),1,tp,HINTMSG_REMOVE,nil,nil,true)
 	if #g>0 then
-		g:KeepAlive()
 		e:SetLabelObject(g)
 		return true
 	end
 	return false
 end
 function s.selfspop(e,tp,eg,ep,ev,re,r,rp,c)
 	local g=e:GetLabelObject()
-	if not g then return end
-	Duel.Remove(g,POS_FACEUP,REASON_COST)
-	g:DeleteGroup()
+	if g then
+		Duel.Remove(g,POS_FACEUP,REASON_COST)
+	end
 end
 function s.setfilter(c)
 	return c:IsSetCard(SET_REGENESIS) and c:IsSpellTrap() and c:IsSSetable()

official/c33750856.lua

@@ -58,31 +58,31 @@ function s.atkop(e,tp,eg,ep,ev,re,r,rp)
 		if oc:IsControler(tp) then oc=tg:GetNext() end
 		if oc and oc:IsFaceup() then
 			--Change ATK to 0
-			local e0=Effect.CreateEffect(c)
-			e0:SetType(EFFECT_TYPE_SINGLE)
-			e0:SetCode(EFFECT_SET_ATTACK_FINAL)
-			e0:SetValue(0)
-			e0:SetReset(RESETS_STANDARD_PHASE_END)
-			oc:RegisterEffect(e0)
-		end
-		--Cannot be destroyed by that battle
-		for tc in tg:Iter() do
 			local e1=Effect.CreateEffect(c)
 			e1:SetType(EFFECT_TYPE_SINGLE)
-			e1:SetCode(EFFECT_INDESTRUCTABLE_BATTLE)
-			e1:SetValue(1)
-			e1:SetReset(RESET_EVENT|RESETS_STANDARD|RESET_PHASE|PHASE_DAMAGE)
-			tc:RegisterEffect(e1)
+			e1:SetCode(EFFECT_SET_ATTACK_FINAL)
+			e1:SetValue(0)
+			e1:SetReset(RESETS_STANDARD_PHASE_END)
+			oc:RegisterEffect(e1)
+		end
+		for tc in tg:Iter() do
+			--Cannot be destroyed by that battle
+			local e2=Effect.CreateEffect(c)
+			e2:SetType(EFFECT_TYPE_SINGLE)
+			e2:SetCode(EFFECT_INDESTRUCTABLE_BATTLE)
+			e2:SetValue(1)
+			e2:SetReset(RESET_EVENT|RESETS_STANDARD|RESET_PHASE|PHASE_DAMAGE)
+			tc:RegisterEffect(e2)
 		end
 	end
 	--Take no battle damage from that battle
-	local e2=Effect.CreateEffect(c)
-	e2:SetType(EFFECT_TYPE_FIELD)
-	e2:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
-	e2:SetCode(EFFECT_AVOID_BATTLE_DAMAGE)
-	e2:SetTargetRange(1,1)
-	e2:SetReset(RESET_PHASE|PHASE_DAMAGE)
-	Duel.RegisterEffect(e2,tp)
+	local e3=Effect.CreateEffect(c)
+	e3:SetType(EFFECT_TYPE_FIELD)
+	e3:SetProperty(EFFECT_FLAG_PLAYER_TARGET)
+	e3:SetCode(EFFECT_AVOID_BATTLE_DAMAGE)
+	e3:SetTargetRange(1,1)
+	e3:SetReset(RESET_PHASE|PHASE_DAMAGE)
+	Duel.RegisterEffect(e3,tp)
 end
 function s.negcon(e,tp,eg,ep,ev,re,r,rp)
 	if Duel.GetCurrentPhase()&(PHASE_DAMAGE|PHASE_DAMAGE_CAL)==0 or Duel.IsDamageCalculated() then return false end
@@ -99,12 +99,12 @@ function s.negop(e,tp,eg,ep,ev,re,r,rp)
 		local tc=Duel.GetFirstTarget()
 		if tc:IsFaceup() and tc:IsRelateToBattle() then
 			--Gains 700 ATK
-			local e0=Effect.CreateEffect(e:GetHandler())
-			e0:SetType(EFFECT_TYPE_SINGLE)
-			e0:SetCode(EFFECT_UPDATE_ATTACK)
-			e0:SetValue(700)
-			e0:SetReset(RESET_EVENT|RESETS_STANDARD)
-			tc:RegisterEffect(e0)
+			local e1=Effect.CreateEffect(e:GetHandler())
+			e1:SetType(EFFECT_TYPE_SINGLE)
+			e1:SetCode(EFFECT_UPDATE_ATTACK)
+			e1:SetValue(700)
+			e1:SetReset(RESET_EVENT|RESETS_STANDARD)
+			tc:RegisterEffect(e1)
 		end
 	end
 end

official/c37993923.lua

@@ -2,60 +2,55 @@
 --Junk Gardna
 local s,id=GetID()
 function s.initial_effect(c)
-	--synchro summon
-	Synchro.AddProcedure(c,s.matfilter,1,1,Synchro.NonTuner(nil),1,99)
 	c:EnableReviveLimit()
-	--pos change quick
+	--Synchro Summon procedure: "Junk Synchron" + 1+ non-Tuner monsters
+	Synchro.AddProcedure(c,s.tunerfilter,1,1,Synchro.NonTuner(nil),1,99)
+	--Change the battle position of 1 monster your opponent controls
 	local e1=Effect.CreateEffect(c)
 	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetCategory(CATEGORY_POSITION)
-	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetType(EFFECT_TYPE_QUICK_O)
+	e1:SetProperty(EFFECT_FLAG_CARD_TARGET)
 	e1:SetCode(EVENT_FREE_CHAIN)
-	e1:SetHintTiming(0,TIMINGS_CHECK_MONSTER_E)
-	e1:SetCountLimit(1)
 	e1:SetRange(LOCATION_MZONE)
-	e1:SetTarget(s.postg1)
-	e1:SetOperation(s.posop)
+	e1:SetCountLimit(1)
+	e1:SetHintTiming(0,TIMING_STANDBY_PHASE|TIMING_MAIN_END|TIMINGS_CHECK_MONSTER_E)
+	e1:SetTarget(s.postg(true))
+	e1:SetOperation(s.posop(true))
 	c:RegisterEffect(e1)
-	--pos change trigger
+	--Change the battle position of 1 monster on the field
 	local e2=Effect.CreateEffect(c)
-	e2:SetDescription(aux.Stringid(id,0))
+	e2:SetDescription(aux.Stringid(id,1))
 	e2:SetCategory(CATEGORY_POSITION)
-	e2:SetProperty(EFFECT_FLAG_CARD_TARGET+EFFECT_FLAG_DAMAGE_STEP+EFFECT_FLAG_DELAY)
 	e2:SetType(EFFECT_TYPE_SINGLE+EFFECT_TYPE_TRIGGER_O)
+	e2:SetProperty(EFFECT_FLAG_DELAY+EFFECT_FLAG_CARD_TARGET)
 	e2:SetCode(EVENT_TO_GRAVE)
-	e2:SetCondition(s.poscon)
-	e2:SetTarget(s.postg2)
-	e2:SetOperation(s.posop)
+	e2:SetCondition(function(e) return e:GetHandler():IsPreviousLocation(LOCATION_ONFIELD) end)
+	e2:SetTarget(s.postg(false))
+	e2:SetOperation(s.posop(false))
 	c:RegisterEffect(e2)
 end
-s.material={63977008}
-s.listed_names={63977008}
+s.material={CARD_JUNK_SYNCHRON}
+s.listed_names={CARD_JUNK_SYNCHRON}
 s.material_setcode=SET_SYNCHRON
-function s.matfilter(c,scard,sumtype,tp)
-	return c:IsSummonCode(scard,sumtype,tp,63977008) or c:IsHasEffect(20932152)
-end
-function s.postg1(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsControler(1-tp) and chkc:IsLocation(LOCATION_MZONE) and chkc:IsCanChangePosition() end
-	if chk==0 then return Duel.IsExistingTarget(Card.IsCanChangePosition,tp,0,LOCATION_MZONE,1,nil) end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_POSCHANGE)
-	local g=Duel.SelectTarget(tp,Card.IsCanChangePosition,tp,0,LOCATION_MZONE,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_POSITION,g,1,0,0)
-end
-function s.poscon(e,tp,eg,ep,ev,re,r,rp)
-	return e:GetHandler():IsPreviousLocation(LOCATION_ONFIELD)
+function s.tunerfilter(c,lc,stype,tp)
+	return c:IsSummonCode(lc,stype,tp,CARD_JUNK_SYNCHRON) or c:IsHasEffect(20932152)
 end
-function s.postg2(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
-	if chkc then return chkc:IsLocation(LOCATION_MZONE) and chkc:IsCanChangePosition() end
-	if chk==0 then return Duel.IsExistingTarget(Card.IsCanChangePosition,tp,LOCATION_MZONE,LOCATION_MZONE,1,nil) end
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_POSCHANGE)
-	local g=Duel.SelectTarget(tp,Card.IsCanChangePosition,tp,LOCATION_MZONE,LOCATION_MZONE,1,1,nil)
-	Duel.SetOperationInfo(0,CATEGORY_POSITION,g,1,0,0)
+function s.postg(oppo)
+	return function(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
+			if chkc then return (chkc:IsControler(1-tp) or not oppo) and chkc:IsLocation(LOCATION_MZONE) and chkc:IsCanChangePosition() end
+			local location=oppo and 0 or LOCATION_MZONE
+			if chk==0 then return Duel.IsExistingTarget(Card.IsCanChangePosition,tp,location,LOCATION_MZONE,1,nil) end
+			Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_POSCHANGE)
+			local g=Duel.SelectTarget(tp,Card.IsCanChangePosition,tp,location,LOCATION_MZONE,1,1,nil)
+			Duel.SetOperationInfo(0,CATEGORY_POSITION,g,1,tp,0)
+		end
 end
-function s.posop(e,tp,eg,ep,ev,re,r,rp)
-	local tc=Duel.GetFirstTarget()
-	if tc and tc:IsRelateToEffect(e) then
-		Duel.ChangePosition(tc,POS_FACEUP_DEFENSE,POS_FACEDOWN_DEFENSE,POS_FACEUP_ATTACK,POS_FACEUP_ATTACK)
-	end
+function s.posop(oppo)
+	return function(e,tp,eg,ep,ev,re,r,rp,chk,chkc)
+			local tc=Duel.GetFirstTarget()
+			if tc:IsRelateToEffect(e) and (tc:IsControler(1-tp) or not oppo) then
+				Duel.ChangePosition(tc,POS_FACEUP_DEFENSE,POS_FACEDOWN_DEFENSE,POS_FACEUP_ATTACK,POS_FACEUP_ATTACK)
+			end
+		end
 end