Various script fixes

- Crusadia Vanguard: Should be negatable by an effect such as that of "Ghost Belle & Haunted Mansion" if you activate it by Tributing a monster.
- Cubic Rebirth: Should be treated as an effect that includes Special Summoning from the hand, Deck, and GY.
- Goddess Verdande's Guidance: Its second effect should be negatable by an effect such as that of "Ash Blossom & Joyous Spring".
- Luminous Dragon Ritual: Banishing and Special Summoning should be treated as happening at the same time. Should still banish even if there's no "Paladin of Photon Dragon" in your hand on resolution.
- Rebirth of the Seventh Emperors: The damaging effect should be applied even if the target isn't there anymore on resolution.
- Reincarnation of the Seventh Emperors: Should be treated as an effect that includes Special Summoning and inflict damage.

Author: pyrQ

official/c34834619.lua

@@ -2,48 +2,47 @@
 --Luminous Dragon Ritual
 local s,id=GetID()
 function s.initial_effect(c)
+	--Ritual Summon 1 "Paladin of Photon Dragon" from your hand
 	Ritual.AddProcEqualCode(c,4,nil,85346853)
-	--Special summon and treat it as a Ritual summon
+	--Banish monsters from your GY whose total Levels equal exactly 4, then Special Summon 1 "Paladin of Photon Dragon" from your hand (this is treated as a Ritual Summon)
 	local e1=Effect.CreateEffect(c)
-	e1:SetDescription(aux.Stringid(id,0))
-	e1:SetCategory(CATEGORY_SPECIAL_SUMMON)
+	e1:SetDescription(aux.Stringid(id,1))
+	e1:SetCategory(CATEGORY_REMOVE+CATEGORY_SPECIAL_SUMMON)
 	e1:SetType(EFFECT_TYPE_IGNITION)
 	e1:SetRange(LOCATION_GRAVE)
 	e1:SetCost(Cost.SelfBanish)
 	e1:SetTarget(s.sptg)
 	e1:SetOperation(s.spop)
 	c:RegisterEffect(e1)
 end
-s.listed_names={85346853}
-function s.mtfilter(c,e)
+s.listed_names={85346853} --"Paladin of Photon Dragon"
+function s.rmfilter(c,e,tp)
 	return c:HasLevel() and c:IsAbleToRemove() and not c:IsImmuneToEffect(e) and aux.SpElimFilter(c,true)
 end
-function s.spfilter(c,e,tp,m)
+function s.rescon(sg,e,tp,mg)
+	return Duel.GetMZoneCount(tp,sg)>0 and sg:GetSum(Card.GetLevel)==4
+end
+function s.spfilter(c,e,tp)
 	return c:IsCode(85346853) and c:IsCanBeSpecialSummoned(e,SUMMON_TYPE_RITUAL,tp,true,false)
-		and m:CheckWithSumEqual(Card.GetRitualLevel,4,1,99,c)
 end
 function s.sptg(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then
-		if Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return false end
-		local mg=Duel.GetMatchingGroup(s.mtfilter,tp,LOCATION_MZONE|LOCATION_GRAVE,0,e:GetHandler(),e)
-		return Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_HAND,0,1,nil,e,tp,mg)
+		local rg=Duel.GetMatchingGroup(s.rmfilter,tp,LOCATION_MZONE|LOCATION_GRAVE,0,nil,e,tp)
+		return #rg>0 and aux.SelectUnselectGroup(rg,e,tp,1,4,s.rescon,0)
+			and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_HAND,0,1,nil,e,tp)
 	end
+	Duel.SetOperationInfo(0,CATEGORY_REMOVE,nil,1,tp,LOCATION_GRAVE)
 	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_HAND)
-	Duel.SetOperationInfo(0,CATEGORY_REMOVE,nil,0,tp,LOCATION_GRAVE)
 end
 function s.spop(e,tp,eg,ep,ev,re,r,rp)
-	if Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return end
-	local mg=Duel.GetMatchingGroup(s.mtfilter,tp,LOCATION_MZONE|LOCATION_GRAVE,0,nil,e)
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-	local g=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_HAND,0,1,1,nil,e,tp,mg)
-	local tc=g:GetFirst()
-	if tc then
-		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_REMOVE)
-		local mat=mg:SelectWithSumEqual(tp,Card.GetRitualLevel,4,1,99,tc)
-		tc:SetMaterial(mat)
-		Duel.ReleaseRitualMaterial(mat)
-		Duel.BreakEffect()
-		Duel.SpecialSummon(tc,SUMMON_TYPE_RITUAL,tp,tp,true,false,POS_FACEUP)
-		tc:CompleteProcedure()
+	local g=Duel.GetMatchingGroup(s.rmfilter,tp,LOCATION_MZONE|LOCATION_GRAVE,0,nil,e,tp)
+	if #g==0 then return end
+	local rg=aux.SelectUnselectGroup(g,e,tp,1,4,s.rescon,1,tp,HINTMSG_REMOVE)
+	if #rg>0 and Duel.Remove(rg,POS_FACEUP,REASON_EFFECT)>0 and rg:IsExists(Card.IsLocation,1,nil,LOCATION_REMOVED) then
+		Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
+		local sc=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_HAND,0,1,1,nil,e,tp):GetFirst()
+		if sc and Duel.SpecialSummon(sc,SUMMON_TYPE_RITUAL,tp,tp,true,false,POS_FACEUP)>0 then
+			sc:CompleteProcedure()
+		end
 	end
 end

official/c55312487.lua

@@ -2,79 +2,62 @@
 --Crusadia Vanguard
 local s,id=GetID()
 function s.initial_effect(c)
-	--activate
+	--When you activate this card: You can also Tribute 1 "Crusadia" or "World Legacy" monster; if you did, Special Summon 1 "Crusadia" or "World Legacy" monster, with a different original name, from your Deck or GY
 	local e1=Effect.CreateEffect(c)
+	e1:SetDescription(aux.Stringid(id,0))
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_FREE_CHAIN)
-	e1:SetHintTiming(0,TIMING_END_PHASE)
+	e1:SetHintTiming(0,TIMING_STANDBY_PHASE|TIMING_MAIN_END|TIMING_BATTLE_START|TIMINGS_CHECK_MONSTER_E)
 	e1:SetCountLimit(1,id,EFFECT_COUNT_CODE_OATH)
+	e1:SetCost(s.cost)
 	e1:SetTarget(s.target)
+	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
-	--cannot select, except link thing
+	--While you control a "Crusadia" Link Monster, your opponent's monsters can only target Link Monsters for attacks
 	local e2=Effect.CreateEffect(c)
 	e2:SetType(EFFECT_TYPE_FIELD)
+	e2:SetCode(EFFECT_CANNOT_SELECT_BATTLE_TARGET)
 	e2:SetRange(LOCATION_SZONE)
 	e2:SetTargetRange(0,LOCATION_MZONE)
-	e2:SetCode(EFFECT_CANNOT_SELECT_BATTLE_TARGET)
-	e2:SetCondition(s.catcondition)
-	e2:SetValue(s.catlimit)
+	e2:SetCondition(function(e) return Duel.IsExistingMatchingCard(function(c) return c:IsSetCard(SET_CRUSADIA) and c:IsLinkMonster() end,e:GetHandlerPlayer(),LOCATION_MZONE,0,1,nil) end)
+	e2:SetValue(function(e,c) return not c:IsLinkMonster() end)
 	c:RegisterEffect(e2)
 end
 s.listed_series={SET_CRUSADIA,SET_WORLD_LEGACY}
-function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
+function s.spcostfilter(c,e,tp)
+	return c:IsSetCard({SET_CRUSADIA,SET_WORLD_LEGACY}) and Duel.GetMZoneCount(tp,c)>0
+		and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_DECK|LOCATION_GRAVE,0,1,nil,e,tp,c:GetOriginalCodeRule())
+end
+function s.spfilter(c,e,tp,code)
+	return c:IsSetCard({SET_CRUSADIA,SET_WORLD_LEGACY}) and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
+		and not c:IsOriginalCodeRule(code)
+end
+function s.cost(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then return true end
-	if s.spcost(e,tp,eg,ep,ev,re,r,rp,0) and s.sptarget(e,tp,eg,ep,ev,re,r,rp,0)
-		and Duel.SelectYesNo(tp,aux.Stringid(id,0)) then
-		e:SetCategory(CATEGORY_SPECIAL_SUMMON)
-		s.spcost(e,tp,eg,ep,ev,re,r,rp,1)
-		s.sptarget(e,tp,eg,ep,ev,re,r,rp,1)
-		e:SetOperation(s.spoperation)
+	if Duel.CheckReleaseGroupCost(tp,s.spcostfilter,1,false,nil,nil,e,tp)
+		and Duel.SelectYesNo(tp,aux.Stringid(id,1)) then
+		local sc=Duel.SelectReleaseGroupCost(tp,s.spcostfilter,1,1,false,nil,nil,e,tp):GetFirst()
+		e:SetLabel(sc:GetOriginalCodeRule())
+		Duel.Release(sc,REASON_COST)
 	else
-		e:SetCategory(0)
-		e:SetOperation(nil)
+		e:SetLabel(-1)
 	end
 end
-function s.spcost(e,tp,eg,ep,ev,re,r,rp,chk)
-	e:SetLabel(1)
+function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
 	if chk==0 then return true end
-end
-function s.costfilter(c,e,tp)
-	return c:IsMonster() and (c:IsSetCard(SET_CRUSADIA) or c:IsSetCard(SET_WORLD_LEGACY))
-		and Duel.IsExistingMatchingCard(s.spfilter,tp,LOCATION_DECK|LOCATION_GRAVE,0,1,nil,e,tp,c)
-end
-function s.spfilter(c,e,tp,tc)
-	return c:IsMonster() and (c:IsSetCard(SET_CRUSADIA) or c:IsSetCard(SET_WORLD_LEGACY)) and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
-		and not c:IsOriginalCode(tc:GetOriginalCode())
-end
-function s.sptarget(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then
-		if e:GetLabel()~=1 then return false end
-		e:SetLabel(0)
-		return Duel.GetLocationCount(tp,LOCATION_MZONE)>-1
-			and Duel.CheckReleaseGroupCost(tp,s.costfilter,1,false,nil,nil,e,tp)
+	if e:GetLabel()>0 then
+		e:SetCategory(CATEGORY_SPECIAL_SUMMON)
+		Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_DECK|LOCATION_GRAVE)
+	else
+		e:SetCategory(0)
 	end
-	e:SetLabel(0)
-	local g=Duel.SelectReleaseGroupCost(tp,s.costfilter,1,1,false,nil,nil,e,tp)
-	Duel.Release(g,REASON_COST)
-	Duel.SetTargetCard(g)
-	Duel.SetOperationInfo(0,CATEGORY_SPECIAL_SUMMON,nil,1,tp,LOCATION_DECK)
 end
-function s.spoperation(e,tp,eg,ep,ev,re,r,rp)
-	if Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return end
-	local c=e:GetHandler()
-	local tc=Duel.GetFirstTarget()
+function s.activate(e,tp,eg,ep,ev,re,r,rp)
+	local label=e:GetLabel()
+	if label==-1 or Duel.GetLocationCount(tp,LOCATION_MZONE)<=0 then return end
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-	local g=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_DECK|LOCATION_GRAVE,0,1,1,nil,e,tp,tc)
+	local g=Duel.SelectMatchingCard(tp,aux.NecroValleyFilter(s.spfilter),tp,LOCATION_DECK|LOCATION_GRAVE,0,1,1,nil,e,tp,label)
 	if #g>0 then
 		Duel.SpecialSummon(g,0,tp,tp,false,false,POS_FACEUP)
 	end
-end
-function s.catfilter(c)
-	return c:IsFaceup() and c:IsSetCard(SET_CRUSADIA) and c:IsLinkMonster()
-end
-function s.catcondition(e)
-	return Duel.IsExistingMatchingCard(s.catfilter,e:GetHandlerPlayer(),LOCATION_MZONE,0,1,nil)
-end
-function s.catlimit(e,c)
-	return not c:IsLinkMonster()
 end

official/c57499304.lua

@@ -5,59 +5,58 @@ local s,id=GetID()
 function s.initial_effect(c)
 	--Activate
 	local e1=Effect.CreateEffect(c)
-	e1:SetCategory(CATEGORY_REMOVE+CATEGORY_SPECIAL_SUMMON)
+	e1:SetDescription(aux.Stringid(id,0))
+	e1:SetCategory(CATEGORY_REMOVE+CATEGORY_SPECIAL_SUMMON+CATEGORY_DAMAGE)
 	e1:SetType(EFFECT_TYPE_ACTIVATE)
 	e1:SetCode(EVENT_PRE_DAMAGE_CALCULATE)
 	e1:SetCondition(s.condition)
 	e1:SetTarget(s.target)
-	e1:SetOperation(s.operation)
+	e1:SetOperation(s.activate)
 	c:RegisterEffect(e1)
 end
 s.listed_series={SET_NUMBER}
-function s.cfilter(c)
+function s.confilter(c)
 	if not c:IsType(TYPE_XYZ) then return false end
 	local no=c.xyz_number
 	return (c:IsSetCard(SET_NUMBER) and no and no>=101 and no<=107)
-		or c:GetOverlayGroup():IsExists(s.cfilter,1,nil)
+		or c:GetOverlayGroup():IsExists(s.confilter,1,nil)
 end
 function s.condition(e,tp,eg,ep,ev,re,r,rp)
-	local tc=Duel.GetBattleMonster(tp)
-	return tc and s.cfilter(tc)
+	local bc=Duel.GetBattleMonster(tp)
+	return bc and s.confilter(bc)
 end
 function s.target(e,tp,eg,ep,ev,re,r,rp,chk)
-	local tc=Duel.GetBattleMonster(tp)
-	local g=tc:GetOverlayGroup()
-	if chk==0 then return tc:IsAbleToRemove() and (#g==0 or #g==g:FilterCount(Card.IsAbleToRemove,nil)) end
-	Duel.SetTargetCard(tc)
-	g:AddCard(tc)
-	Duel.SetOperationInfo(0,CATEGORY_REMOVE,g,#g,0,0)
+	local bc=Duel.GetBattleMonster(tp)
+	local g=bc:GetOverlayGroup()
+	if chk==0 then return bc:IsAbleToRemove() and (#g==0 or #g==g:FilterCount(Card.IsAbleToRemove,nil)) end
+	e:SetLabelObject(bc)
+	bc:CreateEffectRelation(e)
+	Duel.SetOperationInfo(0,CATEGORY_REMOVE,g+bc,#g,tp,0)
 end
-function s.operation(e,tp,eg,ep,ev,re,r,rp)
-	local tc=Duel.GetFirstTarget()
-	if tc and tc:IsRelateToEffect(e) and tc:IsControler(tp) then
-		local g=tc:GetOverlayGroup()
-		g:AddCard(tc)
-		Duel.Remove(g,POS_FACEUP,REASON_EFFECT)
+function s.activate(e,tp,eg,ep,ev,re,r,rp)
+	local bc=e:GetLabelObject()
+	if bc:IsRelateToEffect(e) and bc:IsControler(tp) then
+		Duel.Remove(bc+bc:GetOverlayGroup(),POS_FACEUP,REASON_EFFECT)
 	end
 	if not e:IsHasType(EFFECT_TYPE_ACTIVATE) then return end
-	--Special Summon 1 Rank 3 or lower Xyz during the End Phase
+	--During the End Phase of the turn you activated this card, Special Summon 1 Rank 3 or lower Xyz Monser from your Extra Deck, and if you do, inflict damage to your opponent equal to its original ATK
 	local e1=Effect.CreateEffect(e:GetHandler())
 	e1:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
 	e1:SetCode(EVENT_PHASE+PHASE_END)
 	e1:SetCountLimit(1)
-	e1:SetOperation(s.op)
+	e1:SetOperation(s.spop)
 	e1:SetReset(RESET_PHASE|PHASE_END)
 	Duel.RegisterEffect(e1,tp)
 end
 function s.spfilter(c,e,tp)
-	return c:IsRankBelow(3) and not c:IsSetCard(SET_NUMBER) and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
+	return c:IsRankBelow(3) and c:IsType(TYPE_XYZ) and not c:IsSetCard(SET_NUMBER) and c:IsCanBeSpecialSummoned(e,0,tp,false,false)
 		and Duel.GetLocationCountFromEx(tp,tp,nil,c)>0
 end
-function s.op(e,tp,eg,ep,ev,re,r,rp)
+function s.spop(e,tp,eg,ep,ev,re,r,rp)
 	Duel.Hint(HINT_CARD,0,id)
 	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_SPSUMMON)
-	local tc=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp):GetFirst()
-	if tc and Duel.SpecialSummon(tc,0,tp,tp,false,false,POS_FACEUP)>0 then
-		Duel.Damage(1-tp,tc:GetBaseAttack(),REASON_EFFECT)
+	local sc=Duel.SelectMatchingCard(tp,s.spfilter,tp,LOCATION_EXTRA,0,1,1,nil,e,tp):GetFirst()
+	if sc and Duel.SpecialSummon(sc,0,tp,tp,false,false,POS_FACEUP)>0 then
+		Duel.Damage(1-tp,sc:GetBaseAttack(),REASON_EFFECT)
 	end
 end