fix(web): silence vite web build warnings

Author: skulidropek

.github/workflows/final-build.yml

@@ -32,7 +32,7 @@ jobs:
         run: bun ./packages/docker-git-session-sync/dist/docker-git-session-sync.js --help
       - name: Verify browser UI and menu clone smoke checks
         run: |
-          bun run --cwd packages/app build:web
+          bun run --cwd packages/app build:web:strict
           bun scripts/final-build/browser-web-smoke.mjs
           bun run --cwd packages/app vitest run tests/docker-git/browser-frontend.test.ts tests/docker-git/app-ready-create.test.ts tests/docker-git/actions-project-create.test.ts
       - name: Prepare package artifacts directory

packages/app/package.json

@@ -17,6 +17,7 @@
     "build": "bun run build:app && bun run build:docker-git",
     "build:app": "vite build --ssr src/app/main.ts",
     "build:web": "vite build --config vite.web.config.ts",
+    "build:web:strict": "bun ../../scripts/ci/check-web-build-output.mjs",
     "prepack": "bun run build:docker-git",
     "dev": "vite build --watch --ssr src/app/main.ts",
     "dev:web": "vite --config vite.web.config.ts",

packages/app/vite.web.config.ts

@@ -5,7 +5,7 @@ import { fileURLToPath } from "node:url"
 
 import { gridlandWebPlugin } from "@gridland/web/vite-plugin"
 import react from "@vitejs/plugin-react"
-import { defineConfig, loadEnv, type PluginOption } from "vite"
+import { defineConfig, loadEnv, type Plugin, type PluginOption, type UserConfig } from "vite"
 import { type RawData, WebSocket, WebSocketServer } from "ws"
 
 const __filename = fileURLToPath(import.meta.url)
@@ -165,14 +165,65 @@ const terminalWebSocketProxyPlugin = (apiTarget: string): PluginOption => ({
   }
 })
 
+type VitePluginConfig = Omit<UserConfig, "plugins">
+
+const removeDeprecatedOptimizeDepsOptions = (
+  optimizeDeps: UserConfig["optimizeDeps"]
+): UserConfig["optimizeDeps"] => {
+  if (optimizeDeps === undefined) {
+    return undefined
+  }
+
+  const { esbuildOptions: _esbuildOptions, ...remainingOptions } = optimizeDeps
+  return remainingOptions
+}
+
+const removeDeprecatedGridlandOptions = (
+  config: VitePluginConfig | null | void
+): VitePluginConfig | null | void => {
+  if (config === undefined || config === null) {
+    return config
+  }
+
+  const { esbuild: _esbuild, optimizeDeps, ...remainingConfig } = config
+  const sanitizedOptimizeDeps = removeDeprecatedOptimizeDepsOptions(optimizeDeps)
+  return sanitizedOptimizeDeps === undefined
+    ? remainingConfig
+    : {
+      ...remainingConfig,
+      optimizeDeps: sanitizedOptimizeDeps
+    }
+}
+
+const isVitePlugin = (plugin: PluginOption): plugin is Plugin =>
+  typeof plugin === "object" && plugin !== null && !Array.isArray(plugin) && "name" in plugin
+
+const gridlandWebPluginWithoutDeprecatedOptions = (): ReadonlyArray<PluginOption> =>
+  gridlandWebPlugin().map((plugin) => {
+    if (!isVitePlugin(plugin) || plugin.name !== "gridland-web-aliases" || typeof plugin.config !== "function") {
+      return plugin
+    }
+
+    const resolveGridlandConfig = plugin.config
+    return {
+      ...plugin,
+      config(config, env) {
+        const result = resolveGridlandConfig.call(this, config, env)
+        return result instanceof Promise
+          ? result.then(removeDeprecatedGridlandOptions)
+          : removeDeprecatedGridlandOptions(result)
+      }
+    }
+  })
+
 export default defineConfig(({ mode }) => {
   const env = loadEnv(mode, __dirname, "")
   const apiTarget = env["DOCKER_GIT_API_URL"]?.trim() || defaultApiTarget
 
   return {
     plugins: [
       terminalWebSocketProxyPlugin(apiTarget),
-      ...gridlandWebPlugin(),
+      ...gridlandWebPluginWithoutDeprecatedOptions(),
       react()
     ],
     publicDir: false,
@@ -211,14 +262,12 @@ export default defineConfig(({ mode }) => {
     build: {
       target: "esnext",
       outDir: "dist-web",
-      sourcemap: true
-    },
-    esbuild: {
-      target: "esnext"
-    },
-    optimizeDeps: {
-      esbuildOptions: {
-        target: "esnext"
+      sourcemap: true,
+      chunkSizeWarningLimit: 1200,
+      rolldownOptions: {
+        checks: {
+          invalidAnnotation: false
+        }
       }
     }
   }

scripts/ci/check-web-build-output.mjs

@@ -0,0 +1,50 @@
+import { spawnSync } from "node:child_process"
+import { fileURLToPath } from "node:url"
+
+const repoRoot = fileURLToPath(new URL("../..", import.meta.url))
+const runtime = process.versions.bun === undefined ? "bun" : process.execPath
+const forbiddenOutput = [
+  {
+    label: "Vite warning",
+    pattern: /\[vite\]\s+warning:/iu
+  },
+  {
+    label: "Rolldown invalid annotation warning",
+    pattern: /\[INVALID_ANNOTATION\]/u
+  },
+  {
+    label: "Deprecated build option warning",
+    pattern: /\bdeprecated\b/iu
+  },
+  {
+    label: "Chunk size warning",
+    pattern: /Some chunks are larger than/u
+  }
+]
+
+const result = spawnSync(runtime, ["run", "--cwd", "packages/app", "build:web"], {
+  cwd: repoRoot,
+  encoding: "utf8"
+})
+
+process.stdout.write(result.stdout)
+process.stderr.write(result.stderr)
+
+if (result.error !== undefined) {
+  console.error(result.error)
+  process.exit(1)
+}
+
+if (result.status !== 0) {
+  process.exit(result.status ?? 1)
+}
+
+const output = `${result.stdout}\n${result.stderr}`
+const matches = forbiddenOutput.filter(({ pattern }) => pattern.test(output))
+if (matches.length > 0) {
+  console.error("Web build emitted forbidden warning output:")
+  for (const match of matches) {
+    console.error(`- ${match.label}`)
+  }
+  process.exit(1)
+}