fix(browser): restore Rust lifecycle guarantees

Author: skulidropek

packages/app/src/lib/core/templates-entrypoint/tasks.ts

@@ -315,5 +315,27 @@ export const renderEntrypointRustBrowserConnection = (): string =>
     "  echo \"[browser] Rust browser connection is ready via $browser_bin on $network_mode\"",
     "}",
     "",
+    "docker_git_stop_playwright_browser() {",
+    "  if [[ \"${MCP_PLAYWRIGHT_ENABLE:-0}\" != \"1\" ]]; then",
+    "    return 0",
+    "  fi",
+    "",
+    "  local browser_bin=\"\"",
+    "  local candidate",
+    "  for candidate in /usr/local/bin/docker-git-browser-connection /root/.cargo/bin/docker-git-browser-connection /usr/local/cargo/bin/docker-git-browser-connection $(command -v docker-git-browser-connection 2>/dev/null || true); do",
+    "    if [[ -x \"$candidate\" ]]; then",
+    "      browser_bin=\"$candidate\"",
+    "      break",
+    "    fi",
+    "  done",
+    "",
+    "  if [[ -z \"$browser_bin\" ]]; then",
+    "    return 0",
+    "  fi",
+    "",
+    "  local project_container=\"${DOCKER_GIT_PROJECT_CONTAINER_NAME:-$(hostname)}\"",
+    "  \"$browser_bin\" stop --project \"$project_container\" >> /var/log/docker-git-browser.log 2>&1 || true",
+    "}",
+    "",
     "docker_git_start_rust_browser_connection"
   ].join("\n")

packages/app/src/lib/core/templates/dockerfile-prelude.ts

@@ -75,7 +75,7 @@ RUN set -eu; \
 
 # Install unified Rust browser connection (noVNC + CDP + single dg-*-browser guarantee)
 # Replaces all previous TS/MCP browser-connection duplication (per issue #347)
-RUN cargo install --git https://github.com/ProverCoderAI/rust-browser-connection --rev c36f263ebc5d0acdf155113914f08cafefa69c56 --locked --bins --root /usr/local \
+RUN cargo install --git https://github.com/ProverCoderAI/rust-browser-connection --rev b69fa095da54a97c440738abd56e3abf3344ab70 --locked --bins --root /usr/local \
   && /usr/local/bin/docker-git-browser-connection --version \
   && /usr/local/bin/browser-connection --version
 

packages/app/tests/docker-git/core-templates.test.ts

@@ -67,7 +67,9 @@ describe("app planFiles", () => {
     expect(dockerfile.contents).toContain("/usr/local/bin/browser-connection --version")
     expect(dockerfile.contents).not.toContain("docker-git-playwright-mcp")
     expect(entrypoint.contents).toContain("docker_git_start_rust_browser_connection")
+    expect(entrypoint.contents).toContain("docker_git_stop_playwright_browser()")
     expect(entrypoint.contents).toContain("docker-git-browser-connection")
     expect(entrypoint.contents).toContain("local network_mode=\"container:${project_container}\"")
+    expect(entrypoint.contents).toContain("stop --project \"$project_container\"")
   })
 })

packages/lib/src/core/templates-entrypoint/tasks.ts

@@ -315,5 +315,27 @@ export const renderEntrypointRustBrowserConnection = (): string =>
     "  echo \"[browser] Rust browser connection is ready via $browser_bin on $network_mode\"",
     "}",
     "",
+    "docker_git_stop_playwright_browser() {",
+    "  if [[ \"${MCP_PLAYWRIGHT_ENABLE:-0}\" != \"1\" ]]; then",
+    "    return 0",
+    "  fi",
+    "",
+    "  local browser_bin=\"\"",
+    "  local candidate",
+    "  for candidate in /usr/local/bin/docker-git-browser-connection /root/.cargo/bin/docker-git-browser-connection /usr/local/cargo/bin/docker-git-browser-connection $(command -v docker-git-browser-connection 2>/dev/null || true); do",
+    "    if [[ -x \"$candidate\" ]]; then",
+    "      browser_bin=\"$candidate\"",
+    "      break",
+    "    fi",
+    "  done",
+    "",
+    "  if [[ -z \"$browser_bin\" ]]; then",
+    "    return 0",
+    "  fi",
+    "",
+    "  local project_container=\"${DOCKER_GIT_PROJECT_CONTAINER_NAME:-$(hostname)}\"",
+    "  \"$browser_bin\" stop --project \"$project_container\" >> /var/log/docker-git-browser.log 2>&1 || true",
+    "}",
+    "",
     "docker_git_start_rust_browser_connection"
   ].join("\n")

packages/lib/src/core/templates/dockerfile-prelude.ts

@@ -75,7 +75,7 @@ RUN set -eu; \
 
 # Install unified Rust browser connection (noVNC + CDP + single dg-*-browser guarantee)
 # Replaces all previous TS/MCP browser-connection duplication (per issue #347)
-RUN cargo install --git https://github.com/ProverCoderAI/rust-browser-connection --rev c36f263ebc5d0acdf155113914f08cafefa69c56 --locked --bins --root /usr/local \
+RUN cargo install --git https://github.com/ProverCoderAI/rust-browser-connection --rev b69fa095da54a97c440738abd56e3abf3344ab70 --locked --bins --root /usr/local \
   && /usr/local/bin/docker-git-browser-connection --version \
   && /usr/local/bin/browser-connection --version
 

packages/lib/tests/core/templates.test.ts

@@ -234,7 +234,7 @@ describe("renderDockerfile", () => {
     const dockerfile = renderDockerfile(makeTemplateConfig({ enableMcpPlaywright: true }))
 
     expectContainsAll(dockerfile, [
-      "cargo install --git https://github.com/ProverCoderAI/rust-browser-connection --rev c36f263ebc5d0acdf155113914f08cafefa69c56 --locked --bins --root /usr/local",
+      "cargo install --git https://github.com/ProverCoderAI/rust-browser-connection --rev b69fa095da54a97c440738abd56e3abf3344ab70 --locked --bins --root /usr/local",
       "/usr/local/bin/docker-git-browser-connection --version",
       "/usr/local/bin/browser-connection --version",
       "# Unified Rust browser (dg-*-browser) is started by docker-git-browser-connection binary"
@@ -764,8 +764,10 @@ describe("renderDockerCompose", () => {
     expect(dockerfile?.contents).not.toContain("docker-git-playwright-mcp")
     expect(dockerfile?.contents).not.toContain("COPY Dockerfile.browser")
     expect(entrypoint?.contents).toContain("docker_git_start_rust_browser_connection")
+    expect(entrypoint?.contents).toContain("docker_git_stop_playwright_browser()")
     expect(entrypoint?.contents).toContain("docker-git-browser-connection")
     expect(entrypoint?.contents).toContain('local network_mode="container:${project_container}"')
+    expect(entrypoint?.contents).toContain('stop --project "$project_container"')
   })
   it("renders Rust browser startup before MCP client config", () => {
     const entrypoint = renderEntrypoint(makeTemplateConfig({ enableMcpPlaywright: true }))

packages/lib/tests/usecases/mcp-playwright.test.ts

@@ -136,7 +136,9 @@ describe("enableMcpPlaywrightProjectFiles", () => {
 
         const entrypointAfter = yield* _(fs.readFileString(path.join(outDir, "entrypoint.sh")))
         expect(entrypointAfter).toContain("docker_git_start_rust_browser_connection")
+        expect(entrypointAfter).toContain("docker_git_stop_playwright_browser()")
         expect(entrypointAfter).toContain("docker-git-browser-connection")
+        expect(entrypointAfter).toContain('stop --project "$project_container"')
         expect(entrypointAfter).toContain('command = "browser-connection"')
         expect(entrypointAfter).toContain('args = ["--project", "$DOCKER_GIT_BROWSER_PROJECT", "--network", "$DOCKER_GIT_BROWSER_NETWORK"]')