test(lint): dedupe no-lib-imports analyzer cases

Author: skulidropek

packages/app/tests/eslint/no-lib-imports.test.ts

@@ -4,6 +4,8 @@ import tseslint from "typescript-eslint"
 
 import { noLibImportsRule } from "../../eslint/no-lib-imports.mjs"
 
+const defaultFilePath = "src/new-client.ts"
+
 const verify = (source: string, filePath: string) => {
   const linter = new Linter({ configType: "flat" })
 
@@ -29,105 +31,66 @@ const verify = (source: string, filePath: string) => {
   )
 }
 
-describe("noLibImportsRule", () => {
-  it("rejects import declarations from lib", () => {
-    const messages = verify(
-      "import { listProjects } from \"@effect-template/lib\"\n",
-      "src/new-client.ts"
-    )
+const line = (source: string): string => `${source}\n`
 
-    expect(messages).toHaveLength(1)
-    expect(messages[0]?.message).toContain("Direct import")
-    expect(messages[0]?.message).toContain("@effect-template/lib")
-  })
+const lines = (source: ReadonlyArray<string>): string => source.join("\n")
 
-  it("rejects type-only import declarations from lib", () => {
-    const messages = verify(
-      "import type { TemplateConfig } from \"@effect-template/lib/core/domain\"\n",
-      "src/new-client.ts"
-    )
-
-    expect(messages).toHaveLength(1)
-    expect(messages[0]?.message).toContain("@effect-template/lib/core/domain")
-  })
+const expectMessages = (
+  source: string,
+  expectedMessages: ReadonlyArray<ReadonlyArray<string>>,
+  filePath: string = defaultFilePath
+) => {
+  const messages = verify(source, filePath)
 
-  it("rejects type import expressions from lib", () => {
-    const messages = verify(
-      "type Template = import(\"@effect-template/lib/core/domain\").TemplateConfig\n",
-      "src/new-client.ts"
-    )
-
-    expect(messages).toHaveLength(1)
-    expect(messages[0]?.message).toContain("@effect-template/lib/core/domain")
-  })
-
-  it("rejects require calls from lib", () => {
-    const messages = verify(
-      "const templateLib = require(\"@effect-template/lib\")\n",
-      "src/new-client.ts"
-    )
-
-    expect(messages).toHaveLength(1)
-    expect(messages[0]?.message).toContain("@effect-template/lib")
-  })
+  expect(messages).toHaveLength(expectedMessages.length)
+  for (const [index, expectedMessageParts] of expectedMessages.entries()) {
+    for (const expectedMessagePart of expectedMessageParts) {
+      expect(messages[index]?.message).toContain(expectedMessagePart)
+    }
+  }
+}
 
-  it("rejects template literal module calls from lib", () => {
-    const messages = verify(
-      [
+describe("noLibImportsRule", () => {
+  const violationCases = [
+    ["rejects import declarations from lib", line("import { listProjects } from \"@effect-template/lib\""), [["Direct import", "@effect-template/lib"]]],
+    ["rejects type-only import declarations from lib", line("import type { TemplateConfig } from \"@effect-template/lib/core/domain\""), [["@effect-template/lib/core/domain"]]],
+    ["rejects type import expressions from lib", line("type Template = import(\"@effect-template/lib/core/domain\").TemplateConfig"), [["@effect-template/lib/core/domain"]]],
+    ["rejects require calls from lib", line("const templateLib = require(\"@effect-template/lib\")"), [["@effect-template/lib"]]],
+    [
+      "rejects template literal module calls from lib",
+      lines([
         "const requiredTemplateLib = require(`@effect-template/lib/core/domain`)",
         "const importedTemplateLib = await import(`@effect-template/lib/usecases/projects`)"
-      ].join("\n"),
-      "src/new-client.ts"
-    )
-
-    expect(messages).toHaveLength(2)
-    expect(messages[0]?.message).toContain("@effect-template/lib/core/domain")
-    expect(messages[1]?.message).toContain("@effect-template/lib/usecases/projects")
-  })
-
-  it("rejects import equals require from lib", () => {
-    const messages = verify(
-      "import templateLib = require(\"@effect-template/lib/core/domain\")\n",
-      "src/new-client.ts"
-    )
-
-    expect(messages).toHaveLength(1)
-    expect(messages[0]?.message).toContain("@effect-template/lib/core/domain")
-  })
-
-  it("rejects re-export declarations from lib", () => {
-    const messages = verify(
-      [
+      ]),
+      [["@effect-template/lib/core/domain"], ["@effect-template/lib/usecases/projects"]]
+    ],
+    ["rejects import equals require from lib", line("import templateLib = require(\"@effect-template/lib/core/domain\")"), [["@effect-template/lib/core/domain"]]],
+    [
+      "rejects re-export declarations from lib",
+      lines([
         "export { listProjects } from \"@effect-template/lib\"",
         "export * from \"@effect-template/lib/core/domain\""
-      ].join("\n"),
-      "src/new-client.ts"
-    )
+      ]),
+      [["@effect-template/lib"], ["@effect-template/lib/core/domain"]]
+    ],
+    ["rejects migrated legacy paths too", line("import { listProjects } from \"@effect-template/lib\""), [["Direct import"]], "src/docker-git/program.ts"]
+  ] as const
 
-    expect(messages).toHaveLength(2)
-    expect(messages[0]?.message).toContain("@effect-template/lib")
-    expect(messages[1]?.message).toContain("@effect-template/lib/core/domain")
-  })
+  for (const [name, source, expectedMessages, filePath] of violationCases) {
+    it(name, () => {
+      expectMessages(source, expectedMessages, filePath)
+    })
+  }
 
   it("allows non-lib imports", () => {
     const messages = verify(
-      [
+      lines([
         "import { request } from \"./api-client.js\"",
         "import type { Command } from \"@lib/core/domain\""
-      ].join("\n"),
-      "src/new-client.ts"
+      ]),
+      defaultFilePath
     )
 
     expect(messages).toHaveLength(0)
   })
-
-  it("rejects migrated legacy paths too", () => {
-    const messages = verify(
-      "import { listProjects } from \"@effect-template/lib\"\n",
-      "src/docker-git/program.ts"
-    )
-
-    expect(messages).toHaveLength(1)
-    expect(messages[0]?.message).toContain("Direct import")
-  })
 })