fix(lint): satisfy effect and unicorn rules for docker port fallback

Author: skulidropek

packages/lib/src/shell/docker.ts

@@ -451,7 +451,7 @@ const parsePublishedHostPortsFromLine = (line: string): ReadonlyArray<number> =>
       continue
     }
     const value = Number.parseInt(rawPort, 10)
-    if (Number.isInteger(value) && value > 0 && value <= 65535) {
+    if (Number.isInteger(value) && value > 0 && value <= 65_535) {
       parsed.push(value)
     }
   }
@@ -511,5 +511,5 @@ export const runDockerPsPublishedHostPorts = (
       [Number(ExitCode(0))],
       (exitCode) => new CommandFailedError({ command: "docker ps", exitCode })
     ),
-    Effect.map(parseDockerPublishedHostPorts)
+    Effect.map((output) => parseDockerPublishedHostPorts(output))
   )

packages/lib/src/usecases/ports-reserve.ts

@@ -2,7 +2,7 @@ import type * as CommandExecutor from "@effect/platform/CommandExecutor"
 import type { PlatformError } from "@effect/platform/Error"
 import type { FileSystem } from "@effect/platform/FileSystem"
 import * as Path from "@effect/platform/Path"
-import { Effect, Option } from "effect"
+import { Effect, Either, Option } from "effect"
 
 import { runDockerPsPublishedHostPorts } from "../shell/docker.js"
 import { PortProbeError } from "../shell/errors.js"
@@ -47,14 +47,17 @@ const reservePort = (
 }
 
 const loadPublishedDockerPorts = (): Effect.Effect<ReadonlySet<number>, never, CommandExecutor.CommandExecutor> =>
-  runDockerPsPublishedHostPorts(process.cwd()).pipe(
-    Effect.map((ports) => new Set(ports)),
-    Effect.catchAll((error) =>
-      Effect.logWarning(
-        `Failed to read published Docker ports; falling back to TCP probing only: ${
-          error instanceof Error ? error.message : String(error)
-        }`
-      ).pipe(Effect.as(new Set<number>()))
+  Effect.either(runDockerPsPublishedHostPorts(process.cwd())).pipe(
+    Effect.flatMap(
+      Either.match({
+        onLeft: (error) =>
+          Effect.logWarning(
+            `Failed to read published Docker ports; falling back to TCP probing only: ${
+              error instanceof Error ? error.message : String(error)
+            }`
+          ).pipe(Effect.as(new Set<number>())),
+        onRight: (ports) => Effect.succeed(new Set(ports))
+      })
     )
   )