Address Copilot review feedback for PR 1

dotenv.h:
- Clarify inline variable syntax with explanatory comment
- Add comment explaining why _instance cannot be inline inside class

dotenv.cpp:
- Rename Dotenv_Type to DotenvClass for better C++ conventions
- Fix operator[] to use typedef alias consistently (avoid parsing issues)
- Improve comment clarity for the global env variable definition

CMakeLists.txt:
- Add MSVC support for compiler flags (/W4 /Od /O2)
- Improve Windows library naming: use distinct OUTPUT_NAME on MSVC
  to avoid conflicts between static and shared library .lib files

common/libs/antlr4-cpp-runtime/CMakeLists.txt:
- Update cmake_minimum_required from 3.10 to 3.16 for consistency

Author: renecannao

CMakeLists.txt

@@ -42,11 +42,21 @@ set(CPP_DOTENV_SRC
 # Common include directories
 set(CPP_DOTENV_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/include)
 
-# Common compile options
-if ("${CMAKE_BUILD_TYPE}" STREQUAL "DEBUG")
-    set(CPP_DOTENV_COMPILE_OPTIONS -g -Wall -O0)
+# Common compile options - handle MSVC vs GCC/Clang
+if (MSVC)
+    # MSVC-specific flags
+    if ("${CMAKE_BUILD_TYPE}" STREQUAL "DEBUG")
+        set(CPP_DOTENV_COMPILE_OPTIONS /W4 /Od)
+    else()
+        set(CPP_DOTENV_COMPILE_OPTIONS /W4 /O2)
+    endif()
 else()
-    set(CPP_DOTENV_COMPILE_OPTIONS -O3)
+    # GCC/Clang and other compilers using Unix-style flags
+    if ("${CMAKE_BUILD_TYPE}" STREQUAL "DEBUG")
+        set(CPP_DOTENV_COMPILE_OPTIONS -g -Wall -O0)
+    else()
+        set(CPP_DOTENV_COMPILE_OPTIONS -O3)
+    endif()
 endif()
 
 # Build both static and shared libraries if requested
@@ -70,12 +80,14 @@ if(BUILD_BOTH_LIBRARIES)
     )
     target_include_directories(cpp_dotenv_shared PUBLIC ${CPP_DOTENV_INCLUDE_DIRS})
     target_compile_options(cpp_dotenv_shared PRIVATE ${CPP_DOTENV_COMPILE_OPTIONS})
-    # Set output name to libcpp_dotenv.so/.dylib (instead of libcpp_dotenv_shared.so)
-    set_target_properties(cpp_dotenv_shared PROPERTIES OUTPUT_NAME cpp_dotenv)
-    # On Windows (MSVC), the import library would conflict with the static library.
-    # Add a suffix to the import library name to avoid this conflict.
+    # Set output name. On non-MSVC platforms, both static and shared libraries use
+    # the same base name "cpp_dotenv". On MSVC, give the shared library a distinct
+    # base name to avoid conflicts between the static library (.lib) and the
+    # import library for the shared library (also .lib).
     if(MSVC)
-        set_target_properties(cpp_dotenv_shared PROPERTIES IMPORT_SUFFIX "_shared.lib")
+        set_target_properties(cpp_dotenv_shared PROPERTIES OUTPUT_NAME cpp_dotenv_shared)
+    else()
+        set_target_properties(cpp_dotenv_shared PROPERTIES OUTPUT_NAME cpp_dotenv)
     endif()
 
     # Alias for backward compatibility:

common/libs/antlr4-cpp-runtime/CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.16)
 project(antlr4-cpp-runtime VERSION 4.8)
 
 set(CMAKE_CXX_STANDARD 17)

include/dotenv.h

@@ -35,15 +35,18 @@ namespace dotenv
 
     private:
 
+        // Declare static members (definitions are inline after the class)
         static const std::string env_filename;
         static dotenv _instance;
 
     };
 
 
-    extern dotenv& env;
-
-    // Inline variables defined after class is complete (C++17)
+    // C++17 inline variable definitions after class is complete
+    // Note: _instance cannot be inline inside the class due to incomplete type
     inline const std::string dotenv::env_filename = ".env";
     inline dotenv dotenv::_instance;
+
+
+    extern dotenv& env;
 }

src/dotenv.cpp

@@ -10,12 +10,12 @@
 using namespace std;
 
 
-// Typedef to work around the fact that class name matches namespace name
+// Type alias to work around the fact that class name matches namespace name
 // This is a known C++ limitation when defining out-of-line members
-typedef class ::dotenv::dotenv Dotenv_Type;
+typedef class ::dotenv::dotenv DotenvClass;
 
 
-Dotenv_Type& ::dotenv::dotenv::load_dotenv(const string& dotenv_path, const bool overwrite, const bool interpolate)
+DotenvClass& ::dotenv::dotenv::load_dotenv(const string& dotenv_path, const bool overwrite, const bool interpolate)
 {
     ifstream env_file;
     env_file.open(dotenv_path);
@@ -31,17 +31,17 @@ Dotenv_Type& ::dotenv::dotenv::load_dotenv(const string& dotenv_path, const bool
 }
 
 
-auto ::dotenv::dotenv::operator[](const key_type& k) const -> const string
+const string DotenvClass::operator[](const key_type& k) const
 {
     return getenv(k).second;
 }
 
 
-Dotenv_Type& ::dotenv::dotenv::instance()
+DotenvClass& ::dotenv::dotenv::instance()
 {
     return _instance;
 }
 
 
-// Static members are now inline in the header (C++17)
+// Define the global 'env' reference. Static members are inline in the header (C++17).
 ::dotenv::dotenv& ::dotenv::env = ::dotenv::dotenv::instance();