-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
there's no bound for the char D which will print out bound Level
Describe the solution you'd like
A clear and concise description of what you want to happen.
Add bounds check for character D to be in the bound characters for example from '0' to '6'
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Reference from GPAD_HAL.cpp
case Command::ALARM:
{
// In the case of an alarm state, the rest of the buffer is a message.
// we will read up to 60 characters from this buffer for display on our
// Arguably when we support mulitple states this will become more complicated.
char D = buf[1];
int N = D - '0';
serialport->println(N);
// WARNING: Shouldn't this be MAX_BUFFER_SIZE?
char msg[61];
msg[0] = '\0';
strncat(msg, buf, 60);
// This copy loooks uncessary, but is not...we want "alarm"
// to be a completely independent and abstract function.
// it should copy the msg buffer
serialport->print("The MQTT Alarm Message: ");
serialport->println(msg);
alarm((AlarmLevel)N, msg, serialport); // Makes Lamps indicate alarm.
break;
}
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels