Implement legacy material conversion#15
Merged
BjornTheProgrammer merged 3 commits intoMar 3, 2026
Merged
Conversation
- Add three-tier legacy material lookup in PatchBukkitLegacy: data-value map, rename map, and direct name match covering all 462 LEGACY_* materials - Fix null player sender by creating PatchBukkitPlayer on-the-fly with op when Java-side getPlayer returns null - Add DynamicTestProvider interface and LEGACY_MATERIALS test category that validates every legacy material converts to non-AIR - Fix protobuf codegen naming collision with java_outer_classname - Clean up command_manager: extract get_or_init_command_map helper, remove debug logging and dead code
BjornTheProgrammer
approved these changes
Mar 2, 2026
Collaborator
BjornTheProgrammer
left a comment
BjornTheProgrammer
left a comment
There was a problem hiding this comment.
Looks great!
Collaborator
|
There is just a formatting error that needs to be fixed before merging. |
- Use Option::map instead of manual if-let-some in config callback - Remove unused itemstack re-export - Apply cargo fmt
Collaborator
|
Pumpkin-world is no longer needed |
Contributor
Author
|
Thanks Purdze, LGTM |
Contributor
Author
No problem |
Collaborator
Yeah looks good to me as well 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PatchBukkitLegacycovering all 462LEGACY_*materials (data-value map, rename map, direct name match)PatchBukkitPlayeron-the-fly with op when Java-sidegetPlayerreturns nullDynamicTestProviderinterface andLEGACY_MATERIALStest category that validates every legacy material converts to non-AIRjava_outer_classnamecommand_manager: extractget_or_init_command_maphelper, remove debug logging and dead codeCloses #10
Test plan
/pbtest LEGACY_MATERIALSpasses 462/462 legacy materials/pbtest allpasses all existing conformance tests