Implement BukkitScheduler and ServicesManager#20
Merged
Conversation
Contributor
Author
|
@BjornTheProgrammer i saw that you've merged the last pull so i mentioned you |
Collaborator
|
Not a problem to mention me! I'm not actively working on this right now anymore. Feel free to post in the discord and I'm sure someone will be able to. |
Member
|
LGTM. Thank you @Sqrilizz :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PatchBukkitServicesManager— a fully functionalServicesManagerbacked by aConcurrentHashMapwith priority-sorted providers;Server.getServicesManager()now returns a working instance instead of throwingUnsupportedOperationExceptionPatchBukkitScheduler— replace all stubbed methods with a realScheduledThreadPoolExecutor-backed implementation; all async scheduling methods (runTaskAsynchronously,runTaskLaterAsynchronously,runTaskTimerAsynchronously, etc.) are functional with tick-to-millisecond conversionPatchBukkitTask—BukkitTaskimplementation wiring task IDs to the scheduler for cancellation trackingPatchBukkitServervia instance fieldsSchedulerTestsandServicesManagerTeststo the conformance test plugin covering 11 new test casesTest plan
/pbtest schedulerpasses 6/6/pbtest services_managerpasses 5/5/pbtest allpasses 534/543 (9 pre-existing failures unrelated to this PR)