From 81eb7f13d0728e5f41b09a43a28daf98b9506ec0 Mon Sep 17 00:00:00 2001 From: Giovanni Torres Date: Sat, 21 Mar 2026 17:34:47 -0400 Subject: [PATCH] fix: expose SCHED_FAILED Closes #405 --- pyslurm/core/reservation.pyx | 4 ++-- tests/unit/test_reservation.py | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/pyslurm/core/reservation.pyx b/pyslurm/core/reservation.pyx index 261b1c5f..fa3099ad 100644 --- a/pyslurm/core/reservation.pyx +++ b/pyslurm/core/reservation.pyx @@ -513,8 +513,6 @@ cdef class Reservation: self.info.flags = flag.value self.umsg.flags = flag._get_flags_cleared() - # TODO: RESERVE_FLAG_SKIP ? - class ReservationFlags(SlurmFlag): """Flags for Reservations that can be set. @@ -534,6 +532,8 @@ class ReservationFlags(SlurmFlag): NO_JOB_HOLD_AFTER_END = slurm.RESERVE_FLAG_NO_HOLD_JOBS OVERLAP = slurm.RESERVE_FLAG_OVERLAP ALL_NODES = slurm.RESERVE_FLAG_ALL_NODES + SKIP = slurm.RESERVE_FLAG_SKIP + SCHED_FAILED = slurm.RESERVE_FLAG_SCHED_FAILED class ReservationReoccurrence(SlurmEnum): diff --git a/tests/unit/test_reservation.py b/tests/unit/test_reservation.py index ec6eafde..7d7f43ca 100644 --- a/tests/unit/test_reservation.py +++ b/tests/unit/test_reservation.py @@ -78,3 +78,13 @@ def test_create_instance(): assert resv.flags == ReservationFlags.FLEX | ReservationFlags.PURGE +def test_flags_sched_failed(): + combo = ( + ReservationFlags.SCHED_FAILED + | ReservationFlags.SPECIFIC_NODES + | ReservationFlags.IGNORE_RUNNING_JOBS + ) + decoded = ReservationFlags(combo.value) + assert ReservationFlags.SCHED_FAILED in decoded + +