Skip to content

Suggestion #8

@moffile

Description

@moffile

Not sure if you're interested in making any changes at this point, but on line 45 of Turntable.ino there is a hard-coded scale factor of "4.4". This hard-coded value seems to be scaling the number of steps-per-revolution based on the gear ratio of the turntable. This is important, especially if someone is trying to use this code on a turntable that is different from the original design, as not modifying this value correctly ruins the follow-on calculations for number of steps per revolution, and it might be hard for some users to debug why they can't get an exact 360deg revolution from the code. I suggest creating a const for this value and adding a comment to it so that users know to modify this value based on the gear ratio of the turntable they use.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions