Hi!
Tonight I sat down to read your code and try writing some unit tests. It was a definitely a fun evening but not particularly productive so far, as I had to deal with some cryptic errors that didn't seem to be directly connected to your code. I also noticed you test dist build rather than TypeScript files.
I wonder if testing the dist build was a deliberate choice of yours as I'm tempted to follow the approach to unit testing I use myself, i.e. add ts-jest and reconfigure unit tests to test source files directly rather than generated *.js files, thus eliminating errors caused by build dependencies. It makes coverage reports easier to read and seems to be a sane approach, but it's rather a big change and I'd like to read your opinion first.
Are you okay with changes I mentioned above?
Hi!
Tonight I sat down to read your code and try writing some unit tests. It was a definitely a fun evening but not particularly productive so far, as I had to deal with some cryptic errors that didn't seem to be directly connected to your code. I also noticed you test dist build rather than TypeScript files.
I wonder if testing the dist build was a deliberate choice of yours as I'm tempted to follow the approach to unit testing I use myself, i.e. add ts-jest and reconfigure unit tests to test source files directly rather than generated *.js files, thus eliminating errors caused by build dependencies. It makes coverage reports easier to read and seems to be a sane approach, but it's rather a big change and I'd like to read your opinion first.
Are you okay with changes I mentioned above?