Skip to content

Commit 1266dc4

Browse files
refactor: relax overlap requirements in qws dummy estimation [code:qws] [system:MiyabiG]
1 parent 38027f3 commit 1266dc4

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

scripts/estimation/packages/instrumented_app_sections_dummy.sh

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,6 @@ _bk_has_section_named() {
3131
' >/dev/null 2>&1
3232
}
3333

34-
_bk_has_overlap_members() {
35-
local breakdown_json="$1"
36-
local members_csv="$2"
37-
local members_json
38-
members_json=$(echo "$members_csv" | tr ',' '\n' | jq -R . | jq -s .)
39-
40-
echo "$breakdown_json" | jq -e --argjson members "$members_json" '
41-
(.overlaps // []) | any(.sections == $members)
42-
' >/dev/null 2>&1
43-
}
44-
4534
_bk_missing_section_packages() {
4635
local breakdown_json="$1"
4736

@@ -105,11 +94,7 @@ bk_estimation_package_check_applicability() {
10594
"allreduce"
10695
"write_result"
10796
)
108-
local required_overlaps=(
109-
"compute_hopping,halo_exchange"
110-
)
11197
local section_name
112-
local overlap_members
11398
local missing_metadata
11499

115100
if [[ -z "${est_fom:-}" ]]; then
@@ -126,12 +111,6 @@ bk_estimation_package_check_applicability() {
126111
fi
127112
done
128113

129-
for overlap_members in "${required_overlaps[@]}"; do
130-
if ! _bk_has_overlap_members "$est_input_fom_breakdown" "$overlap_members"; then
131-
missing_inputs+=("\"overlap:${overlap_members}\"")
132-
fi
133-
done
134-
135114
while IFS= read -r missing_metadata; do
136115
[[ -z "$missing_metadata" ]] && continue
137116
missing_inputs+=("\"${missing_metadata}\"")

0 commit comments

Comments
 (0)