example-simplified-code.js

// Example of simplified code following core principles
function processUserOrder(order) {
	// Guard clauses - reduce nesting
	if (!order) return null;
	if (!order.items || order.items.length === 0)
		return null;
	if (!order.user || !order.user.verified) return null;

	const subtotal = calculateOrderSubtotal(order.items);
	const discount = getUserDiscount(order.user);
	const total = subtotal - subtotal * discount;

	return total;
}

function calculateOrderSubtotal(items) {
	return items.reduce((total, item) => {
		return total + item.price * item.qty;
	}, 0);
}

function getUserDiscount(user) {
	// Avoid nested ternaries - use explicit conditions
	const PREMIUM_ANNUAL_DISCOUNT = 0.2;
	const PREMIUM_MEMBER_DISCOUNT = 0.15;
	const PREMIUM_DISCOUNT = 0.1;
	const STANDARD_DISCOUNT = 0.05;

	if (!user.premium) return STANDARD_DISCOUNT;
	if (user.annual) return PREMIUM_ANNUAL_DISCOUNT;
	if (user.member) return PREMIUM_MEMBER_DISCOUNT;

	return PREMIUM_DISCOUNT;
}

function getStatus(user) {
	// Clear naming and simplified logic
	const isActive = user.isActive && user.isVerified;
	return isActive ? "active" : "inactive";
}