From 57c93bb2f6aceeb9a5c6599db271c4ea0037ded3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Sat, 27 May 2023 12:13:28 +0200 Subject: [PATCH 1/4] Enable lovely Coveralls again --- .github/workflows/ci.yml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 33f1e7b..cbf5f8b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,14 +34,11 @@ jobs: - name: Run Codesniffer run: vendor/bin/phpcs --standard=PSR2 ./src - # - name: Submit coverage to Coveralls - # # We use php-coveralls library for this, as the official Coveralls GitHub Action lacks support for clover reports: - # # https://github.com/coverallsapp/github-action/issues/15 - # env: - # COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - # COVERALLS_PARALLEL: true - # COVERALLS_FLAG_NAME: ${{ github.job }}-PHP-${{ matrix.php_version }} ${{ matrix.composer_flags }} - # run: | - # composer global require php-coveralls/php-coveralls - # ~/.composer/vendor/bin/php-coveralls -v - + - name: Submit coverage to Coveralls + env: + COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} + COVERALLS_PARALLEL: true + COVERALLS_FLAG_NAME: ${{ github.job }}-PHP-${{ matrix.php_version }}-${{ matrix.composer_flags }} + run: | + composer global require php-coveralls/php-coveralls + composer exec -- php-coveralls -v From b12d141f02e918754fad87d6b9108ab9b300ec72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Sat, 27 May 2023 12:22:15 +0200 Subject: [PATCH 2/4] Use PHAR of php-coveralls --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cbf5f8b..f53ab6d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,6 +39,7 @@ jobs: COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} COVERALLS_PARALLEL: true COVERALLS_FLAG_NAME: ${{ github.job }}-PHP-${{ matrix.php_version }}-${{ matrix.composer_flags }} + if: ${{ env.COVERALLS_REPO_TOKEN && matrix.composer_flags == '' }} run: | - composer global require php-coveralls/php-coveralls - composer exec -- php-coveralls -v + wget --no-verbose "https://github.com/php-coveralls/php-coveralls/releases/download/v2.5.3/php-coveralls.phar" + php ./php-coveralls.phar --verbose From 7695d2b035297ff9b8e5a10f7330d3db547e13ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Sat, 27 May 2023 12:28:36 +0200 Subject: [PATCH 3/4] Improve Coveralls settings --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f53ab6d..9f2e015 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -37,8 +37,8 @@ jobs: - name: Submit coverage to Coveralls env: COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - COVERALLS_PARALLEL: true - COVERALLS_FLAG_NAME: ${{ github.job }}-PHP-${{ matrix.php_version }}-${{ matrix.composer_flags }} + COVERALLS_PARALLEL: "true" + COVERALLS_FLAG_NAME: ${{ github.job }}-PHP-${{ matrix.php_version }} if: ${{ env.COVERALLS_REPO_TOKEN && matrix.composer_flags == '' }} run: | wget --no-verbose "https://github.com/php-coveralls/php-coveralls/releases/download/v2.5.3/php-coveralls.phar" From 846754b2d0f994d47735ac19ca740be3ffa7353c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Sat, 27 May 2023 13:34:02 +0200 Subject: [PATCH 4/4] Add Coveralls Finished job --- .github/workflows/ci.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9f2e015..0487850 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -43,3 +43,13 @@ jobs: run: | wget --no-verbose "https://github.com/php-coveralls/php-coveralls/releases/download/v2.5.3/php-coveralls.phar" php ./php-coveralls.phar --verbose + + finish: + needs: build-test + if: ${{ always() }} + runs-on: ubuntu-latest + steps: + - name: Coveralls Finished + uses: coverallsapp/github-action@v2 + with: + parallel-finished: true