Fix milestone value in notifications for strange counters#1025
Open
anf3is wants to merge 1 commit intoReactiveDrop:reactivedrop_betafrom
Open
Fix milestone value in notifications for strange counters#1025anf3is wants to merge 1 commit intoReactiveDrop:reactivedrop_betafrom
anf3is wants to merge 1 commit intoReactiveDrop:reactivedrop_betafrom
Conversation
Kill counts usually increment by 1, so this issue doesn’t appear there, but healing, for example, often increases the counter by more than 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Kill counters usually increment by 1, so this issue doesn’t appear there. But, for example, healing often increases the counter by more than 1.
This PR attempts to fix that by feeding the value of the milestone to Notification.