From f15d36cab60fa46aa511446dfcc95468cf740c3e Mon Sep 17 00:00:00 2001 From: Sprite Date: Mon, 18 May 2026 01:38:48 +0000 Subject: [PATCH] [ACEM] llteacher x ruff Policy: Ruff 0.14.8 Fixed: 6 violations Original Violations: src/homeworks/tests/test_detail_view.py: F841 Local variable `widget2` is assigned to but never used --> src/homeworks/tests/test_detail_view.py:258:9 | 256 | order=1, 257 | ) 258 | widget2 = HomeworkProgressWidget.objects.create( | ^^^^^^^ 259 | homework=self.homework, 260 | pre_prompt="Topic 2 pre", | help: Remove assignment to unused variable `widget2` Found 1 error. No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option). src/homeworks/tests/test_progress_widget.py: F841 Local variable `widget1` is assigned to but never used --> src/homeworks/tests/test_progress_widget.py:88:9 | 86 | def test_widget_ordering(self): 87 | """Test widget ordering by order field.""" 88 | widget1 = HomeworkProgressWidget.objects.create( | ^^^^^^^ 89 | homework=self.homework, pre_prompt="Pre 1", post_prompt="Post 1", order=2 90 | ) | help: Remove assignment to unused variable `widget1` F841 Local variable `widget2` is assigned to but never used --> src/homeworks/tests/test_progress_widget.py:91:9 | 89 | homework=self.homework, pre_prompt="Pre 1", post_prompt="Post 1", order=2 90 | ) 91 | widget2 = HomeworkProgressWidget.objects.create( | ^^^^^^^ 92 | homework=self.homework, pre_prompt="Pre 2", post_prompt="Post 2", order=1 93 | ) | help: Remove assignment to unused variable `widget2` F841 Local variable `widget3` is assigned to but never used --> src/homeworks/tests/test_progress_widget.py:94:9 | 92 | homework=self.homework, pre_prompt="Pre 2", post_prompt="Post 2", order=1 93 | ) 94 | widget3 = HomeworkProgressWidget.objects.create( | ^^^^^^^ 95 | homework=self.homework, pre_prompt="Pre 3", post_prompt="Post 3", order=3 96 | ) | help: Remove assignment to unused variable `widget3` Found 3 errors. No fixes available (3 hidden fixes can be enabled with the `--unsafe-fixes` option). src/homeworks/tests/test_widget_answer_view.py: F841 Local variable `messages` is assigned to but never used --> src/homeworks/tests/test_widget_answer_view.py:190:9 | 188 | ) 189 | self.assertEqual(response.status_code, 302) 190 | messages = ( | ^^^^^^^^ 191 | list(response.context["messages"]) 192 | if hasattr(response, "context") and response.context | help: Remove assignment to unused variable `messages` F841 Local variable `other_student` is assigned to but never used --> src/homeworks/tests/test_widget_answer_view.py:206:9 | 204 | username="other", email="other@example.com", password="password" 205 | ) 206 | other_student = Student.objects.create(user=new_user) | ^^^^^^^^^^^^^ 207 | 208 | self.client.login(username="other", password="password") | help: Remove assignment to unused variable `other_student` Found 2 errors. No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option). Automated by ACEM - Initiative #25 --- src/homeworks/tests/test_detail_view.py | 2 +- src/homeworks/tests/test_progress_widget.py | 6 +++--- src/homeworks/tests/test_widget_answer_view.py | 7 +------ 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/homeworks/tests/test_detail_view.py b/src/homeworks/tests/test_detail_view.py index bed3ca6..cc9176a 100644 --- a/src/homeworks/tests/test_detail_view.py +++ b/src/homeworks/tests/test_detail_view.py @@ -255,7 +255,7 @@ def test_widget_progress_shows_partial_answers(self): post_prompt="How much now?", order=1, ) - widget2 = HomeworkProgressWidget.objects.create( + HomeworkProgressWidget.objects.create( homework=self.homework, pre_prompt="Topic 2 pre", post_prompt="Topic 2 post", diff --git a/src/homeworks/tests/test_progress_widget.py b/src/homeworks/tests/test_progress_widget.py index 94b133c..7c9de79 100644 --- a/src/homeworks/tests/test_progress_widget.py +++ b/src/homeworks/tests/test_progress_widget.py @@ -85,13 +85,13 @@ def test_widget_str_representation(self): def test_widget_ordering(self): """Test widget ordering by order field.""" - widget1 = HomeworkProgressWidget.objects.create( + HomeworkProgressWidget.objects.create( homework=self.homework, pre_prompt="Pre 1", post_prompt="Post 1", order=2 ) - widget2 = HomeworkProgressWidget.objects.create( + HomeworkProgressWidget.objects.create( homework=self.homework, pre_prompt="Pre 2", post_prompt="Post 2", order=1 ) - widget3 = HomeworkProgressWidget.objects.create( + HomeworkProgressWidget.objects.create( homework=self.homework, pre_prompt="Pre 3", post_prompt="Post 3", order=3 ) diff --git a/src/homeworks/tests/test_widget_answer_view.py b/src/homeworks/tests/test_widget_answer_view.py index b939b4d..d47cd1b 100644 --- a/src/homeworks/tests/test_widget_answer_view.py +++ b/src/homeworks/tests/test_widget_answer_view.py @@ -187,11 +187,6 @@ def test_post_invalid_value_rejected(self): }, ) self.assertEqual(response.status_code, 302) - messages = ( - list(response.context["messages"]) - if hasattr(response, "context") and response.context - else [] - ) # Value should not be saved since 11 is out of range response_obj = HomeworkProgressWidgetResponse.objects.filter( user=self.student_user, widget=self.widget @@ -203,7 +198,7 @@ def test_not_enrolled_student_forbidden(self): new_user = User.objects.create_user( username="other", email="other@example.com", password="password" ) - other_student = Student.objects.create(user=new_user) + Student.objects.create(user=new_user) self.client.login(username="other", password="password") response = self.client.get(self.url)