chore(build): restore dynamic versioning setup#74
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restores dynamic versioning setup by moving the dynamic = ["version"] declaration to its proper location in pyproject.toml, aligning the fallback version format across configuration files, and ensuring CI workflows fetch complete git history for version determination via setuptools_scm.
Key changes:
- Relocated
dynamic = ["version"]from after dependencies to the main project section - Standardized fallback version format to
"0.0+unknown"acrosspyproject.tomlandversion.py - Updated GitHub Actions workflows to fetch full git history (
fetch-depth: 0)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Moved dynamic version declaration to proper location and added fallback_version configuration |
| leksara/version.py | Updated fallback version string to match setuptools_scm format |
| .github/workflows/python-publish.yml | Added fetch-depth: 0 to checkout actions and updated to v4 |
| .github/workflows/python-package.yml | Added fetch-depth: 0 to checkout action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.