Docs/notebooks#77
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Indonesian-language quickstart notebook with an expanded English-language "playbook" and removes the older full-feature test notebook. The new playbook consolidates quickstart instructions, feature demonstrations, and validation examples into a single comprehensive document.
Key changes:
- Replaced Indonesian quickstart with English playbook covering installation through advanced features
- Removed redundant full-feature test notebook
- Added installation instructions, usage guidelines, and structured feature sections
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| notebooks/leksara_quickstart.ipynb | Complete rewrite: transformed from Indonesian quickstart to comprehensive English playbook with sections on CartBoard, ReviewChain pipelines, benchmarking, logging, cleaning primitives, PII masking, normalization, and presets |
| notebooks/leksara_full_feature_tests.ipynb | Deleted entire file (807 lines removed) as content was consolidated into the expanded quickstart playbook |
Comments suppressed due to low confidence (1)
notebooks/leksara_quickstart.ipynb:1
- Corrected spelling of 'recieve' to 'receive'.
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "pip install leksara\n", | ||
| "```\n", | ||
| "\n", | ||
| "Tip: activate a virtual environment (for example `python -m venv .venv` then `.\\.venv\\Scripts\\activate`) to keep project dependencies isolated." |
There was a problem hiding this comment.
The virtual environment activation command uses Windows-specific path syntax (.\\.venv\\Scripts\\activate). Consider providing cross-platform instructions or noting this is Windows-specific, as Linux/macOS users would need source .venv/bin/activate.
| "Tip: activate a virtual environment (for example `python -m venv .venv` then `.\\.venv\\Scripts\\activate`) to keep project dependencies isolated." | |
| "Tip: activate a virtual environment (for example `python -m venv .venv` then `.\\.venv\\Scripts\\activate` on Windows, or `source .venv/bin/activate` on Linux/macOS) to keep project dependencies isolated." |
| " ('remove_whitespace', 6.599999323952943e-06),\n", | ||
| " ('remove_tags', 4.599998646881431e-06),\n", | ||
| " ('case_normal', 2.5999979698099196e-06),\n", | ||
| " ('unmask_rating_tokens', 7.999988156370819e-07)]}" |
There was a problem hiding this comment.
The timing metrics show 'unmask_rating_tokens' step appears but is not listed in the named_steps output below. This inconsistency suggests the step exists in the benchmark but may not be properly registered in the chain's named_steps, which could confuse users trying to audit pipeline composition.
| " ('unmask_rating_tokens', 7.999988156370819e-07)]}" | |
| " ('unmask_rating_tokens', 7.999988156370819e-07)]}", # Ensure this step is also registered in named_steps |
No description provided.