Publish Xerox concept theme#104
Merged
Merged
Conversation
1. **API key preflight** (`design.py/_phase_photos`): fails fast with `.env` setup instructions when no image key (OPENAI_API_KEY / FAL_KEY) is present, instead of burning ~1-2 min in the Claude prompt-build step before discovering the gap. 2. **Parallel image generation** (`design-agent.py/run_photos`): replaces the sequential per-SKU loop with a `ThreadPoolExecutor(max_workers=8)` (tunable via `FIFTY_PHOTO_WORKERS`). 30 product photos now complete in ~3-4 min instead of ~25 min. 3. **`--no-strict` propagates to agent subprocesses** (`design.py`): both `_phase_photos` and `_phase_frontpage` now pass `--keep-going` to `design-agent.py` whenever the parent pipeline was started with `--no-strict`, preventing the scoring snap from aborting a high- confidence layout. 4. **CDN race fixed** (`design.py/_wait_for_cdn`): after prepublish push, polls `raw.githubusercontent.com/<org>/<repo>/<branch>/<slug>/playground/ content/content.xml` in 5s increments (60s timeout) until the CDN serves the freshly-pushed file. Snap no longer dies with "W&O CSV malformed" on a fast machine. 5. **Structural template headings always rewritten** (`generate-microcopy.py`): adds `_TEMPLATE_STRUCTURAL_LABELS` (Dispatch address, Billing address, Returns within 30 days, etc.) that are force-added to the duplicate set and passed to the API for in-voice replacements before falling back to the generic hash-suffix label. Prevents short functional headings from slipping through when the API batch is large. 6. **Auto-allowlist for brand-new themes** (`design.py/_phase_allowlist`): new `allowlist` phase between `snap` and `check` that runs `snap.py allowlist regenerate --theme <slug>` once — but only when the theme has no existing allowlist entries — so inherited upstream WC axe-core findings don't block the very first build. Added to both `_PHASES_FOR_BUILD` and `_PHASES_FOR_DRESS`; SKILL.md phase table updated to match. Made-with: Cursor
Add a design-tokens phase that consumes the frontpage agent output, mockup, and home snap to produce token-patches.json and apply spacing, radius, shadow, border, and token-based CSS refinements. Wire mockups into the vision review path so mockup divergence is judged against the actual concept image instead of prose alone. Made-with: Cursor
…agent/xerox-concept
Removes generated placeholder copy, hardens photo retry behavior, and adds first-pass Xerox chrome polish so the branch can be reviewed while remaining visual-fit issues are handled follow-up. Published per explicit request to ship now and fix later. Local hook bypassed with known remaining checks: No !important in generated token patch CSS, distinctive chrome deltas for checkout/payment surfaces, theme screenshot refresh, and snap evidence freshness after final edits. The editor-parity block validator was fixed before bypassing. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playground
Test plan
python3 bin/check.py xerox --quick --phase contentnode bin/blocks-validator/check-blocks.mjs xeroxpython3 bin/snap.py report xerox --strictafter refreshed mobile/desktop snaps: 0 errors, warnings remain.!importantcleanup, distinctive chrome deltas, theme screenshot refresh, and snap evidence refresh after final edits.Made with Cursor