Changed: serdesAI allowed tools constructor signatures for better ergonomics and error handling

- Refactored all allowed tool constructors (ReadTool, EditTool, WriteTool, GrepTool, GlobTool) to accept flexible iterator inputs via 'impl IntoIterator<Item = impl AsRef<Path>>' instead of 'Vec<PathBuf>'
- All constructors now return 'ToolResult<Self>' instead of 'Self' to provide proper error handling for canonicalization failures
- Replaced 'AllowedPathResolver::from_canonical()' with 'AllowedPathResolver::new()' for consistent error propagation
- Updated test fixtures to use array literal syntax '[dir.path()]' instead of vector syntax 'vec![dir.path().to_path_buf()]' for improved readability
- Aligned serdesAI tool signatures with corresponding rig framework implementations for consistency

Author: Sewer56

src/llm-coding-tools-serdesai/src/allowed/edit.rs

@@ -8,7 +8,7 @@ use serde::Deserialize;
 use serdes_ai::tools::{
     RunContext, SchemaBuilder, Tool, ToolDefinition, ToolError, ToolResult, ToolReturn,
 };
-use std::path::PathBuf;
+use std::path::Path;
 
 use crate::convert::edit_error_to_serdes;
 
@@ -33,12 +33,15 @@ pub struct EditTool {
 }
 
 impl EditTool {
-    /// Creates a new edit tool restricted to the given canonical directories.
-    /// `allowed_directories` should already be canonicalized (see [`AllowedPathResolver::from_canonical`]).
-    pub fn new(allowed_directories: Vec<PathBuf>) -> Self {
-        Self {
-            resolver: AllowedPathResolver::from_canonical(allowed_directories),
-        }
+    /// Creates a new edit tool restricted to the given directories.
+    ///
+    /// Returns an error if any directory doesn't exist or can't be canonicalized.
+    pub fn new(
+        allowed_paths: impl IntoIterator<Item = impl AsRef<Path>>,
+    ) -> llm_coding_tools_core::ToolResult<Self> {
+        Ok(Self {
+            resolver: AllowedPathResolver::new(allowed_paths)?,
+        })
     }
 }
 
@@ -110,7 +113,7 @@ mod tests {
         let dir = TempDir::new().unwrap();
         std::fs::write(dir.path().join("test.txt"), "hello world").unwrap();
 
-        let tool = EditTool::new(vec![dir.path().to_path_buf()]);
+        let tool = EditTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),
@@ -130,7 +133,7 @@ mod tests {
     #[tokio::test]
     async fn rejects_path_traversal() {
         let dir = TempDir::new().unwrap();
-        let tool = EditTool::new(vec![dir.path().to_path_buf()]);
+        let tool = EditTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),

src/llm-coding-tools-serdesai/src/allowed/glob.rs

@@ -6,7 +6,7 @@ use llm_coding_tools_core::path::AllowedPathResolver;
 use llm_coding_tools_core::{ToolContext, ToolOutput};
 use serde::Deserialize;
 use serdes_ai::tools::{RunContext, SchemaBuilder, Tool, ToolDefinition, ToolError, ToolResult};
-use std::path::PathBuf;
+use std::path::Path;
 
 use crate::convert::to_serdes_result;
 
@@ -27,10 +27,12 @@ pub struct GlobTool {
 
 impl GlobTool {
     /// Creates a new glob tool restricted to the given directories.
-    pub fn new(allowed_directories: Vec<PathBuf>) -> Self {
-        Self {
-            resolver: AllowedPathResolver::from_canonical(allowed_directories),
-        }
+    pub fn new(
+        allowed_paths: impl IntoIterator<Item = impl AsRef<Path>>,
+    ) -> llm_coding_tools_core::ToolResult<Self> {
+        Ok(Self {
+            resolver: AllowedPathResolver::new(allowed_paths)?,
+        })
     }
 }
 
@@ -108,7 +110,7 @@ mod tests {
         fs::create_dir_all(dir.path().join("src")).unwrap();
         File::create(dir.path().join("src/lib.rs")).unwrap();
 
-        let tool = GlobTool::new(vec![dir.path().to_path_buf()]);
+        let tool = GlobTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),
@@ -127,7 +129,7 @@ mod tests {
     #[tokio::test]
     async fn rejects_path_traversal() {
         let dir = TempDir::new().unwrap();
-        let tool = GlobTool::new(vec![dir.path().to_path_buf()]);
+        let tool = GlobTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),

src/llm-coding-tools-serdesai/src/allowed/grep.rs

@@ -9,7 +9,7 @@ use serdes_ai::tools::{
     RunContext, SchemaBuilder, Tool, ToolDefinition, ToolError, ToolResult, ToolReturn,
 };
 use std::fmt::Write;
-use std::path::PathBuf;
+use std::path::Path;
 
 use crate::convert::to_serdes_result;
 
@@ -40,10 +40,12 @@ pub struct GrepTool<const LINE_NUMBERS: bool = true> {
 
 impl<const LINE_NUMBERS: bool> GrepTool<LINE_NUMBERS> {
     /// Creates a new grep tool restricted to the given directories.
-    pub fn new(allowed_directories: Vec<PathBuf>) -> Self {
-        Self {
-            resolver: AllowedPathResolver::from_canonical(allowed_directories),
-        }
+    pub fn new(
+        allowed_paths: impl IntoIterator<Item = impl AsRef<Path>>,
+    ) -> llm_coding_tools_core::ToolResult<Self> {
+        Ok(Self {
+            resolver: AllowedPathResolver::new(allowed_paths)?,
+        })
     }
 }
 
@@ -179,7 +181,7 @@ mod tests {
         let dir = TempDir::new().unwrap();
         std::fs::write(dir.path().join("test.txt"), "hello world").unwrap();
 
-        let tool: GrepTool<true> = GrepTool::new(vec![dir.path().to_path_buf()]);
+        let tool: GrepTool<true> = GrepTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),
@@ -199,7 +201,7 @@ mod tests {
     #[tokio::test]
     async fn rejects_path_traversal() {
         let dir = TempDir::new().unwrap();
-        let tool: GrepTool<true> = GrepTool::new(vec![dir.path().to_path_buf()]);
+        let tool: GrepTool<true> = GrepTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),
@@ -216,7 +218,7 @@ mod tests {
     #[tokio::test]
     async fn rejects_empty_pattern() {
         let dir = TempDir::new().unwrap();
-        let tool: GrepTool<true> = GrepTool::new(vec![dir.path().to_path_buf()]);
+        let tool: GrepTool<true> = GrepTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),

src/llm-coding-tools-serdesai/src/allowed/read.rs

@@ -6,7 +6,7 @@ use llm_coding_tools_core::path::AllowedPathResolver;
 use llm_coding_tools_core::{ToolContext, ToolResult as CoreToolResult};
 use serde::Deserialize;
 use serdes_ai::tools::{RunContext, SchemaBuilder, Tool, ToolDefinition, ToolError, ToolResult};
-use std::path::PathBuf;
+use std::path::Path;
 
 use crate::convert::to_serdes_result;
 
@@ -46,9 +46,9 @@ impl<const LINE_NUMBERS: bool> ReadTool<LINE_NUMBERS> {
     /// Creates a new read tool restricted to the given directories.
     ///
     /// Returns an error if any directory doesn't exist or can't be canonicalized.
-    pub fn new(allowed_directories: Vec<PathBuf>) -> CoreToolResult<Self> {
+    pub fn new(allowed_paths: impl IntoIterator<Item = impl AsRef<Path>>) -> CoreToolResult<Self> {
         Ok(Self {
-            resolver: AllowedPathResolver::new(allowed_directories)?,
+            resolver: AllowedPathResolver::new(allowed_paths)?,
         })
     }
 }
@@ -124,7 +124,7 @@ mod tests {
         let dir = TempDir::new().unwrap();
         std::fs::write(dir.path().join("test.txt"), "hello\nworld\n").unwrap();
 
-        let tool: ReadTool<true> = ReadTool::new(vec![dir.path().to_path_buf()]).unwrap();
+        let tool: ReadTool<true> = ReadTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),
@@ -145,7 +145,7 @@ mod tests {
     #[tokio::test]
     async fn rejects_path_traversal() {
         let dir = TempDir::new().unwrap();
-        let tool: ReadTool<true> = ReadTool::new(vec![dir.path().to_path_buf()]).unwrap();
+        let tool: ReadTool<true> = ReadTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),

src/llm-coding-tools-serdesai/src/allowed/write.rs

@@ -6,7 +6,7 @@ use llm_coding_tools_core::path::AllowedPathResolver;
 use llm_coding_tools_core::{ToolContext, ToolOutput};
 use serde::Deserialize;
 use serdes_ai::tools::{RunContext, SchemaBuilder, Tool, ToolDefinition, ToolError, ToolResult};
-use std::path::PathBuf;
+use std::path::Path;
 
 use crate::convert::to_serdes_result;
 
@@ -26,10 +26,12 @@ pub struct WriteTool {
 
 impl WriteTool {
     /// Creates a new write tool restricted to the given directories.
-    pub fn new(allowed_directories: Vec<PathBuf>) -> Self {
-        Self {
-            resolver: AllowedPathResolver::from_canonical(allowed_directories),
-        }
+    pub fn new(
+        allowed_paths: impl IntoIterator<Item = impl AsRef<Path>>,
+    ) -> llm_coding_tools_core::ToolResult<Self> {
+        Ok(Self {
+            resolver: AllowedPathResolver::new(allowed_paths)?,
+        })
     }
 }
 
@@ -85,7 +87,7 @@ mod tests {
     #[tokio::test]
     async fn writes_new_file() {
         let dir = TempDir::new().unwrap();
-        let tool = WriteTool::new(vec![dir.path().to_path_buf()]);
+        let tool = WriteTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),
@@ -105,7 +107,7 @@ mod tests {
     #[tokio::test]
     async fn rejects_path_traversal() {
         let dir = TempDir::new().unwrap();
-        let tool = WriteTool::new(vec![dir.path().to_path_buf()]);
+        let tool = WriteTool::new([dir.path()]).unwrap();
         let result = tool
             .call(
                 &mock_ctx(),