Changed: Extract test helpers from task.rs into shared module

- Move agent/allow_tools/pattern_task/deny_task into test_helpers.rs
- Import helpers with glob in task.rs tests

Author: Sewer56

src/reloaded-code-agents/src/lib.rs

@@ -6,6 +6,8 @@ mod loader;
 mod parser;
 mod path;
 mod runtime;
+#[cfg(test)]
+mod test_helpers;
 mod types;
 
 pub use catalog::AgentCatalog;

src/reloaded-code-agents/src/runtime/task.rs

@@ -193,9 +193,8 @@ fn collect_allowed_tools(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::types::PermissionRule;
-    use crate::{AgentConfig, AgentMode, AgentRuntimeBuilder, AgentToolSettings};
-    use ahash::AHashMap;
+    use crate::test_helpers::*;
+    use crate::AgentRuntimeBuilder;
     use indexmap::IndexMap;
     use reloaded_code_core::permissions::{ExpandError, PermissionAction};
     use reloaded_code_core::tool_metadata::{
@@ -204,49 +203,6 @@ mod tests {
 
     type TestResult = Result<(), ExpandError>;
 
-    fn agent(
-        name: &str,
-        mode: AgentMode,
-        description: &str,
-        permission: IndexMap<String, PermissionRule>,
-    ) -> AgentConfig {
-        AgentConfig {
-            name: name.into(),
-            mode,
-            description: description.into(),
-            model: None,
-            hidden: false,
-            temperature: None,
-            top_p: None,
-            permission,
-            options: AHashMap::new(),
-            tool_settings: AgentToolSettings::default(),
-            prompt: Default::default(),
-        }
-    }
-
-    fn allow_tools(names: &[&str]) -> IndexMap<String, PermissionRule> {
-        names
-            .iter()
-            .map(|n| ((*n).into(), PermissionRule::Action(PermissionAction::Allow)))
-            .collect()
-    }
-
-    fn pattern_task(patterns: &[(&str, PermissionAction)]) -> IndexMap<String, PermissionRule> {
-        let mut map = IndexMap::new();
-        for (pattern, action) in patterns {
-            map.insert(pattern.to_string(), *action);
-        }
-        IndexMap::from([(task_meta::NAME.into(), PermissionRule::Pattern(map))])
-    }
-
-    fn deny_task() -> IndexMap<String, PermissionRule> {
-        IndexMap::from([(
-            task_meta::NAME.into(),
-            PermissionRule::Action(PermissionAction::Deny),
-        )])
-    }
-
     /// Unknown callers yield no targets.
     #[test]
     fn callable_targets_returns_empty_for_unknown_caller() -> TestResult {

src/reloaded-code-agents/src/test_helpers.rs

@@ -0,0 +1,81 @@
+use crate::types::PermissionRule;
+use crate::{AgentConfig, AgentMode, AgentToolSettings};
+use ahash::AHashMap;
+use indexmap::IndexMap;
+use reloaded_code_core::permissions::PermissionAction;
+use reloaded_code_core::tool_metadata::task as task_meta;
+
+/// Build an [`AgentConfig`] for tests.
+///
+/// # Parameters
+/// - `name` - agent name
+/// - `mode` - agent operating mode
+/// - `description` - agent description
+/// - `permission` - initial permission rules
+///
+/// # Returns
+/// A populated [`AgentConfig`] with all other fields set to defaults.
+pub(crate) fn agent(
+    name: &str,
+    mode: AgentMode,
+    description: &str,
+    permission: IndexMap<String, PermissionRule>,
+) -> AgentConfig {
+    AgentConfig {
+        name: name.into(),
+        mode,
+        description: description.into(),
+        model: None,
+        hidden: false,
+        temperature: None,
+        top_p: None,
+        permission,
+        options: AHashMap::new(),
+        tool_settings: AgentToolSettings::default(),
+        prompt: Default::default(),
+    }
+}
+
+/// Map tool names to `Allow` permission rules.
+///
+/// # Parameters
+/// - `names` - tool names that should be allowed.
+///
+/// # Returns
+/// An ordered map of name → `PermissionRule::Action(Allow)`.
+pub(crate) fn allow_tools(names: &[&str]) -> IndexMap<String, PermissionRule> {
+    names
+        .iter()
+        .map(|n| ((*n).into(), PermissionRule::Action(PermissionAction::Allow)))
+        .collect()
+}
+
+/// Build task-scoped pattern permissions.
+///
+/// Patterns are wrapped under the task metadata name so they apply to task execution.
+///
+/// # Parameters
+/// - `patterns` - ordered pattern/action pairs.
+///
+/// # Returns
+/// A single-entry map keyed by [`task_meta::NAME`] containing [`PermissionRule::Pattern`].
+pub(crate) fn pattern_task(
+    patterns: &[(&str, PermissionAction)],
+) -> IndexMap<String, PermissionRule> {
+    let mut map = IndexMap::new();
+    for (pattern, action) in patterns {
+        map.insert(pattern.to_string(), *action);
+    }
+    IndexMap::from([(task_meta::NAME.into(), PermissionRule::Pattern(map))])
+}
+
+/// Return a deny-all rule for task execution.
+///
+/// # Returns
+/// A single-entry map keyed by [`task_meta::NAME`] with `PermissionRule::Action(Deny)`.
+pub(crate) fn deny_task() -> IndexMap<String, PermissionRule> {
+    IndexMap::from([(
+        task_meta::NAME.into(),
+        PermissionRule::Action(PermissionAction::Deny),
+    )])
+}