"foreach" is replaced when it shouldn't be replaced

[bschmalhofer]

In Kernel/System/Elasticsearch.pm, formerly in Kernel/Modules/Installer.pm, there is the following data structure:

    my %Pipeline = (
        description => "Extract external attachment information",
        processors  => [
            {
                foreach => {
                    field     => "Attachments",
                    processor => {
                        attachment => {
                            target_field => "_ingest._value.attachment",
                            field        => "_ingest._value.data"
                        }
                    }
                }
            },
            {
                foreach => {
                    field     => "Attachments",
                    processor => {
                        remove => {
                            field => "_ingest._value.data"
                        }
                    }
                }
            },
        ]
    );

The CodePoliy replaces the foreach by a for, which makes no sense at all.

[bschmalhofer]

In RotherOSS/otobo@c7efab4 there is a workaround for this issue, but the underlying problem has not been addressed yet.

[stefanhaerter]

What would you think of reworking the policy to use PPI to identify which type the toke in question is of?

[bschmalhofer]

If we want to spend time on this, then I suggest to write a Perl::Critic policy which uses PPI. A sane name would be Perl::Critic::Policy::OTOBO::ProhibitKeywordFor. It could be placed in the Kernel/cpan-lib directory. This directory already contains modules like Kernel/cpan-lib/Test2/Require/OTOBO/OpenLDAP.pm which are maintained by OTOBO but are expected to be in a specific namespace.