Refactor RabbitClient for shared resource management and cleanup#16
Merged
Conversation
…urces with ExecutorService - introduce sharedConsumerExecutor for managing consumer threads - rename closeEventLoopGroup to closeSharedResources for clarity - update shutdown logic to ensure proper resource cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project version and improves resource management in the RabbitMQ client implementation. The main focus is on introducing a shared thread pool for RabbitMQ consumers, ensuring proper shutdown of shared resources, and replacing coroutine-based shutdown logic with blocking calls for better reliability during shutdown.
Resource management improvements:
sharedConsumerExecutor) for RabbitMQ consumers and ensured it is properly initialized and shut down with the client, improving thread management and reducing the risk of resource leaks. [1] [2] [3] [4]closeEventLoopGroup(coroutine-based) tocloseSharedResources(blocking), and replaced coroutine delays withThread.sleepto ensure synchronous shutdown of resources. [1] [2] [3]Dependency and version updates:
gradle.propertiesfrom1.5.2to1.5.3.Code cleanup and improvements: