✨ feat(settings): integrate settings API for sound preferences#14
Open
JoField08 wants to merge 6 commits into
Open
✨ feat(settings): integrate settings API for sound preferences#14JoField08 wants to merge 6 commits into
JoField08 wants to merge 6 commits into
Conversation
JoField08
commented
May 5, 2026
JoField08
commented
Contributor
- add SettingsHook and hasSettingsApi to manage player sound settings
- update sound playback logic to respect user preferences for shop sounds
- create SettingsShopView for managing deal messages and sound settings
- add SettingsHook and hasSettingsApi to manage player sound settings - update sound playback logic to respect user preferences for shop sounds - create SettingsShopView for managing deal messages and sound settings
- add check for settings API and deal messages enablement - update message sending logic for shop seller
…rf-shop into feat/implementation-of-setting-api # Conflicts: # gradle.properties # surf-shop-paper/src/main/kotlin/dev/slne/surf/shop/paper/menu/ShopListView.kt # surf-shop-paper/src/main/kotlin/dev/slne/surf/shop/paper/menu/edit/storage/ItemStorageInsertView.kt # surf-shop-paper/src/main/kotlin/dev/slne/surf/shop/paper/menu/menu-utils.kt
…tion - remove conditional check for settings API and directly play level-up sound
TheBjoRedCraft
requested changes
May 16, 2026
| append { | ||
| if (result.deal.amount > 1) { | ||
| variableValue("${amount}x ") | ||
| if (!hasSettingsApi() || SettingsHook.hasDealMadeMessagesEnabled(uniqueId)) { |
Member
There was a problem hiding this comment.
Du musst gucken ob es Settings Api gibt und ob der Spieler es an hat. Wenn Settings nicht auf dem Server ist, darf der SettingsHook nicht aufgerufen werden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.