fix: fix pydantic import but moving duckdb attach earlier (#4049)

Author: eakmanrq

sqlmesh/core/config/connection.py

@@ -130,6 +130,30 @@ def get_catalog(self) -> t.Optional[str]:
         return None
 
 
+class DuckDBAttachOptions(BaseConfig):
+    type: str
+    path: str
+    read_only: bool = False
+    token: t.Optional[str] = None
+
+    def to_sql(self, alias: str) -> str:
+        options = []
+        # 'duckdb' is actually not a supported type, but we'd like to allow it for
+        # fully qualified attach options or integration testing, similar to duckdb-dbt
+        if self.type not in ("duckdb", "motherduck"):
+            options.append(f"TYPE {self.type.upper()}")
+        if self.read_only:
+            options.append("READ_ONLY")
+        # TODO: Add support for Postgres schema. Currently adding it blocks access to the information_schema
+        alias_sql = (
+            # MotherDuck does not support aliasing
+            f" AS {alias}" if not (self.type == "motherduck" or self.path.startswith("md:")) else ""
+        )
+        options_sql = f" ({', '.join(options)})" if options else ""
+        token_sql = "?motherduck_token=" + self.token if self.token else ""
+        return f"ATTACH '{self.path}{token_sql}'{alias_sql}{options_sql}"
+
+
 class BaseDuckDBConnectionConfig(ConnectionConfig):
     """Common configuration for the DuckDB-based connections.
 
@@ -357,30 +381,6 @@ def _static_connection_kwargs(self) -> t.Dict[str, t.Any]:
         return {"database": connection_str, "config": custom_user_agent_config}
 
 
-class DuckDBAttachOptions(BaseConfig):
-    type: str
-    path: str
-    read_only: bool = False
-    token: t.Optional[str] = None
-
-    def to_sql(self, alias: str) -> str:
-        options = []
-        # 'duckdb' is actually not a supported type, but we'd like to allow it for
-        # fully qualified attach options or integration testing, similar to duckdb-dbt
-        if self.type not in ("duckdb", "motherduck"):
-            options.append(f"TYPE {self.type.upper()}")
-        if self.read_only:
-            options.append("READ_ONLY")
-        # TODO: Add support for Postgres schema. Currently adding it blocks access to the information_schema
-        alias_sql = (
-            # MotherDuck does not support aliasing
-            f" AS {alias}" if not (self.type == "motherduck" or self.path.startswith("md:")) else ""
-        )
-        options_sql = f" ({', '.join(options)})" if options else ""
-        token_sql = "?motherduck_token=" + self.token if self.token else ""
-        return f"ATTACH '{self.path}{token_sql}'{alias_sql}{options_sql}"
-
-
 class DuckDBConnectionConfig(BaseDuckDBConnectionConfig):
     """Configuration for the DuckDB connection."""
 

tests/core/test_config.py

@@ -963,3 +963,11 @@ def test_environment_statements_config(tmp_path):
         "@grant_schema_privileges()",
         "GRANT REFERENCES ON FUTURE VIEWS IN DATABASE db TO ROLE admin_role;",
     ]
+
+
+# https://github.com/TobikoData/sqlmesh/pull/4049
+def test_pydantic_import_error() -> None:
+    class TestConfig(DuckDBConnectionConfig):
+        pass
+
+    TestConfig()