addressing themis comments

Author: benfdking

sqlmesh/core/model/definition.py

@@ -2174,7 +2174,7 @@ def load_sql_based_model(
     name = meta_fields.pop("name", "")
     if not name and infer_names:
         if path is None:
-            raise ValueError("Model must have a name", path)
+            raise ValueError(f"Model {name} must have a name")
         name = get_model_name(path)
 
     if not name:

sqlmesh/dbt/converter/convert.py

@@ -208,7 +208,7 @@ def _convert_models(
         if model.kind.is_seed:
             # this will produce the original seed file, eg "items.csv"
             if model._path is None:
-                raise ValueError(f"Unhandled model path: {model._path}")
+                raise ValueError(f"Unhandled model path for model {model_name}")
             seed_filename = model._path.relative_to(input_paths.seeds)
 
             # seed definition - rename "items.csv" -> "items.sql"

web/server/api/endpoints/models.py

@@ -122,12 +122,6 @@ def serialize_model(context: Context, model: Model, render_query: bool = False)
         sql = query.sql(pretty=True, dialect=model.dialect)
 
     path = model._path
-    if not path:
-        raise HTTPException(
-            status_code=HTTP_404_NOT_FOUND,
-            detail=f"Model {model.name} does not have a file path.",
-        )
-
     return models.Model(
         name=model.name,
         fqn=model.fqn,