fix: cicd bot correctly uses login (#1632)

Author: eakmanrq

sqlmesh/integrations/github/cicd/controller.py

@@ -307,7 +307,7 @@ def __init__(
         self._reviews: t.Iterable[PullRequestReview] = self._pull_request.get_reviews()
         # TODO: The python module says that user names can be None and this is not currently handled
         self._approvers: t.Set[str] = {
-            review.user.name or "UNKNOWN"
+            review.user.login or "UNKNOWN"
             for review in self._reviews
             if review.state.lower() == "approved"
         }

tests/integrations/github/cicd/fixtures.py

@@ -44,7 +44,8 @@ def _make_function(username: str, state: str, **kwargs) -> PullRequestReview:
             "test",  # type: ignore
             {},
             {
-                "user": AttributeDict(name=username),
+                # Name is whatever they provide in their GitHub profile or login as fallback. Always use login.
+                "user": AttributeDict(name="Unrelated", login=username),
                 "state": state,
                 **kwargs,
             },