memopt(safe): drop dead zz/vv/ww arrays and iden in get_odd_straight_with_v4

Bitwise-identical memory optimization of get_odd_straight_with_v4.

- Remove zz(nl,nl), vv(nl*(nl+1)/2) and ww(nl): declared and allocated
  but never read/written anywhere in the subroutine (verified by grep on
  the v1.5 source). They were also never deallocated -> a memory leak.
  zz alone is one full nl x nl array (= 1 "v4 unit").
- Remove the iden(nl,nl) scratch matrix. Instead of building iden and
  copying "maux = iden", initialize maux directly:
      maux = 0.0d0 ; do x=1,nl: maux(x,x)=1.0d0
  Same value, same bit pattern; saves one nl x nl allocation.

No BLAS call, no operation order, no numerics changed.
Standalone Fortran test (n_mode=6, symmetrized v3/v4): max|phi_new-phi_orig| = 0.0 exactly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: SorBalda

SCHAModules/get_odd_straight_with_v4.f90

@@ -20,7 +20,7 @@ subroutine get_odd_straight_with_v4 ( a, wr, er, transmode, amass, ityp_sc, T, v
 
 
   integer :: nat_sc, n_mode, nl, ns, ntyp
-  double precision, dimension(:,:), allocatable :: l, g, phi_aux, v1, v2, v32, iden
+  double precision, dimension(:,:), allocatable :: l, g, phi_aux, v1, v2, v32
   double precision :: lsum 
   double precision, dimension(:), allocatable :: laux1, lres1, veclong
   double precision, dimension(:), allocatable :: laux2, lres2
@@ -30,9 +30,6 @@ subroutine get_odd_straight_with_v4 ( a, wr, er, transmode, amass, ityp_sc, T, v
   integer, dimension(:), allocatable :: ipiv
   integer :: info
 
-  double precision, dimension(:), allocatable :: vv
-  double precision, dimension(:), allocatable :: ww
-  double precision, dimension(:,:), allocatable :: zz
   double precision, dimension(:,:), allocatable :: cf
 
   integer :: mu, nu, alpha
@@ -67,15 +64,10 @@ subroutine get_odd_straight_with_v4 ( a, wr, er, transmode, amass, ityp_sc, T, v
   allocate(ipiv(nl))
   allocate(work(nl))
   allocate(v32(n_mode,n_mode*n_mode))
-  allocate(iden(nl,nl))
 
   allocate(cf(nl,ns))
 
-  allocate(vv(nl*(nl+1)/2))
-  allocate(ww(nl))
-  allocate(zz(nl,nl))
-
-  ! Get lambda matrix 
+  ! Get lambda matrix
 
   call get_cmat ( a, wr, er, transmode, amass, ityp_sc, T, .true., lamat,n_mode, nat_sc, ntyp )
 
@@ -100,21 +92,20 @@ subroutine get_odd_straight_with_v4 ( a, wr, er, transmode, amass, ityp_sc, T, v
     end do
   end do
 
-  ! Prepare identity matrix
+  ! Prepare identity matrix directly in maux (was: iden then maux = iden;
+  ! bitwise identical, avoids one nl x nl temporary)
 
-  iden = 0.0d0
+  maux = 0.0d0
 
   do x = 1, nl
-    iden(x,x) = 1.0d0
+    maux(x,x) = 1.0d0
   end do
 
   ! Calculate ** iden - v4 lamat ** matrix
 
   !print *, "BEFORE I - V4Lambda"
   !call flush()
 
-  maux = iden
-
   call dgemm('N','N',nl,nl,nl,-1.0d0,v42,nl,lamat,nl,1.0d0,maux,nl) 
 
   ! Invert ** iden - lamat v4 **