Add AE function entry mode on latest master#1826
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1826 +/- ##
==========================================
+ Coverage 64.42% 64.44% +0.02%
==========================================
Files 252 252
Lines 25181 25208 +27
Branches 4763 4768 +5
==========================================
+ Hits 16223 16246 +23
- Misses 8958 8962 +4
🚀 New features to boost your workflow:
|
yuleisui
reviewed
May 19, 2026
| } | ||
| }); | ||
| const OptionMap<u32_t> Options::FunEntry( | ||
| "fun-entry", |
Contributor
Author
There was a problem hiding this comment.
ae-fun-entry
fixed
| WIDEN_NARROW | ||
| }; | ||
|
|
||
| enum FunEntryMode |
Contributor
Author
There was a problem hiding this comment.
AEFunEntryMode
fixed
Comment on lines
+752
to
+816
| if (mergeStatesFromPredecessors(node)) | ||
| if (node->getInEdges().empty()) | ||
| { | ||
| updateAbsState(node, getAbsState(globalNode)); | ||
| handleICFGNode(node); | ||
| } | ||
| else if (mergeStatesFromPredecessors(node)) | ||
| handleICFGNode(node); | ||
| } | ||
| else if (const ICFGCycleWTO* cycle = SVFUtil::dyn_cast<ICFGCycleWTO>(comp)) | ||
| { | ||
| if (mergeStatesFromPredecessors(cycle->head()->getICFGNode())) | ||
| const ICFGNode* node = cycle->head()->getICFGNode(); | ||
| if (node->getInEdges().empty()) | ||
| { | ||
| updateAbsState(node, getAbsState(globalNode)); | ||
| handleLoopOrRecursion(cycle, caller); | ||
| } | ||
| else if (mergeStatesFromPredecessors(node)) |
Collaborator
There was a problem hiding this comment.
It is unclear to me why we need to change this?
Contributor
Author
There was a problem hiding this comment.
It is unclear to me why we need to change this?
Because GlobalICFGNode just connects to FunEntryNode of Main Function. If there's no main function, FunEntryNode of no-caller Functions should inherit actively from GlobalNode.
Collaborator
There was a problem hiding this comment.
It should be handled in this loop at line 176 (entryFunctions should include all no-caller functions):
// handle Global ICFGNode of SVFModule
handleGlobalNode();
for (const FunObjVar* entryFun : entryFunctions)
{
const ICFGNode* funEntry = icfg->getFunEntryICFGNode(entryFun);
updateAbsState(node, getAbsState(globalNode));
handleFunction(funEntry);
}
bjjwwang
force-pushed
the
0506-master-compatible
branch
3 times, most recently
from
4a9e39e to
10b84a7
Compare
bjjwwang
force-pushed
the
0506-master-compatible
branch
from
10b84a7 to
770f478
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.