fix: prevent abort when Value is ConstantData#1830
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1830 +/- ##
=======================================
Coverage 64.44% 64.45%
=======================================
Files 252 252
Lines 25208 25210 +2
Branches 4768 4768
=======================================
+ Hits 16246 16248 +2
Misses 8962 8962
🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for the fix. It would be good to check any other places of the uses of constantdata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per llvm/llvm-project@9383fb2, LLVM 21 no longer permits the inspection of
usersofConstantData. I encountered two crashes due to this change.I added checks to guard the two calls that caused the crashes.