AbsExtAPI: make constructor private (friend AbstractInterpretation)#1831
Merged
Merged
Conversation
Only AbstractInterpretation creates and owns the single AbsExtAPI instance (exposed via its already-private getUtils()). Making the constructor private prevents external code from constructing its own AbsExtAPI to call handleExtAPI()/handleMemcpy()/... directly, which is useful when AbsExtAPI must not be reachable by client code (e.g. an assignment where the external-API summaries are the task). The library itself is unaffected: the in-class new AbsExtAPI(this) in AbstractInterpretation compiles via the friend grant.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1831 +/- ##
=======================================
Coverage 64.45% 64.45%
=======================================
Files 252 252
Lines 25210 25210
Branches 4768 4768
=======================================
Hits 16248 16248
Misses 8962 8962
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only AbstractInterpretation creates and owns the single AbsExtAPI instance (exposed via its already-private getUtils()). Making the constructor private prevents external code from constructing its own AbsExtAPI to call handleExtAPI()/handleMemcpy()/... directly, which is useful when AbsExtAPI must not be reachable by client code (e.g. an assignment where the external-API summaries are the task). The library itself is unaffected: the in-class new AbsExtAPI(this) in AbstractInterpretation compiles via the friend grant.