Skip to content

Call NodeIDAllocator::unset() when llvmModuleSet released.#1837

Merged
yuleisui merged 1 commit into
SVF-tools:masterfrom
vonavi:vonavi/allocator-unset
Jun 8, 2026
Merged

Call NodeIDAllocator::unset() when llvmModuleSet released.#1837
yuleisui merged 1 commit into
SVF-tools:masterfrom
vonavi:vonavi/allocator-unset

Conversation

@vonavi

@vonavi vonavi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hello!

Usually, one finishes an analysis calling releaseLLVMModuleSet(). After that, singleton NodeIDAllocator is still alive, so that next time we start with non-empty NodeIDAllocator and empty llvmModuleSet. So, this PR empties NodeIDAllocator too.

Best regards,
Vladimir.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.46%. Comparing base (4cc6c25) to head (0365258).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1837      +/-   ##
==========================================
+ Coverage   64.45%   64.46%   +0.01%     
==========================================
  Files         252      252              
  Lines       25210    25211       +1     
  Branches     4768     4768              
==========================================
+ Hits        16248    16253       +5     
+ Misses       8962     8958       -4     
Files with missing lines Coverage Δ
svf-llvm/include/SVF-LLVM/LLVMModule.h 97.61% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuleisui yuleisui merged commit 795fd5c into SVF-tools:master Jun 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants