updated custom models not being recompiled (Trac #576)

[pkienzle]

When updating the custom model within sasview on opencl the model doesn't always get updated.

When compiling to a dll, compile fails because dll is already loaded.

Migrated from http://trac.sasview.org/ticket/576

{
    "status": "closed",
    "changetime": "2016-10-09T15:21:40",
    "_ts": "2016-10-09 15:21:40.699626+00:00",
    "description": "When updating the custom model within sasview on opencl the model doesn't always get updated.\n\nWhen compiling to a dll, compile fails because dll is already loaded.",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-05-21T02:35:23",
    "component": "SasView",
    "summary": "updated custom models not being recompiled",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "wojciech",
    "type": "defect"
}

[wpotrzebowski]

Trac update at 2016/08/09 09:15:58:

• wojciech changed owner from "" to "wojciech"
• wojciech changed status from "new" to "assigned"

[pkienzle]

Trac update at 2016/08/16 15:13:48: pkienzle commented:

Can force use of DLL rather than OpenCL using the following in the python shell:

    import sasmodels.core
    sasmodels.core.USE_OPENCL = False

[pkienzle]

Trac update at 2016/08/16 15:46:51: pkienzle commented:

To reproduce, create a custom model using Fitting>Edit Custom Model>New, setting model to e.g.,

return a + cos(b*x)

You can then use this model on the fit page. When the model is updated, e.g., to:

return a + cos(b*x) + 100

the new model is not updated.

The same is true for C models. Update the model to:

form_volume = """return 1.0;"""
Iq = """return a + cos(b*q) + 1;"""
Iqxy = None

Test model update and reload on mac, windows wt/ opencl and windows wt/ tinycc.

[butlerpd]

Trac update at 2016/08/18 16:13:00: butler changed _comment0 from:

OpenCL fixed, DLL fails.

To get the DLL to work, first remove the frozen check in sasmodels.kerneldll.make_dll, then restructure the DllKernel so that it doesn't hold any references to the DLL.

Follow the instructions to reproduce above, but with sasmodels.core.HAVE_OPENCL=False.

We can do this by wrapping the ct.CDLL in a class with methods for the different kernels. Instead of calling the kernels directly, calls from DllKernel will go through this object. DllModel may be could do this if we can guarantee there is only ever one DllModel instance for a particular dll, for example, by caching DllModel within load_dll(). Then its internal dll can be released, recompiled and reloaded with any attached kernels automatically updated.

to:

1473041132931895

[pkienzle]

Trac update at 2016/08/18 16:13:00: pkienzle commented:

OpenCL fixed, DLL fails.

To get the DLL to work, first remove the frozen check in sasmodels.kerneldll.make_dll, then restructure the !DllKernel so that it doesn't hold any references to the DLL.

Follow the instructions to reproduce above, but with sasmodels.core.HAVE_OPENCL=False.

We can do this by wrapping the ct.CDLL in a class with methods for the different kernels. Instead of calling the kernels directly, calls from !DllKernel will go through this object. !DllModel may be could do this if we can guarantee there is only ever one !DllModel instance for a particular dll, for example, by caching !DllModel within load_dll(). Then its internal dll can be released, recompiled and reloaded with any attached kernels automatically updated.

[ajj]

Trac update at 2016/09/06 10:06:36: ajj commented:

A student I am working with (Windows / no OpenCL) noticed this problem and currently is working round it by deleting the dll to force a rebuild.

He also noticed that python models will rebuild if secondary functions are changed, but not if Iq and Iqxy are changed. Which is odd.

[ajj]

Trac update at 2016/09/26 08:41:46: ajj commented:

Attached model (hexagonal_cylinder.py) is the one that was causing problems - there was different rebuild behaviour between modifying secondary functions (e.g. Reflections() ) vs modifying Iq or Iqxy.