From 671dd9bd2fce171d5ede56f405298a2a0922f514 Mon Sep 17 00:00:00 2001 From: Andrei Solntsev Date: Thu, 2 Apr 2026 20:36:26 +0300 Subject: [PATCH 1/6] fix Ruby tests failing because of alerts in Firefox Seems that Firefox behavior with alerts was changed. Without "unhandledPromptBehavior" capability, command `wait_for_alert` is always failing in FireFox. --- .../selenium/webdriver/spec_support/test_environment.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb index 58f0a71386668..bc83f301e1613 100644 --- a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb +++ b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb @@ -324,6 +324,7 @@ def firefox_options(args: [], **opts) opts[:browser_version] = 'stable' if WebDriver::Platform.windows? opts[:web_socket_url] = true if ENV['WEBDRIVER_BIDI'] && !opts.key?(:web_socket_url) opts[:binary] ||= rlocation(ENV['FIREFOX_BINARY']) if ENV.key?('FIREFOX_BINARY') + opts[:unhandled_prompt_behavior] ||= 'ignore' args << '--headless' if ENV['HEADLESS'] WebDriver::Options.firefox(args: args, **opts) end From 20cc31853c5b0ebeaf1fbd5b6328bd212b451e06 Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Thu, 2 Apr 2026 16:16:59 -0400 Subject: [PATCH 2/6] Try to fix symlink issue for rules_ruby --- .github/workflows/bazel.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 34021e6f6a82a..7ceb977115cd2 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -199,6 +199,13 @@ jobs: crates: rust/Cargo.Bazel.lock repository-cache: true bazelrc: common --color=yes + # Workaround for rules_ruby MSYS2 "infinite symlink expansion detected" on Windows + - name: Remove MSYS2 recursive symlink + if: inputs.os == 'windows' + shell: bash + run: | + [ -L "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" ] && \ + rm "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev From 4054efe26e0de82dc62762a24f50620827885bef Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Thu, 2 Apr 2026 16:31:14 -0400 Subject: [PATCH 3/6] Trigger CI manually From 75df0cd605afc1b709e31790282f96ed306ac09f Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Thu, 2 Apr 2026 16:34:40 -0400 Subject: [PATCH 4/6] Fix workflow syntax --- .github/workflows/bazel.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index 7ceb977115cd2..dd6edf359a49b 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -201,11 +201,11 @@ jobs: bazelrc: common --color=yes # Workaround for rules_ruby MSYS2 "infinite symlink expansion detected" on Windows - name: Remove MSYS2 recursive symlink - if: inputs.os == 'windows' - shell: bash - run: | - [ -L "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" ] && \ - rm "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" + if: ${{ inputs.os == 'windows' }} + shell: bash + run: | + [ -L "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" ] && \ + rm "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev From 6fe4230683cd8370aff88ca69b1c54012db0dec4 Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Thu, 2 Apr 2026 16:57:59 -0400 Subject: [PATCH 5/6] Try again fixing the symlink issue --- .github/workflows/bazel.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index dd6edf359a49b..ccfaa2ddfdc18 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -204,8 +204,7 @@ jobs: if: ${{ inputs.os == 'windows' }} shell: bash run: | - [ -L "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" ] && \ - rm "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" + rm -f "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" || true - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev From c6f22dbb6a8fe79a91d57b61e1aba844b4611ff5 Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Thu, 2 Apr 2026 17:20:13 -0400 Subject: [PATCH 6/6] Revert workaround for ruby symlink issue --- .github/workflows/bazel.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml index ccfaa2ddfdc18..34021e6f6a82a 100644 --- a/.github/workflows/bazel.yml +++ b/.github/workflows/bazel.yml @@ -199,12 +199,6 @@ jobs: crates: rust/Cargo.Bazel.lock repository-cache: true bazelrc: common --color=yes - # Workaround for rules_ruby MSYS2 "infinite symlink expansion detected" on Windows - - name: Remove MSYS2 recursive symlink - if: ${{ inputs.os == 'windows' }} - shell: bash - run: | - rm -f "D:/b/external/rules_ruby++ruby+ruby/dist/msys64/etc/mtab-" || true - name: Setup curl for Ubuntu if: inputs.os == 'ubuntu' run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev