From 90120e10e14e595a136a6d6d08cdfb79ff99a024 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:47:05 +0100 Subject: [PATCH 01/14] Add CI for MW 1.44-45 and remove MW 1.39-1.42 --- .github/workflows/ci.yml | 36 ++++++++++-------------------------- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6fc9f9d..3c2ca0f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,52 +17,36 @@ jobs: strategy: matrix: include: - - mediawiki_version: '1.39' - smw_version: '4.2.0' + - mediawiki_version: '1.43' + smw_version: '6.0.1' pf_version: '5.9' php_version: 8.1 database_type: mysql database_image: "mariadb:11.2" coverage: false experimental: false - - mediawiki_version: '1.39' - smw_version: dev-master + - mediawiki_version: '1.43' + smw_version: '6.0.1' pf_version: '5.9' php_version: 8.1 database_type: mysql database_image: "mysql:8" - coverage: false - experimental: false - - mediawiki_version: '1.40' - smw_version: '4.2.0' - pf_version: '5.9' - php_version: 8.1 - database_type: mysql - database_image: "mariadb:11.2" coverage: true experimental: false - - mediawiki_version: '1.41' + - mediawiki_version: '1.44' smw_version: dev-master pf_version: '5.9' - php_version: 8.1 + php_version: 8.2 database_type: mysql - database_image: "mariadb:11.2" + database_image: "mariadb:11.8" coverage: false experimental: false - - mediawiki_version: '1.42' + - mediawiki_version: '1.45' smw_version: dev-master pf_version: '5.9' - php_version: 8.1 - database_type: mysql - database_image: "mariadb:11.2" - coverage: false - experimental: false - - mediawiki_version: '1.43' - smw_version: dev-master - pf_version: '5.9' - php_version: 8.1 + php_version: 8.3 database_type: mysql - database_image: "mariadb:11.2" + database_image: "mariadb:11.8" coverage: false experimental: false From c515f941eb48b5263cfbf7b054f647bece81464a Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:48:56 +0100 Subject: [PATCH 02/14] Rename .github/workflows/FUNDING.yml to .github/FUNDING.yml --- .github/{workflows => }/FUNDING.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{workflows => }/FUNDING.yml (100%) diff --git a/.github/workflows/FUNDING.yml b/.github/FUNDING.yml similarity index 100% rename from .github/workflows/FUNDING.yml rename to .github/FUNDING.yml From 6c9c361b28586f1213e98bf446c4f12ed6bbe8b1 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:49:59 +0100 Subject: [PATCH 03/14] Update extension.json --- extension.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension.json b/extension.json index 322ecf1..ce95ac6 100644 --- a/extension.json +++ b/extension.json @@ -14,7 +14,7 @@ "license-name": "GPL-2.0-or-later", "type": "semantic", "requires": { - "MediaWiki": ">= 1.39" + "MediaWiki": ">= 1.43" }, "AutoloadClasses": { "SFS\\Hooks": "SemanticFormsSelect.hooks.php", From 123ce93b2e6d44f0c819784573c448d2aac12845 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:50:15 +0100 Subject: [PATCH 04/14] Update ApiSemanticFormsSelect.php --- src/ApiSemanticFormsSelect.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ApiSemanticFormsSelect.php b/src/ApiSemanticFormsSelect.php index 380bcfc..14291b7 100644 --- a/src/ApiSemanticFormsSelect.php +++ b/src/ApiSemanticFormsSelect.php @@ -14,10 +14,10 @@ use ApiBase; use MediaWiki\MediaWikiServices; +use MediaWiki\Title\Title; use Parser; use ParserOptions; use ParserOutput; -use Title; class ApiSemanticFormsSelect extends ApiBase { From ff74432c36e6696c30e6b1c84713e69d01968dc7 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:50:38 +0100 Subject: [PATCH 05/14] Update SelectFieldTest.php --- tests/phpunit/Unit/SelectFieldTest.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/Unit/SelectFieldTest.php b/tests/phpunit/Unit/SelectFieldTest.php index 8b35624..4eb29c1 100644 --- a/tests/phpunit/Unit/SelectFieldTest.php +++ b/tests/phpunit/Unit/SelectFieldTest.php @@ -9,11 +9,10 @@ namespace SFS\Tests; use MediaWiki\MediaWikiServices; +use MediaWiki\Title\Title; use Parser; -use SFS\SelectField; - use ParserOptions; -use Title; +use SFS\SelectField; /** * @covers \SFS\SelectField From f6d543f732d89e979a383e1c7dbaee061d9cf282 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:53:21 +0100 Subject: [PATCH 06/14] Update Makefile --- Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 7eedeb6..b96d4fe 100644 --- a/Makefile +++ b/Makefile @@ -11,13 +11,13 @@ endif EXTENSION := SemanticFormsSelect # docker images -MW_VERSION?=1.39 +MW_VERSION?=1.43 PHP_VERSION?=8.1 -DB_TYPE?=sqlite -DB_IMAGE?="" +DB_TYPE?=mysql +DB_IMAGE?="mariadb:11.2" # extensions -SMW_VERSION?=dev-master +SMW_VERSION?=6.0.1 PF_VERSION?=5.9 # composer @@ -30,4 +30,3 @@ NODE_JS?=true # check for build dir and git submodule init if it does not exist include build/Makefile - From 806ea23b4984b8dfb15692dd2328309e3e0c54b9 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:53:43 +0100 Subject: [PATCH 07/14] Update .env-39 --- .env-39 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.env-39 b/.env-39 index 405353e..1ae5a8f 100644 --- a/.env-39 +++ b/.env-39 @@ -1,4 +1,4 @@ -MW_VERSION?=1.39 +MW_VERSION?=1.43 PHP_VERSION?=8.1 DB_TYPE?=mysql -DB_IMAGE?="mariadb:latest" \ No newline at end of file +DB_IMAGE?="mariadb:latest" From aa157f474deacff6b8fd62ffe47804a1ebbb1a20 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:54:52 +0100 Subject: [PATCH 08/14] Update composer.json --- composer.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 5ef50cf..5204528 100644 --- a/composer.json +++ b/composer.json @@ -37,11 +37,10 @@ } ], "require": { - "php": ">=7.4", + "php": ">=8.1", "composer/installers": ">=1.0.1" }, "require-dev": { - "mediawiki/semantic-media-wiki": "@dev", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", "php-parallel-lint/php-parallel-lint": "1.4.0" From bde0481390c506ef36003f26565dae96378c2e1a Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:58:29 +0100 Subject: [PATCH 09/14] Update ci.yml --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3c2ca0f..7360e09 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: include: - mediawiki_version: '1.43' smw_version: '6.0.1' - pf_version: '5.9' + pf_version: '6.0' php_version: 8.1 database_type: mysql database_image: "mariadb:11.2" @@ -27,7 +27,7 @@ jobs: experimental: false - mediawiki_version: '1.43' smw_version: '6.0.1' - pf_version: '5.9' + pf_version: '6.0' php_version: 8.1 database_type: mysql database_image: "mysql:8" @@ -35,7 +35,7 @@ jobs: experimental: false - mediawiki_version: '1.44' smw_version: dev-master - pf_version: '5.9' + pf_version: '6.0' php_version: 8.2 database_type: mysql database_image: "mariadb:11.8" @@ -43,7 +43,7 @@ jobs: experimental: false - mediawiki_version: '1.45' smw_version: dev-master - pf_version: '5.9' + pf_version: '6.0' php_version: 8.3 database_type: mysql database_image: "mariadb:11.8" From d3d8819695f1b849b9adc5d3100e6cb1b3ed8fd6 Mon Sep 17 00:00:00 2001 From: paladox Date: Sat, 11 Apr 2026 23:58:43 +0100 Subject: [PATCH 10/14] Update Makefile --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b96d4fe..97aa9d4 100644 --- a/Makefile +++ b/Makefile @@ -18,7 +18,7 @@ DB_IMAGE?="mariadb:11.2" # extensions SMW_VERSION?=6.0.1 -PF_VERSION?=5.9 +PF_VERSION?=6.0 # composer # Enables "composer update" inside of extension From 0e4e51637b9c5bd4f1f1359137dc77ac08d1bfff Mon Sep 17 00:00:00 2001 From: paladox Date: Sun, 12 Apr 2026 00:02:34 +0100 Subject: [PATCH 11/14] Update ApiSemanticFormsSelectTest.php --- tests/phpunit/Unit/ApiSemanticFormsSelectTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/Unit/ApiSemanticFormsSelectTest.php b/tests/phpunit/Unit/ApiSemanticFormsSelectTest.php index 5c76e31..1057a6b 100644 --- a/tests/phpunit/Unit/ApiSemanticFormsSelectTest.php +++ b/tests/phpunit/Unit/ApiSemanticFormsSelectTest.php @@ -2,11 +2,11 @@ namespace SFS\Tests; +use MediaWiki\Api\ApiMain; +use MediaWiki\Context\RequestContext; +use MediaWiki\Request\WebRequest; +use MediaWiki\Request\FauxRequest; use SFS\ApiSemanticFormsSelect; -use ApiMain; -use RequestContext; -use WebRequest; -use FauxRequest; /** * @covers \SFS\ApiSemanticFormsSelect From 8dac1ddb5030634677255ae6c8e176477c2c21a9 Mon Sep 17 00:00:00 2001 From: paladox Date: Sun, 12 Apr 2026 00:03:19 +0100 Subject: [PATCH 12/14] Update ApiSemanticFormsSelectRequestProcessorTest.php --- .../Unit/ApiSemanticFormsSelectRequestProcessorTest.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/Unit/ApiSemanticFormsSelectRequestProcessorTest.php b/tests/phpunit/Unit/ApiSemanticFormsSelectRequestProcessorTest.php index 67753c2..fedc372 100644 --- a/tests/phpunit/Unit/ApiSemanticFormsSelectRequestProcessorTest.php +++ b/tests/phpunit/Unit/ApiSemanticFormsSelectRequestProcessorTest.php @@ -2,11 +2,11 @@ namespace SFS\Tests; +use MediaWiki\Api\ApiMain; +use MediaWiki\Context\RequestContext; +use MediaWiki\Request\WebRequest; +use MediaWiki\Request\FauxRequest; use SFS\ApiSemanticFormsSelectRequestProcessor; -use ApiMain; -use RequestContext; -use WebRequest; -use FauxRequest; /** * @covers \SFS\ApiSemanticFormsSelectRequestProcessor From abd14e4197c517aa5aeddc08045736d95d9dcbee Mon Sep 17 00:00:00 2001 From: paladox Date: Sun, 12 Apr 2026 00:10:13 +0100 Subject: [PATCH 13/14] Update composer.json --- composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 5204528..ce61c68 100644 --- a/composer.json +++ b/composer.json @@ -71,8 +71,8 @@ "@phpunit-coverage" ], "lint": "parallel-lint . --exclude vendor --exclude node_modules --exclude extensions", - "phpunit": "php ../../tests/phpunit/phpunit.php -c phpunit.xml.dist", - "phpunit-coverage": "php ../../tests/phpunit/phpunit.php -c phpunit.xml.dist --testdox --coverage-text --coverage-html coverage/php --coverage-clover coverage/php/coverage.xml", + "phpunit": "php ${MW_INSTALL_PATH:-../..}/tests/phpunit/phpunit.php -c phpunit.xml.dist", + "phpunit-coverage": "php ${MW_INSTALL_PATH:-../..}/tests/phpunit/phpunit.php -c phpunit.xml.dist --testdox --coverage-text --coverage-clover coverage/php/coverage.xml", "post-test-coverage": [ "sed -i 's|/var/www/html/extensions/SemanticFormsSelect/||g' coverage/php/coverage.xml", "find coverage/php -type f -name '*.html' -exec sed -i 's|/var/www/html/extensions/||g' {} +" From 5a442e533ab9918459ef0c7e2c693f34df921f16 Mon Sep 17 00:00:00 2001 From: paladox Date: Sun, 12 Apr 2026 00:15:26 +0100 Subject: [PATCH 14/14] Update SelectFieldTest.php --- tests/phpunit/Unit/SelectFieldTest.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/phpunit/Unit/SelectFieldTest.php b/tests/phpunit/Unit/SelectFieldTest.php index 4eb29c1..15196d2 100644 --- a/tests/phpunit/Unit/SelectFieldTest.php +++ b/tests/phpunit/Unit/SelectFieldTest.php @@ -255,13 +255,7 @@ protected function setUp(): void { $name = $user->getName(); $parserOption; - if ( version_compare( MW_VERSION, '1.39', '>=' ) ) { - //check if version is higher than 1.39, or the same (the getOption() function within ParserOptions is different then in MW 1.35) - $parserOption = new ParserOptions( $user ); - } else { - //if MW version is lower than 1.39 - $parserOption = new ParserOptions( $name ); - } + $parserOption = new ParserOptions( $user ); $parser = MediaWikiServices::getInstance()->getParser(); $parser->setOutputType(Parser::OT_HTML); $parser->setTitle( Title::newFromText( 'NO TITLE' ) ); @@ -276,5 +270,4 @@ protected function tearDown(): void { parent::tearDown(); } - }