Skip to content

Commit ef2b799

Browse files
committed
Use new Utils helpers
1 parent 108fbea commit ef2b799

File tree

2 files changed

+15
-49
lines changed

2 files changed

+15
-49
lines changed

src/AndroidClient/client/src/androidTest/java/servicestack/net/client/tests/TechStacksServiceTests.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public void test_Can_call_FindTechnologies_AutoQuery_Implicit_Service() {
7373
.setTake(5);
7474

7575
QueryResponse<Technology> response = client.get(request,
76-
createMap("DescriptionContains","framework"));
76+
Utils.createMap("DescriptionContains","framework"));
7777

7878
assertEquals(5, response.getResults().size());
7979
}
@@ -195,7 +195,7 @@ public void test_Can_deserialize_Overview() throws IOException {
195195
}
196196
/* TEST HELPERS */
197197

198-
private void assertOverviewResponse(OverviewResponse r) {
198+
public static void assertOverviewResponse(OverviewResponse r) {
199199
assertNotNull(r);
200200
assertTrue(r.getTopUsers().size() > 0);
201201
assertTrue(r.getTopTechnologies().size() > 0);
@@ -204,16 +204,9 @@ private void assertOverviewResponse(OverviewResponse r) {
204204
assertTrue(r.getTopTechnologiesByTier().size() > 0);
205205
}
206206

207-
private void assertGetTechnologyResponse(GetTechnologyResponse r) {
207+
public static void assertGetTechnologyResponse(GetTechnologyResponse r) {
208208
assertNotNull(r);
209209
assertEquals("ServiceStack", r.getTechnology().getName());
210210
assertTrue(r.getTechnologyStacks().size() > 0);
211211
}
212-
213-
<K,V> HashMap<K,V> createMap(K k1, V v1) {
214-
HashMap<K,V> to = new HashMap<>();
215-
to.put(k1, v1);
216-
return to;
217-
}
218-
219212
}

src/AndroidClient/client/src/androidTest/java/servicestack/net/client/tests/TestServiceTests.java

Lines changed: 12 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -209,25 +209,25 @@ AllTypes createAllTypes() {
209209
.setDateTimeOffset(new Date(101, 0, 1))
210210
.setTimeSpan(new TimeSpan().addHours(1))
211211
.setGuid(UUID.randomUUID())
212-
.setStringList(createList("A", "B", "C"))
213-
.setStringArray(createList("D", "E", "F"))
214-
.setStringMap(createMap("A", "D", "B", "E", "C", "F"))
215-
.setIntStringMap(createMap(1, "A", 2, "B", 3, "C"))
212+
.setStringList(Utils.createList("A", "B", "C"))
213+
.setStringArray(Utils.createList("D", "E", "F"))
214+
.setStringMap(Utils.createMap("A", "D", "B", "E", "C", "F"))
215+
.setIntStringMap(Utils.createMap(1, "A", 2, "B", 3, "C"))
216216
.setSubType(new SubType().setId(1).setName("name"));
217217

218218
return to;
219219
}
220220

221221
AllCollectionTypes createAllCollectionTypes(){
222222
AllCollectionTypes to = new AllCollectionTypes()
223-
.setIntArray(createList(1, 2, 3))
224-
.setIntList(createList(4, 5, 6))
225-
.setStringArray(createList("A", "B", "C"))
226-
.setStringList(createList("D","E","F"))
227-
.setPocoArray(createList(createPoco("pocoArray")))
228-
.setPocoList(createList(createPoco("pocoList")))
229-
.setPocoLookup(createMap("A", createList(createPoco("B"), createPoco("C"))))
230-
.setPocoLookupMap(createMap("A", createList(createMap("B", createPoco("C")), createMap("D", createPoco("E")))));
223+
.setIntArray(Utils.createList(1, 2, 3))
224+
.setIntList(Utils.createList(4, 5, 6))
225+
.setStringArray(Utils.createList("A", "B", "C"))
226+
.setStringList(Utils.createList("D","E","F"))
227+
.setPocoArray(Utils.createList(createPoco("pocoArray")))
228+
.setPocoList(Utils.createList(createPoco("pocoList")))
229+
.setPocoLookup(Utils.createMap("A", Utils.createList(createPoco("B"), createPoco("C"))))
230+
.setPocoLookupMap(Utils.createMap("A", Utils.createList(Utils.createMap("B", createPoco("C")), Utils.createMap("D", createPoco("E")))));
231231
return to;
232232
}
233233

@@ -312,31 +312,4 @@ void assertPocoEquals(Poco expected, Poco actual){
312312
assertNotNull(actual);
313313
assertEquals(actual.getName(), expected.getName());
314314
}
315-
316-
<T> ArrayList<T> createList(T... params) {
317-
ArrayList<T> to = new ArrayList<>();
318-
to.addAll(Arrays.asList(params));
319-
return to;
320-
}
321-
322-
<K,V> HashMap<K,V> createMap(K k1, V v1) {
323-
HashMap<K,V> to = new HashMap<>();
324-
to.put(k1, v1);
325-
return to;
326-
}
327-
328-
<K,V> HashMap<K,V> createMap(K k1, V v1, K k2, V v2) {
329-
HashMap<K,V> to = new HashMap<>();
330-
to.put(k1, v1);
331-
to.put(k2, v2);
332-
return to;
333-
}
334-
335-
<K,V> HashMap<K,V> createMap(K k1, V v1, K k2, V v2, K k3, V v3) {
336-
HashMap<K,V> to = new HashMap<>();
337-
to.put(k1, v1);
338-
to.put(k2, v2);
339-
to.put(k3, v3);
340-
return to;
341-
}
342315
}

0 commit comments

Comments
 (0)