Promise lints are annoying

[bouk]

I keep running into these two lint errors and not knowing what to do

29:3  warning  Expected catch() or return                  promise/catch-or-return
29:3  error    Each then() should return a value or throw  promise/always-return

In the first case I often don't care about the error state and just want it to fail and bugsnag notify when that happens.

In the second case I would be doing something with the result value of a promise, but don't want to chain the promise. Why would I need to return something in that case?

@lemonmade

[marutypes]

want it to fail and busnag notify

The issue with this is that promises swallow errors. In fact this can even swallow errors that don't have anything to do with the promises' asynchronous code.

A workaround is manually adding a .catch() in which you rethrow them.

[bouk]

@TheMallen rethrowing in a catch won't cause them to be notified either though, right? It'll just get swallowed again

[bouk]

I guess in the case where we have bugsnag we can do .catch(Bugsnag.notifyException)

[lemonmade]

Yeah, the catch one is annoying but prevents a bad and kind of unexpected behaviour of promises, so I think we should leave it and have some sort of catch-all promise handling that people can use easily. I wouldn't really care if we ditch the always-return rule, I've also had cases where I kind of uselessly returned a value to satisfy the rule.

[davidcornu]

• I wouldn't really care if we ditch the always-return rule, I've also had cases where I kind of uselessly returned a value to satisfy the rule.

  👍

• I guess in the case where we have bugsnag we can do .catch(Bugsnag.notifyException)

  The downside here is that these won't be reported in tests or in the console

• I think we should leave it and have some sort of catch-all promise handling that people can use easily

  💯