From 48050f5475d649c8226d287750d2fe53de679212 Mon Sep 17 00:00:00 2001 From: Alright Date: Mon, 23 Feb 2026 13:19:44 -0500 Subject: [PATCH 1/4] validate RPCFundAccountsRequest --- rhp/v4/rpc.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rhp/v4/rpc.go b/rhp/v4/rpc.go index a2a99c7a..455a464b 100644 --- a/rhp/v4/rpc.go +++ b/rhp/v4/rpc.go @@ -689,6 +689,10 @@ func RPCFundAccounts(ctx context.Context, t TransportClient, cs consensus.State, RenterSignature: revision.RenterSignature, } + if err := req.Validate(); err != nil { + return RPCFundAccountResult{}, fmt.Errorf("invalid request: %w", err) + } + var resp rhp4.RPCFundAccountsResponse if err := callSingleRoundtripRPC(ctx, t, rhp4.RPCFundAccountsID, &req, &resp); err != nil { return RPCFundAccountResult{}, err From 9d31add68adfc588decd5783d2f42f05a0d5e8a7 Mon Sep 17 00:00:00 2001 From: "knope-bot[bot]" <152252888+knope-bot[bot]@users.noreply.github.com> Date: Mon, 23 Feb 2026 18:21:58 +0000 Subject: [PATCH 2/4] Auto generate changeset --- .changeset/validate_rpcfundaccountsrequest.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .changeset/validate_rpcfundaccountsrequest.md diff --git a/.changeset/validate_rpcfundaccountsrequest.md b/.changeset/validate_rpcfundaccountsrequest.md new file mode 100644 index 00000000..0442ad82 --- /dev/null +++ b/.changeset/validate_rpcfundaccountsrequest.md @@ -0,0 +1,9 @@ +--- +default: patch +--- + +# validate RPCFundAccountsRequest + +#401 by @Alrighttt + +This method was implemented but never used. From 471b418cb2526646e2a0085318d2fd8a1dc9266f Mon Sep 17 00:00:00 2001 From: Alrighttt <36680730+Alrighttt@users.noreply.github.com> Date: Tue, 24 Feb 2026 22:35:57 -0500 Subject: [PATCH 3/4] Update .changeset/validate_rpcfundaccountsrequest.md Co-authored-by: Christopher Schinnerl <3903476+ChrisSchinnerl@users.noreply.github.com> --- .changeset/validate_rpcfundaccountsrequest.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.changeset/validate_rpcfundaccountsrequest.md b/.changeset/validate_rpcfundaccountsrequest.md index 0442ad82..c58839d3 100644 --- a/.changeset/validate_rpcfundaccountsrequest.md +++ b/.changeset/validate_rpcfundaccountsrequest.md @@ -2,8 +2,4 @@ default: patch --- -# validate RPCFundAccountsRequest - -#401 by @Alrighttt - -This method was implemented but never used. +# Validate RPCFundAccountsRequest From 1232cb2c9bf30cf69c1f05dbff541ea56c78c2a6 Mon Sep 17 00:00:00 2001 From: Chris Schinnerl <3903476+ChrisSchinnerl@users.noreply.github.com> Date: Wed, 25 Feb 2026 16:08:39 +0100 Subject: [PATCH 4/4] add validate to handleRPCFundAccounts --- rhp/v4/server.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rhp/v4/server.go b/rhp/v4/server.go index 7b91fb35..cac60c18 100644 --- a/rhp/v4/server.go +++ b/rhp/v4/server.go @@ -397,6 +397,8 @@ func (s *Server) handleRPCFundAccounts(stream net.Conn) error { var req rhp4.RPCFundAccountsRequest if err := rhp4.ReadRequest(stream, &req); err != nil { return errorDecodingError("failed to read request: %v", err) + } else if err := req.Validate(); err != nil { + return err } state, unlock, err := s.lockContractForRevision(req.ContractID)