Additional top button functions in current dev

[popy2k14]

@Skons you have added those functions in the current dev:

• Top button double press now enables local alarm for testing purposes
• Simplified the top button long press

Is it possible to make them configurable?
Why i am asking?

My family members like it simple, so any additional function on the top button will lead to confusion and/or incorrect operation (sure it's a user issue :-).

thx

[Skons]

What do you mean by "make them configurable"? Enabled/disabled, or your own functions?

[popy2k14]

Sorry for not beiing clear, yes, make them Enabled/Disabled with an substiution.
Also we should think about the default value, because those functions, a "normal" user will likely not use.

For me and my family, i will disable them.

Please dont get me wrong, i love new features, but please keep the top alarm button a simple as possible.
You must consider that users are sleppy when they are using the device.
So any additional function, which can be triggered accidently.

[Skons]

I'm not getting you wrong. I am struggeling with this myself too. Sometimes i need development features to test stuff, and i think by providing a enable/disable possibility would bring back KISS for those who do not need these awesome features ;)

[popy2k14]

That would be great ;)

[Skons]

Dev has been updated, please review the changelog. A lot has been changed...

[popy2k14]

Just a few things i have noticedon an quick review:

top_button_long_press_enabled: "true"
top_button_triple_press_enabled: "true"
top_button_double_press_enabled: "true"

Nice!
When i got the yaml code and esphome api right, it means we are ignoring the presses now, when those are set to false.
Wouldn't it be better if any of those is set to false, the action is the same as the single click?
Or much better, put the long, double, tripple click code in seperate yaml and let the user include them? (did'nt check if that is possible, just an idea).

In the "Readme.md" and yaml files of the RTTTL fallback feature is gone!?
Is there a reason for this?
This is my default fallback, in case there are Wifi/HA issues.

[Skons]

Same as single click would be extra work, and introduces the same code multiple times. Which i don't think is worth the effort.

As for the RTTTL, i removed that because when there is no wifi, the media_player falls back to the local file. So the RTTTL is really redundancy that does not add value. But, i could have been too hasty with removing the RTTTL code, i will add it back