-All contributions must be inline with our [Code of Conduct](https://github.com/Slimefun/Slimefun4/blob/master/.github/CODE_OF_CONDUCT.md) and [License](https://github.com/Slimefun/Slimefun4/blob/master/LICENSE). +All contributions must be inline with our [Code of Conduct](https://github.com/Slimefun5/Slimefun5/blob/master/.github/CODE_OF_CONDUCT.md) and [License](https://github.com/Slimefun5/Slimefun5/blob/master/LICENSE). Please also follow the templates for Issues and Pull Requests we provide. ## :beetle: 1. Issues: Bug Reports One of the foundations for good software is reliability. To facilitate this reliability, our community must work together to crush bugs that arise. This of course requires good information and knowledge about ongoing bugs and issues though. -You can help this project by reporting a bug on our [Issues Tracker](https://github.com/Slimefun/Slimefun4/issues).
+You can help this project by reporting a bug on our [Issues Tracker](https://github.com/Slimefun5/Slimefun5/issues).
Please adhere to the provided template and provide as much information as possible. -For more info on how to make good and helpful bug reports, check out our article on [How to report bugs](https://github.com/Slimefun/Slimefun4/wiki/How-to-report-bugs). +For more info on how to make good and helpful bug reports, check out our article on [How to report bugs](https://github.com/Slimefun5/Slimefun5/wiki/How-to-report-bugs). If you encounter an issue which has already been reported, please don't open a new one.
It would be awesome though if you could post a comment on the existing issue which explains how you were able to reproduce this yourself. @@ -17,10 +17,10 @@ The more context and information we get, the easier we can fix it. ## :hammer_and_wrench: 2. Pull Requests: Bug Fixes Bugs that have been reported need to be fixed of course.
-Any open Issue on our [Issues Tracker](https://github.com/Slimefun/Slimefun4/issues) is waiting to be fixed. +Any open Issue on our [Issues Tracker](https://github.com/Slimefun5/Slimefun5/issues) is waiting to be fixed. This is an Open-Source project and we love Pull Requests. -So if you have an idea on how to approach a known issue, feel free to make a [Pull Request](https://github.com/Slimefun/Slimefun4/pulls) which fixes this bug. +So if you have an idea on how to approach a known issue, feel free to make a [Pull Request](https://github.com/Slimefun5/Slimefun5/pulls) which fixes this bug. You can also comment on the existing Issue, proposing your idea or communicating that you wanna work on this. ## :wrench: 3. Pull Requests: Additions/Changes @@ -34,7 +34,7 @@ Suggestions which gotten enough votes will be moved to `#approved`. Therefore our `#approved` is a great place to start looking for ideas on what to add or change, since it will definitely be something a large number of people agree with. Also consider making an addon for your additions when they get too large, too abstract or too "niche". -You can check out our [Developer Guide](https://github.com/Slimefun/Slimefun4/wiki/Developer-Guide) for a guide on how to create a Slimefun addon.. +You can check out our [Developer Guide](https://github.com/Slimefun5/Slimefun5/wiki/Developer-Guide) for a guide on how to create a Slimefun addon.. ## :earth_africa: 4. Pull Requests: Translations Another great way to contribute to Slimefun is by working on translations for the project. @@ -46,7 +46,7 @@ One of our Language Moderators will review the changes and submit a Pull Request Very active community translators will have the option to become a "Language Moderator". Language Moderators are responsible for proof-reading any new translations for their designated language and correct it when they see a mistake. -For more info on how or what to translate, check out our article on [How to translate Slimefun](https://github.com/Slimefun/Slimefun4/wiki/Translating-Slimefun). +For more info on how or what to translate, check out our article on [How to translate Slimefun](https://github.com/Slimefun5/Slimefun5/wiki/Translating-Slimefun). ## :scroll: 5. Pull Requests: Wiki contributions Slimefun is a very large project and might be quite intimidating for new players. @@ -55,12 +55,12 @@ If you have played with Slimefun for a while and gotten yourself familiar with h It would help out a lot :heart: You can find a tutorial on how to contribute to our wiki right here:
-https://github.com/Slimefun/Slimefun4/wiki/Expanding-the-Wiki +https://github.com/Slimefun5/Slimefun5/wiki/Expanding-the-Wiki ## :star: 6. Pull Requests: Code Quality -Slimefun uses [sonarcloud.io](https://sonarcloud.io/dashboard?id=Slimefun_Slimefun4) to monitor Code Quality. +Slimefun uses [sonarcloud.io](https://sonarcloud.io/dashboard?id=Slimefun_Slimefun5) to monitor Code Quality. -We always welcome quality improvements to the code and the "Code Smells" section on [sonarcloud.io](https://sonarcloud.io/dashboard?id=Slimefun_Slimefun4) is a great place to start. +We always welcome quality improvements to the code and the "Code Smells" section on [sonarcloud.io](https://sonarcloud.io/dashboard?id=Slimefun_Slimefun5) is a great place to start. But please keep in mind that some design patterns may not be changed too abruptly if an addon depends on them. To prevent any accidents from happening, please contact us on our [Discord Server](https://discord.gg/slimefun) before-hand and state your intended changes. @@ -70,21 +70,21 @@ Code documentation is also a great way to improve the maintainability of the pro 2. Classes should also include an `@author` tag to indicate who worked on that class. 3. Methods and parameters should be annotated with `@Nullable` or `@Nonnull` to indicate whether or not null values are accepted. -Feel free to visit our [Javadocs](https://slimefun.github.io/javadocs/Slimefun4/docs/overview-summary.html) +Feel free to visit our [Javadocs](https://slimefun.github.io/javadocs/Slimefun5/docs/overview-summary.html) #### Unit Tests Unit Tests help us test the project to work as intended in an automated manner.
-More or better Unit Tests are always good to have, so feel free to submit a Test and place it in our [src/test/java](https://github.com/Slimefun/Slimefun4/tree/master/src/test/java/io/github/thebusybiscuit/slimefun4/testing) directory +More or better Unit Tests are always good to have, so feel free to submit a Test and place it in our [src/test/java](https://github.com/Slimefun5/Slimefun5/tree/master/src/test/java/io/github/thebusybiscuit/slimefun5/testing) directory We are using [Junit 5 - Jupiter](https://github.com/junit-team/junit5/) and [MockBukkit](https://github.com/seeseemelk/MockBukkit) as our testing environment.
Every new Unit Test should have a `@DisplayName` annotation with a plain text description on what the Unit Test tests. -## :toolbox: How to compile Slimefun4 +## :toolbox: How to compile Slimefun5 Slimefun is written in Java and uses [Maven](https://maven.apache.org/) for compilation.
To compile Slimefun yourself, follow these steps: 1. Clone the project via git
-`$ git clone https://github.com/Slimefun/Slimefun4/` +`$ git clone https://github.com/Slimefun5/Slimefun5/` 2. Compile the project using Maven
`$ mvn clean package` 3. Extract the compiled `Slimefun-v4.X-UNOFFICIAL.jar` from your `/target/` directory. @@ -144,7 +144,7 @@ But do try to follow our code style as best as you can.* * Constants (`static final` fields) should be in *SCREAMING_SNAKE_CASE* (e.g. `MY_CONSTANT_FIELD`) * Variables, parameters and fields should be in *camelCase* (e.g. `myVariableOrField`) * All methods should be in *camelCase* (e.g. `myMethod`) -* Packages must be all lowercase, consecutive words should generally be avoided. (e.g. `io.github.thebusybiscuit.slimefun4.core.something`) +* Packages must be all lowercase, consecutive words should generally be avoided. (e.g. `io.github.thebusybiscuit.slimefun5.core.something`) #### 7. Style preferences * Use **Spaces**, not Tabs! * One class per file! Please don't put multiple classes into one file, this also applies to enums, make a seperate file for new classes or enums. @@ -200,3 +200,4 @@ private void example(int x) { } } ``` + diff --git a/README.md b/README.md deleted file mode 100644 index affc3ed96c..0000000000 --- a/README.md +++ /dev/null @@ -1,165 +0,0 @@ -# Slimefun 4 -*Looking for the download link? [**Click here**](https://github.com/Slimefun/Slimefun4/blob/master/README.md#floppy_disk-download-slimefun-4)* - -Slimefun is a plugin which aims to turn your Spigot Server into a modpack without ever installing a single mod. It offers everything you could possibly imagine. From Backpacks to Jetpacks! Slimefun lets every player decide on their own how much they want to dive into Magic or Tech.
-We got everything from magical wands to nuclear reactors.
-We feature a magical altar, an electric power grid and even item transport systems. - -This project originally started back **in 2013** and has grown ever since.
-From one single person working on this plugin back then, we grew to a community of thousands of players and hundreds of contributors to this project.
-It currently adds over **500 new items and recipes** to Minecraft ([Read more about the history of this project](https://github.com/Slimefun/Slimefun4/wiki/Slimefun-in-a-nutshell)). - -But it also comes with a lot of addons! Check out our [addons](https://github.com/Slimefun/Slimefun4/wiki/Addons), you may find exactly what you were looking for. - -### Quick navigation -* **[:floppy_disk: Download Slimefun4](#floppy_disk-download-slimefun-4)** -* **[:framed_picture: Screenshots](#framed_picture-screenshots)** -* **[:headphones: Discord Support Server](#headphones-discord)** -* **[:beetle: Bug Tracker](https://github.com/Slimefun/Slimefun4/issues)** -* **[:open_book: Wiki](https://github.com/Slimefun/Slimefun4/wiki)** -* **[:interrobang: FAQ](https://github.com/Slimefun/Slimefun4/wiki/FAQ)** -* **[:handshake: How to contribute](https://github.com/Slimefun/Slimefun4/blob/master/CONTRIBUTING.md)** - -## :floppy_disk: Download Slimefun 4 -Slimefun requires your Minecraft Server to be running on [Spigot](https://spigotmc.org/), [Paper](https://papermc.io/) or on any fork of these.
-(See also: [How to install Slimefun](https://github.com/Slimefun/Slimefun4/wiki/Installing-Slimefun)) - -Slimefun 4 can be downloaded **for free** on our builds page.
-We currently provide two distinct versions of Slimefun, development builds and "stable" builds.
-Here is a full summary of the differences between the two different versions of Slimefun. - -| | development (latest) | "stable" | -| ------------------ | -------- | -------- | -| **Minecraft version(s)** | :video_game: **1.16.\* - 1.20.\*** | :video_game: **1.16.\* - 1.20.\*** | -| **Java version** | :computer: **Java 16 (or higher)** | :computer: **Java 16 (or higher)** | -| **automatic updates** | :heavy_check_mark: | :heavy_check_mark: | -| **frequent updates** | :heavy_check_mark: | :x: | -| **latest content** | :heavy_check_mark: | :x: | -| **Discord support** | :heavy_check_mark: | :x: | -| **Bug Reports** | :heavy_check_mark: | :x: | -| **testing before release** | :x: | :heavy_check_mark: | -| **change logs** | :x: | :memo: **[change log](https://github.com/Slimefun/Slimefun4/blob/master/CHANGELOG.md)** | -| **Download links** | :floppy_disk: **[download latest](https://blob.build/project/Slimefun4/Dev)** | :floppy_disk: **[download "stable"](https://blob.build/project/Slimefun4/RC)** | - -**:exclamation: We wholeheartedly recommend you to use _development builds_, they are the most recent version of Slimefun and also receive the most frequent updates! In fact, "stable" builds are so outdated that we won't accept bug reports from them at all.** -
Here's why...
- -"Stable" builds do not receive frequent updates or fast patches. As time goes on, bugs are fixed but it will take some time until these fixes make it into a "stable" build. We will also not accept or review any bug reports from "stable" builds. They are in fact just old development builds that seemed to run fine without any __major__ issues. - -**:question: Why use a "stable" build then?**-While "stable" builds most definitely contain more bugs than development builds due to their very slow update schedule. you can be sure that they will not include __game-breaking__ issues, but rest assured that development builds almost never contain such issues either. If your server or business however heavily depends on a version of Slimefun that does not change/update a lot, you are forgiven if you choose the "stable" branch. But development builds will bring you the best experience, both in terms of features and bug fixes. - -**:question: What exactly are these "stable" builds then and why do you put them in quotes?**
-"Stable" builds are literally just outdated development builds that seemed to run fine without any __major__ issues. But they are far from bug-free hence why actually calling them stable would be hypocritical. However these builds can only really stay "stable" if there are enough people using development builds and report any bugs they come across. Otherwise potential issues may go unnoticed and slip into a "stable" build. Again, we really recommend you to choose the development builds. But since a few people really wanted "stable" builds, they are now an option too. - -
-Well, we asked some users on our [Discord server](#headphones-discord) to send us some screenshots, so see for yourself: -| Reactors and electricity | Awesome factories | Magic and Altars | -| :-------------------------------------------: | :--------------------------------------: | :----------------------------------------: | -|  |  |  | -| *Screenshot provided by HamtaBot#0001* | *Screenshot provided by Piͭxͪeͤl (mnb)#5049* | *Screenshot provided by Kilaruna#4981* | -|  |  |  | -| *Screenshot provided by GalaxyKat11#3816* | *Screenshot provided by TamThan#7987* | *Screenshot provided by Kilaruna#4981* | - -## :headphones: Discord -You can find Slimefun's community on Discord and connect with **over 7000** users of this plugin from all over the world.
-Click the badge down below to join the server for suggestions/questions or other discussions about this plugin.
-We are also hosting a community event every so often, join us to find out more.
-**Important: We don't accept bug reports on discord, please use our [Issue Tracker](https://github.com/Slimefun/Slimefun4/issues) to submit bug reports!** - -Due to the sheer size of this discord server, we need to enforce some [important rules](https://github.com/Slimefun/Slimefun4/wiki/Discord-Rules).
-Not following these rules can lead to a kick or even a ban from the server. - -
-
- 
-
-
-**Over 200 people have already contributed to this amazing project. You guys are awesome! :heart:**
-Please consider helping us maintain this project too, your engagement keeps the project alive! - -You can find more info on how to contribute to this project in our [CONTRIBUTING.md](https://github.com/Slimefun/Slimefun4/blob/master/CONTRIBUTING.md). - -## :exclamation: Disclaimers -Slimefun4 uses various systems that collect usage information or download automatic updates as well as the latest information about the project. -We do not collect any personal information from you but there are some services that may gather or download some form of data. - -You can opt-out of the Auto-Updater and stats collection at any time! - -
Automatic updates
- -Slimefun4 uses an Auto-Updater which connects to https://thebusybiscuit.github.io/builds/ to check for and download updates.-This behaviour is enabled by default but can be turned off under `/plugins/Slimefun/config.yml`.
-We highly recommend you to keep this on at any time though, as you could be missing out on important patches. -
Metrics and Statistics
- -Slimefun4 uses [bStats](https://bstats.org/plugin/bukkit/Slimefun/4574) to collect anonymous information about the usage of this plugin.-This is solely for statistical purposes, as we are interested in how Servers/Players use this plugin.
-All available data is anonymous and aggregated, at no point can we see individual server or player information.
-All of the collected data is publicly accessible: https://bstats.org/plugin/bukkit/Slimefun/4574 - -You can also disable this behaviour under `/plugins/bStats/config.yml`.
-For more info see [bStats' Privacy Policy](https://bstats.org/privacy-policy) - -Our [bStats Module](https://github.com/Slimefun/MetricsModule) is downloaded automatically when installing this Plugin, this module will automatically update on server starts independently from the main plugin. This way we can automatically roll out updates to the bStats module, in cases of severe performance issues for example where live data and insight into what is impacting performance can be crucial. -These updates can of course be disabled under `/plugins/Slimefun/config.yml`. To disable metrics collection as a whole, see the paragraph above. - ---- - -Slimefun also uses its own analytics system to collect anonymous information about the performance of this plugin.
-This is solely for statistical purposes, as we are interested in how it's performing for all servers.
-All available data is anonymous and aggregated, at no point can we see individual server information.
- -You can also disable this behaviour under `/plugins/Slimefun/config.yml`.
- -
GitHub Integration
- -Lastly, Slimefun4 connects to https://api.github.com/ to gather information about this open-source project.-No information about you or your Minecraft Server is sent to GitHub. - -This information includes (but is not limited to) -* list of contributors, their username and profile link (from the repositories `Slimefun/Slimefun4`, `Slimefun/Slimefun-Wiki` and `Slimefun/Resourcepack`) -* amount of open issues in this repository -* amount of pending pull requests in this repository -* amount of stars in this repository -* amount of forks of this repository -* amount of code-bytes in this repository -* date of the last commit to this repository -
- -*Note that Slimefun is not associated with `Mojang Studios` or `Minecraft`.* diff --git a/compat-api/build.gradle.kts b/compat-api/build.gradle.kts new file mode 100644 index 0000000000..f66d13c155 --- /dev/null +++ b/compat-api/build.gradle.kts @@ -0,0 +1,21 @@ +plugins { + java +} + +java { + toolchain { + languageVersion.set(JavaLanguageVersion.of(8)) + } +} + +repositories { + mavenCentral() + maven("https://hub.spigotmc.org/nexus/content/repositories/snapshots") + maven("https://oss.sonatype.org/content/repositories/snapshots") +} + +dependencies { + compileOnly("org.spigotmc:spigot-api:1.8.8-R0.1-SNAPSHOT") { + isTransitive = false + } +} diff --git a/compat-api/src/main/java/io/github/thebusybiscuit/slimefun5/compat/SFBlock.java b/compat-api/src/main/java/io/github/thebusybiscuit/slimefun5/compat/SFBlock.java new file mode 100644 index 0000000000..8ba2dc581a --- /dev/null +++ b/compat-api/src/main/java/io/github/thebusybiscuit/slimefun5/compat/SFBlock.java @@ -0,0 +1,103 @@ +package io.github.thebusybiscuit.slimefun5.compat; + +import org.bukkit.Material; +import org.bukkit.block.Block; +import org.bukkit.block.BlockFace; +import org.bukkit.block.BlockState; +import org.bukkit.material.Directional; + +import java.lang.reflect.Method; + +public class SFBlock { + + private final Block block; + + private static Method getBlockDataMethod; + private static Method setBlockDataMethod; + private static Class blockDataClass; + private static Class directionalClass; + private static Method getFacingMethod; + private static Method setFacingMethod; + + private static boolean isModern; + + static { + try { + blockDataClass = Class.forName("org.bukkit.block.data.BlockData"); + directionalClass = Class.forName("org.bukkit.block.data.Directional"); + getBlockDataMethod = Block.class.getMethod("getBlockData"); + setBlockDataMethod = Block.class.getMethod("setBlockData", blockDataClass); + getFacingMethod = directionalClass.getMethod("getFacing"); + setFacingMethod = directionalClass.getMethod("setFacing", BlockFace.class); + isModern = true; + } catch (Exception e) { + isModern = false; + } + } + + public SFBlock(Block block) { + this.block = block; + } + + public Block getBlock() { + return block; + } + + @SuppressWarnings("deprecation") + public void setType(SFMaterial material) { + Material mat = material.toMaterial(); + if (mat == null) return; + + block.setType(mat); + + if (!isModern) { + byte legacyData = material.getLegacyData(); + if (legacyData != 0) { + block.setData(legacyData); + } + } + } + + @SuppressWarnings("deprecation") + public BlockFace getFacing() { + if (isModern) { + try { + Object blockData = getBlockDataMethod.invoke(block); + if (directionalClass.isInstance(blockData)) { + return (BlockFace) getFacingMethod.invoke(blockData); + } + } catch (Exception e) { + // Ignore + } + } else { + BlockState state = block.getState(); + if (state.getData() instanceof Directional) { + return ((Directional) state.getData()).getFacing(); + } + } + return BlockFace.SELF; + } + + @SuppressWarnings("deprecation") + public void setFacing(BlockFace face) { + if (isModern) { + try { + Object blockData = getBlockDataMethod.invoke(block); + if (directionalClass.isInstance(blockData)) { + setFacingMethod.invoke(blockData, face); + setBlockDataMethod.invoke(block, blockData); + } + } catch (Exception e) { + // Ignore + } + } else { + BlockState state = block.getState(); + if (state.getData() instanceof Directional) { + Directional dir = (Directional) state.getData(); + dir.setFacingDirection(face); + state.setData((org.bukkit.material.MaterialData) dir); + state.update(true); + } + } + } +} diff --git a/compat-api/src/main/java/io/github/thebusybiscuit/slimefun5/compat/SFItemStack.java b/compat-api/src/main/java/io/github/thebusybiscuit/slimefun5/compat/SFItemStack.java new file mode 100644 index 0000000000..f837120b49 --- /dev/null +++ b/compat-api/src/main/java/io/github/thebusybiscuit/slimefun5/compat/SFItemStack.java @@ -0,0 +1,75 @@ +package io.github.thebusybiscuit.slimefun5.compat; + +import java.lang.reflect.Method; +import java.util.List; + +import org.bukkit.inventory.ItemStack; +import org.bukkit.inventory.meta.ItemMeta; + +public class SFItemStack { + + private final ItemStack item; + + private static Method setCustomModelDataMethod; + private static Method setLocalizedNameMethod; + + static { + try { + setCustomModelDataMethod = ItemMeta.class.getMethod("setCustomModelData", Integer.class); + } catch (NoSuchMethodException | SecurityException e) { + // Ignore + } + try { + setLocalizedNameMethod = ItemMeta.class.getMethod("setLocalizedName", String.class); + } catch (NoSuchMethodException | SecurityException e) { + // Ignore + } + } + + public SFItemStack(ItemStack item) { + this.item = item; + } + + public ItemStack getItem() { + return item; + } + + public SFItemStack setLocalizedName(String name) { + if (item != null && item.getItemMeta() != null) { + ItemMeta meta = item.getItemMeta(); + if (setLocalizedNameMethod != null) { + try { + setLocalizedNameMethod.invoke(meta, name); + item.setItemMeta(meta); + } catch (Exception e) { + // Ignore + } + } + } + return this; + } + + public SFItemStack setLore(List
+ * Core compiles against the 1.8.8 floor where Adventure is absent. This {@code compileOnly} stub lets
+ * the Adventure-typed methods compile; it is NOT shaded, so on modern Paper the real Component is used
+ * at runtime (full feature parity). On legacy servers these methods simply are not callable.
+ */
+public interface Component {
+}
diff --git a/compat-stubs/src/main/java/net/kyori/adventure/text/event/HoverEvent.java b/compat-stubs/src/main/java/net/kyori/adventure/text/event/HoverEvent.java
new file mode 100644
index 0000000000..7d42042ab4
--- /dev/null
+++ b/compat-stubs/src/main/java/net/kyori/adventure/text/event/HoverEvent.java
@@ -0,0 +1,14 @@
+package net.kyori.adventure.text.event;
+
+/**
+ * Compile-only shadow stub of Adventure's {@code net.kyori.adventure.text.event.HoverEvent}.
+ * Not shaded; the real type is used on modern Paper at runtime. See {@code net.kyori.adventure.text.Component}.
+ *
+ * @param
+ * See {@link NamespacedKey} for the rationale. This is a {@code compileOnly} dependency and is not
+ * shaded into the jar. Note: classes that {@code implements Keyed} will fail to class-load on
+ * 1.8–1.11 servers (the interface is absent at runtime); those are handled in the version layer.
+ */
+public interface Keyed {
+
+ NamespacedKey getKey();
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/Nameable.java b/compat-stubs/src/main/java/org/bukkit/Nameable.java
new file mode 100644
index 0000000000..451d59dc74
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/Nameable.java
@@ -0,0 +1,12 @@
+package org.bukkit;
+
+/**
+ * Compile-only stub for {@code org.bukkit.Nameable} (Minecraft 1.12+). Not shaded; on modern servers
+ * the real interface is used at runtime.
+ */
+public interface Nameable {
+
+ String getCustomName();
+
+ void setCustomName(String name);
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/NamespacedKey.java b/compat-stubs/src/main/java/org/bukkit/NamespacedKey.java
new file mode 100644
index 0000000000..a9884a3be4
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/NamespacedKey.java
@@ -0,0 +1,67 @@
+package org.bukkit;
+
+import org.bukkit.plugin.Plugin;
+
+/**
+ * Compile-only shadow stub of Bukkit's {@code org.bukkit.NamespacedKey} (introduced in MC 1.12).
+ *
+ * Slimefun's core compiles against the 1.8.8 API floor, where this type does not exist. This stub
+ * exposes only the surface that core uses so the code compiles. It is supplied through a
+ * {@code compileOnly} dependency and is not shaded into the jar: on 1.12+ servers
+ * the server's real {@code NamespacedKey} is used at runtime. On 1.8–1.11 the type is absent at
+ * runtime, so any code path touching it must be guarded by the version layer.
+ *
+ * The method and constructor signatures mirror Bukkit's exactly so bytecode compiled against this
+ * stub binds to the real class at runtime.
+ */
+public final class NamespacedKey {
+
+ private final String namespace;
+ private final String key;
+
+ public NamespacedKey(Plugin owner, String key) {
+ this.namespace = owner == null ? "minecraft" : owner.getName().toLowerCase();
+ this.key = key;
+ }
+
+ public NamespacedKey(String namespace, String key) {
+ this.namespace = namespace;
+ this.key = key;
+ }
+
+ public static NamespacedKey minecraft(String key) {
+ return new NamespacedKey("minecraft", key);
+ }
+
+ public String getNamespace() {
+ return namespace;
+ }
+
+ public String getKey() {
+ return key;
+ }
+
+ @Override
+ public int hashCode() {
+ return (namespace + ":" + key).hashCode();
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj) {
+ return true;
+ }
+
+ if (!(obj instanceof NamespacedKey)) {
+ return false;
+ }
+
+ NamespacedKey other = (NamespacedKey) obj;
+ return namespace.equals(other.namespace) && key.equals(other.key);
+ }
+
+ @Override
+ public String toString() {
+ return namespace + ":" + key;
+ }
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/Particle.java b/compat-stubs/src/main/java/org/bukkit/Particle.java
new file mode 100644
index 0000000000..c1a07a0abf
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/Particle.java
@@ -0,0 +1,51 @@
+package org.bukkit;
+
+/**
+ * Compile-only shadow stub of Bukkit's {@code org.bukkit.Particle} (introduced in MC 1.9).
+ *
+ * Core compiles against the 1.8.8 API floor where this type does not exist. This stub exposes only
+ * the constants and the {@link DustOptions} nested type that Slimefun core references directly, so
+ * the code compiles. It is a {@code compileOnly} dependency and is NOT shaded into the jar: on 1.9+
+ * servers the server's real {@code Particle} is used at runtime (resolved by name, so differing enum
+ * ordinals are irrelevant). On 1.8 the type is absent at runtime, so particle code paths must be
+ * version-guarded (particles are a 1.9+ feature with no Bukkit API equivalent on 1.8).
+ *
+ * Constants are the post-1.20.5 names used directly in source; older-named variants are resolved
+ * reflectively at runtime by {@code VersionedParticle}.
+ */
+public enum Particle {
+
+ DUST,
+ SMOKE,
+ HAPPY_VILLAGER,
+ ENCHANTED_HIT,
+ EXPLOSION,
+ WITCH,
+ FIREWORK,
+ ENCHANT,
+ PORTAL,
+ HEART,
+ CRIMSON_SPORE;
+
+ /**
+ * Stub of {@code Particle.DustOptions} (the colored-dust data object). Signatures mirror Bukkit's.
+ */
+ public static class DustOptions {
+
+ private final Color color;
+ private final float size;
+
+ public DustOptions(Color color, float size) {
+ this.color = color;
+ this.size = size;
+ }
+
+ public Color getColor() {
+ return color;
+ }
+
+ public float getSize() {
+ return size;
+ }
+ }
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/TileState.java b/compat-stubs/src/main/java/org/bukkit/block/TileState.java
new file mode 100644
index 0000000000..2b4e241ae2
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/TileState.java
@@ -0,0 +1,11 @@
+package org.bukkit.block;
+
+import org.bukkit.persistence.PersistentDataHolder;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.TileState} (Minecraft 1.14+). Not shaded; on modern
+ * servers the real interface is used at runtime. Mirrors the real hierarchy ({@code extends BlockState,
+ * PersistentDataHolder}) so {@code instanceof}/casts and {@code getPersistentDataContainer()} resolve.
+ */
+public interface TileState extends BlockState, PersistentDataHolder {
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/Ageable.java b/compat-stubs/src/main/java/org/bukkit/block/data/Ageable.java
new file mode 100644
index 0000000000..e144379adf
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/Ageable.java
@@ -0,0 +1,14 @@
+package org.bukkit.block.data;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.Ageable} (Minecraft 1.13+). Signatures match the
+ * real interface so calls resolve at runtime on modern servers.
+ */
+public interface Ageable extends BlockData {
+
+ int getAge();
+
+ void setAge(int age);
+
+ int getMaximumAge();
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/BlockData.java b/compat-stubs/src/main/java/org/bukkit/block/data/BlockData.java
new file mode 100644
index 0000000000..1a6f8a21ec
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/BlockData.java
@@ -0,0 +1,13 @@
+package org.bukkit.block.data;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.BlockData} (added in Minecraft 1.13). Not
+ * shaded; on modern servers the real interface is used at runtime. Declared as a marker — concrete
+ * methods live on the sub-interfaces that Slimefun actually calls.
+ */
+public interface BlockData {
+
+ org.bukkit.Material getMaterial();
+
+ boolean isSupported(org.bukkit.block.Block block);
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/Directional.java b/compat-stubs/src/main/java/org/bukkit/block/data/Directional.java
new file mode 100644
index 0000000000..8499c40aa6
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/Directional.java
@@ -0,0 +1,13 @@
+package org.bukkit.block.data;
+
+import org.bukkit.block.BlockFace;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.Directional} (Minecraft 1.13+).
+ */
+public interface Directional extends BlockData {
+
+ BlockFace getFacing();
+
+ void setFacing(BlockFace facing);
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/Levelled.java b/compat-stubs/src/main/java/org/bukkit/block/data/Levelled.java
new file mode 100644
index 0000000000..549fbb94a9
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/Levelled.java
@@ -0,0 +1,13 @@
+package org.bukkit.block.data;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.Levelled} (Minecraft 1.13+).
+ */
+public interface Levelled extends BlockData {
+
+ int getLevel();
+
+ void setLevel(int level);
+
+ int getMaximumLevel();
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/Orientable.java b/compat-stubs/src/main/java/org/bukkit/block/data/Orientable.java
new file mode 100644
index 0000000000..c2e7e10b43
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/Orientable.java
@@ -0,0 +1,13 @@
+package org.bukkit.block.data;
+
+import org.bukkit.Axis;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.Orientable} (Minecraft 1.13+).
+ */
+public interface Orientable extends BlockData {
+
+ Axis getAxis();
+
+ void setAxis(Axis axis);
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/Rotatable.java b/compat-stubs/src/main/java/org/bukkit/block/data/Rotatable.java
new file mode 100644
index 0000000000..b0b3baad71
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/Rotatable.java
@@ -0,0 +1,13 @@
+package org.bukkit.block.data;
+
+import org.bukkit.block.BlockFace;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.Rotatable} (Minecraft 1.13+).
+ */
+public interface Rotatable extends BlockData {
+
+ BlockFace getRotation();
+
+ void setRotation(BlockFace rotation);
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/Waterlogged.java b/compat-stubs/src/main/java/org/bukkit/block/data/Waterlogged.java
new file mode 100644
index 0000000000..b8be5fc311
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/Waterlogged.java
@@ -0,0 +1,11 @@
+package org.bukkit.block.data;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.Waterlogged} (Minecraft 1.13+).
+ */
+public interface Waterlogged extends BlockData {
+
+ boolean isWaterlogged();
+
+ void setWaterlogged(boolean waterlogged);
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/type/Dispenser.java b/compat-stubs/src/main/java/org/bukkit/block/data/type/Dispenser.java
new file mode 100644
index 0000000000..74faf57567
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/type/Dispenser.java
@@ -0,0 +1,9 @@
+package org.bukkit.block.data.type;
+
+import org.bukkit.block.data.Directional;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.type.Dispenser} (Minecraft 1.13+).
+ */
+public interface Dispenser extends Directional {
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/type/Farmland.java b/compat-stubs/src/main/java/org/bukkit/block/data/type/Farmland.java
new file mode 100644
index 0000000000..a70cdc093a
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/type/Farmland.java
@@ -0,0 +1,15 @@
+package org.bukkit.block.data.type;
+
+import org.bukkit.block.data.BlockData;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.type.Farmland} (Minecraft 1.13+).
+ */
+public interface Farmland extends BlockData {
+
+ int getMoisture();
+
+ void setMoisture(int moisture);
+
+ int getMaximumMoisture();
+}
diff --git a/compat-stubs/src/main/java/org/bukkit/block/data/type/GlassPane.java b/compat-stubs/src/main/java/org/bukkit/block/data/type/GlassPane.java
new file mode 100644
index 0000000000..a7c5911e84
--- /dev/null
+++ b/compat-stubs/src/main/java/org/bukkit/block/data/type/GlassPane.java
@@ -0,0 +1,21 @@
+package org.bukkit.block.data.type;
+
+import java.util.Set;
+
+import org.bukkit.block.BlockFace;
+import org.bukkit.block.data.Waterlogged;
+
+/**
+ * Compile-only stub for {@code org.bukkit.block.data.type.GlassPane} (Minecraft 1.13+). Mirrors the
+ * subset of {@code MultipleFacing} and {@code Waterlogged} that Slimefun uses.
+ */
+public interface GlassPane extends Waterlogged {
+
+ boolean hasFace(BlockFace face);
+
+ void setFace(BlockFace face, boolean has);
+
+ Set
+ * {@code RecipeChoice} is a real interface, but {@code MaterialChoice} is a real concrete class — it
+ * must be stubbed as a class (not an interface) so that {@code getChoices()} compiles to
+ * {@code invokevirtual} and resolves against the real class at runtime.
+ */
+public interface RecipeChoice extends Predicate
+ * This is the offline fallback used when the module could not be downloaded from GitHub (for
+ * example when no release is published on the Metrics repository), so that bStats metrics still
+ * work without any manual setup.
+ *
+ * @return Whether the bundled module was successfully extracted.
+ */
+ private boolean extractBundledModule() {
+ try (InputStream input = Slimefun.class.getClassLoader().getResourceAsStream(JAR_NAME + ".jar")) {
+ if (input == null) {
+ return false;
+ }
+
+ Files.copy(input, metricsModuleFile.toPath(), StandardCopyOption.REPLACE_EXISTING);
+ plugin.getLogger().info("Using bundled " + JAR_NAME + " module (offline fallback).");
+ return true;
+ } catch (IOException e) {
+ plugin.getLogger().log(Level.WARNING, "Failed to extract the bundled metrics module: {0}", e.getMessage());
+ return false;
+ }
+ }
+
/**
* This will close the child {@link ClassLoader} and mark all the resources held under this no longer
* in use, they will be cleaned up the next GC run.
@@ -171,7 +254,7 @@ public void cleanUp() {
*
* @param currentVersion
* The current version which is being used.
- *
+ *
* @return if there is an update available.
*/
public boolean checkForUpdate(@Nullable String currentVersion) {
@@ -197,19 +280,26 @@ public boolean checkForUpdate(@Nullable String currentVersion) {
* @return The latest version as an integer or -1 if it failed to fetch.
*/
private int getLatestVersion() {
+ HttpURLConnection connection = null;
+
try {
- HttpResponse
+ * Java 8: we use {@link HttpURLConnection} instead of the Java 11 {@link java.net.http.HttpClient}
+ * so the universal jar runs on legacy (1.8+) servers running Java 8.
+ */
+ @Nonnull
+ private HttpURLConnection openConnection(@Nonnull String url) throws IOException {
+ HttpURLConnection connection = (HttpURLConnection) new URL(url).openConnection();
+ connection.setConnectTimeout(TIMEOUT);
+ connection.setReadTimeout(TIMEOUT);
+ connection.setRequestProperty("User-Agent", "MetricsModule Auto-Updater");
+ connection.setRequestProperty("Accept", "application/vnd.github.v3+json");
+ return connection;
}
- private
+ * GitHub's {@code /contributors} endpoint only reports authors of the default branch, so
+ * anyone whose work lives on a feature/development branch (a very common situation for forks) is
+ * never credited. This connector walks the commit history of a configured development branch so
+ * that everyone who contributes to this fork is shown in the credits, not just the
+ * original upstream contributors.
+ *
+ * @author intisy
+ *
+ * @see ContributionsConnector
+ * @see GitHubService
+ */
+class CommitsConnector extends GitHubConnector {
+
+ /**
+ * GitHub Bots and invalid accounts that should not be counted as contributors.
+ */
+ private final List
- * {@literal Material.OAK_LOG} for example will return {@literal Material.OAK_PLANKS}.
+ * {@literal XMaterial.OAK_LOG.parseMaterial()} for example will return {@literal Material.OAK_PLANKS}.
*
* @param log
* The log type.
@@ -101,7 +105,7 @@ public List