Add comprehensive Vitest unit-test suite for soroban.ts (transaction building, parsing, formatting)

[prodbycorne]

Problem

src/lib/soroban.ts is the most critical file in the codebase (all contract interactions flow through it) but has zero test coverage. The parsePoolsFromXdr, parseUserPositionFromXdr, and parseCreditsFromXdr stubs, the formatCredits / formatAssetAmount utilities, and the transaction-building logic in lockAssets / unlockAssets are all untested.

Acceptance Criteria

• __tests__/soroban.test.ts covers at minimum:
  • formatCredits: sub-1000, thousands (K), millions (M)
  • formatLockTime: past timestamp → "Unlockable now"; future timestamps at day/hour/sub-hour granularities
  • formatAssetAmount: native XLM and issued asset formatting
  • parsePoolsFromXdr: a valid ScVec → correct PoolInfo[]; empty vec → []; malformed entry → skipped with warning
  • parseUserPositionFromXdr: valid position map → full UserPosition; null ScVal → null
  • parseCreditsFromXdr: i128 stroops → display string conversion
  • Transaction builder helpers: correct Operation.invokeContractFunction args for lock_assets (amount as i128, address as ScAddress)
• Mocks for @stellar/stellar-sdk RPC methods (simulateTransaction, sendTransaction, getTransaction) are set up with vi.mock so tests run without a live RPC endpoint
• All tests pass under pnpm vitest run
• Coverage target: ≥ 80 % line coverage on src/lib/soroban.ts

Relevant Files

• src/lib/soroban.ts — file under test
• __tests__/soroban.test.ts — create this file
• package.json — confirm vitest is already in devDependencies (if not, add it)

[clintjeff2]

Hello, I have 6 years of experience working on tasks like this and handling similar challenges across backend, frontend, and smart-contract development. I have carefully read and fully understood the task requirements, and I am confident I can deliver a clean, efficient, and well-tested solution promptly. I always ensure high-quality implementation, maintainability, and adherence to best practices.

Pull request in 5 hours.

[Joneshaves]

Hi, I'd like to take this on.

I just merged #28 (the Zustand farm-store migration) in this repo, so I'm already set up with the project's conventions and build. I've read through src/lib/soroban.ts and soroban-parsers.ts, so I know the layout: the XDR parse helpers delegate to pure functions in soroban-parsers.ts, and the SorobanService methods wrap the rpc.Server flow (getAccount → simulateTransaction → sendTransaction).

Plan for __tests__/soroban.test.ts:

• formatCredits / formatLockTime / formatAssetAmount across the boundary cases in the AC
• parsePoolsFromXdr (valid vec, empty vec, malformed entry skipped), parseUserPositionFromXdr (full map + null ScVal), parseCreditsFromXdr (i128 stroops → display string)
• the lock_assets builder, asserting the i128 amount and ScAddress args
• vi.mock over the @stellar/stellar-sdk RPC surface (simulateTransaction, sendTransaction, getTransaction, plus getAccount / assembleTransaction) so the suite runs with no live endpoint
• driving the SorobanService methods to reach ≥80% line coverage on soroban.ts, with the coverage report included in the PR

I can have a PR up shortly. Thanks!

[grantfox-oss]

🦊 GrantFox — @Joneshaves has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #25)
2. Your PR will be reviewed by the SmartDropLabs maintainers

Good luck! Track your progress on GrantFox.