Promote Holmes to M3 with schemas and negative fixtures#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes Holmes from M2 to an M3 evidence set by adding explicit contract schemas and negative-fixture enforcement.
This PR adds:
schemas/holmes-surface.schema.jsonschemas/holmes-proof-claim-contract.schema.jsonfixtures/invalid/tools/run_negative_fixtures.pytools/validate_holmes.pyvalidate-contractsandvalidate-negative-fixturesMakefile targetsrepo.maturity.yamlupdated to M3 -> M4 with evidence naming schemas, fixtures, runner, CI, and validation gatesWhy
Per the estate maturity model, M3 requires CI validation plus negative fixtures and a negative-fixture runner. Holmes already had CI and positive validation; this PR completes the rejection side of the contract.
Validation
Expected:
Expected output includes:
Remaining M4 work