fix(lint): clear new socket/* rule violations from the fleet cascade

Apply autofixes from `socket/prefer-cached-for-loop`,
`socket/prefer-node-builtin-imports`, and `socket/sort-equality-disjunctions`
across the script and config surface, plus manual rewrites where the
autofix bailed (destructured `for...of`, non-bare iterable expressions,
and nested `for (const pattern of ESCALATION_PATTERNS)` loops).

Notable fixups:
- `packages/iocraft/index.mjs`: the `prefer-node-builtin-imports`
  autofix rewrote `import { arch, platform } from 'node:os'` to
  `import os from 'node:os'` but didn't update the call sites — fix
  them to `os.platform()` / `os.arch()` so the module still runs.
- `packages/iocraft/index.mjs`: restore `export default iocraft`
  with an inline disable. The umbrella package's documented public
  API is `import iocraft from '@socketaddon/iocraft'`; switching to a
  named export would be a breaking consumer-visible change.
- `.config/vitest.config.mts`: inline disable for `no-default-export`
  — Vitest config files must use `export default defineConfig(...)`.
- `scripts/publish.mts`: bypass the `max-file-lines` soft cap with
  the documented `max-file-lines: legitimate` marker. The file is a
  linear publish-orchestration script whose phases (download/verify,
  stage, rewrite deps, dry-run, publish, cleanup) are best read top
  to bottom; splitting would scatter the per-phase context.
- Add `!` non-null assertions on the new indexed accesses introduced
  by the cached-length for-loop rewrites so `noUncheckedIndexedAccess`
  still passes.

Author: jdalton

.config/vitest.config.mts

@@ -9,6 +9,7 @@ const isCoverageEnabled =
   process.env['COVERAGE'] === 'true' ||
   process.argv.some(arg => arg.includes('coverage'))
 
+// oxlint-disable-next-line socket/no-default-export -- Vitest config files must use `export default`.
 export default defineConfig({
   test: {
     deps: {

packages/iocraft/index.mjs

@@ -6,13 +6,13 @@
  */
 
 import { createRequire } from 'node:module'
-import { arch, platform } from 'node:os'
+import os from 'node:os'
 
 const require = createRequire(import.meta.url)
 
 export function getPlatformIdentifier() {
-  const platformName = platform()
-  const archName = arch()
+  const platformName = os.platform()
+  const archName = os.arch()
 
   if (
     platformName !== 'darwin' &&
@@ -80,4 +80,5 @@ export function loadNativeAddon() {
 
 const iocraft = loadNativeAddon()
 
+// oxlint-disable-next-line socket/no-default-export -- Published package public API (`@socketaddon/iocraft`); the documented consumer pattern is `import iocraft from '@socketaddon/iocraft'`.
 export default iocraft

scripts/check.mts

@@ -16,7 +16,7 @@ import process from 'node:process'
 
 const args = process.argv.slice(2)
 const forwardedArgs = args.filter(
-  a => a === '--all' || a === '--staged' || a === '--fix' || a === '--quiet',
+  a => a === '--all' || a === '--fix' || a === '--quiet' || a === '--staged',
 )
 
 try {

scripts/clean.mts

@@ -22,7 +22,8 @@ const PATTERNS: readonly string[] = ['coverage', 'dist', 'packages/*/.cache']
 const root = process.cwd()
 let removed = 0
 
-for (const pattern of PATTERNS) {
+for (let i = 0, { length } = PATTERNS; i < length; i += 1) {
+  const pattern = PATTERNS[i]!
   for await (const match of glob(pattern, { cwd: root })) {
     const target = path.resolve(root, match)
     await safeDelete(target)

scripts/lint.mts

@@ -144,8 +144,14 @@ export function runFiles(files: string[]): number {
 }
 
 export function shouldEscalate(files: string[]): boolean {
-  for (const f of files) {
-    for (const pattern of ESCALATION_PATTERNS) {
+  for (let i = 0, { length } = files; i < length; i += 1) {
+    const f = files[i]!
+    for (
+      let j = 0, { length: patternsLength } = ESCALATION_PATTERNS;
+      j < patternsLength;
+      j += 1
+    ) {
+      const pattern = ESCALATION_PATTERNS[j]!
       if (pattern.test(f)) {
         return true
       }

scripts/publish.mts

@@ -1,3 +1,4 @@
+/* max-file-lines: legitimate -- Linear publish-orchestration script: download/verify, stage, rewrite deps, dry-run, publish, cleanup. Splitting would scatter the per-phase context across files and obscure the order-of-operations the file header documents. */
 /**
  * Publish all `@socketaddon/*` packages to npm.
  *
@@ -271,7 +272,8 @@ export function readWorkspaceCatalog(
   const lines = yaml.split('\n')
   const catalog: Record<string, string> = { __proto__: null as never }
   let inCatalog = false
-  for (const line of lines) {
+  for (let i = 0, { length } = lines; i < length; i += 1) {
+    const line = lines[i]!
     if (line === 'catalog:') {
       inCatalog = true
       continue
@@ -309,11 +311,13 @@ export function rewriteDeps(
     'peerDependencies',
     'optionalDependencies',
   ] as const
-  for (const block of blocks) {
+  for (let i = 0, { length } = blocks; i < length; i += 1) {
+    const block = blocks[i]!
     const deps = pj[block] as Record<string, string> | undefined
     if (!deps) {
       continue
     }
+    // oxlint-disable-next-line socket/prefer-cached-for-loop -- `Object.entries(deps)` is a one-shot iterator; a cached-length loop would need a Map/Array materialization that defeats the optimization.
     for (const [name, spec] of Object.entries(deps)) {
       if (
         spec === 'workspace:*' ||
@@ -431,7 +435,8 @@ async function main(): Promise<void> {
   )
   // Include all per-platform packages in the version map so the umbrella's
   // optionalDependencies can resolve even if --platforms filters the publish set.
-  for (const { dir } of PER_PLATFORM_PACKAGES) {
+  for (let i = 0, { length } = PER_PLATFORM_PACKAGES; i < length; i += 1) {
+    const { dir } = PER_PLATFORM_PACKAGES[i]!
     if (!filteredPerPlatform.some(p => p.dir === dir)) {
       const info = readPackage(dir)
       workspaceVersions.set(info.name, info.version)
@@ -441,7 +446,8 @@ async function main(): Promise<void> {
 
   const stagingDirs: string[] = []
   const cleanup = (): void => {
-    for (const d of stagingDirs) {
+    for (let i = 0, { length } = stagingDirs; i < length; i += 1) {
+      const d = stagingDirs[i]!
       try {
         safeDeleteSync(d)
       } catch {
@@ -472,16 +478,18 @@ async function main(): Promise<void> {
 
   try {
     // Per-platform first.
-    for (const pkg of allPackages.filter(p => p.releaseSuffix)) {
-      await publishPackage(pkg, ctx)
+    const perPlatformPkgs = allPackages.filter(p => p.releaseSuffix)
+    for (let i = 0, { length } = perPlatformPkgs; i < length; i += 1) {
+      await publishPackage(perPlatformPkgs[i]!, ctx)
     }
     // Umbrella last so its optionalDependencies can resolve.
     const umbrella = allPackages.find(p => !p.releaseSuffix)
     if (umbrella) {
       await publishPackage(umbrella, ctx)
     }
   } finally {
-    for (const d of stagingDirs) {
+    for (let i = 0, { length } = stagingDirs; i < length; i += 1) {
+      const d = stagingDirs[i]!
       await safeDelete(d)
     }
   }

scripts/test.mts

@@ -72,7 +72,8 @@ export function gitFiles(command: string): string[] {
 
 export function resolveTestPatterns(files: string[]): string[] {
   const patterns = new Set<string>()
-  for (const f of files) {
+  for (let i = 0, { length } = files; i < length; i += 1) {
+    const f = files[i]!
     if (/^packages\/[^/]+\/test\/.*\.test\.(m?[jt]s)$/.test(f)) {
       patterns.add(f)
       continue
@@ -126,8 +127,14 @@ export function runScoped(patterns: string[]): number {
 }
 
 export function shouldEscalate(files: string[]): boolean {
-  for (const f of files) {
-    for (const pattern of ESCALATION_PATTERNS) {
+  for (let i = 0, { length } = files; i < length; i += 1) {
+    const f = files[i]!
+    for (
+      let j = 0, { length: patternsLength } = ESCALATION_PATTERNS;
+      j < patternsLength;
+      j += 1
+    ) {
+      const pattern = ESCALATION_PATTERNS[j]!
       if (pattern.test(f)) {
         return true
       }